From: Dan Williams <dan.j.williams@intel.com> To: linux-nvdimm@lists.01.org Cc: Jan Kara <jack@suse.cz>, Matthew Wilcox <mawilcox@microsoft.com>, x86@kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, hch@lst.de Subject: [PATCH v4 11/16] libnvdimm, pmem: fix persistence warning Date: Thu, 29 Jun 2017 10:53:56 -0700 [thread overview] Message-ID: <149875883642.10031.1077982680312378809.stgit@dwillia2-desk3.amr.corp.intel.com> (raw) In-Reply-To: <149875877608.10031.17813337234536358002.stgit@dwillia2-desk3.amr.corp.intel.com> The pmem driver assumes if platform firmware describes the memory devices associated with a persistent memory range and CONFIG_ARCH_HAS_PMEM_API=y that it has all the mechanism necessary to flush data to a power-fail safe zone. We warn if the firmware does not describe memory devices, but we also need to warn if the architecture does not claim pmem support. Cc: Jeff Moyer <jmoyer@redhat.com> Cc: Christoph Hellwig <hch@lst.de> Cc: Matthew Wilcox <mawilcox@microsoft.com> Cc: Ross Zwisler <ross.zwisler@linux.intel.com> Reviewed-by: Jan Kara <jack@suse.cz> Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- drivers/nvdimm/region_devs.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/nvdimm/region_devs.c b/drivers/nvdimm/region_devs.c index 3c06a6ea6958..41b4cdf5dea8 100644 --- a/drivers/nvdimm/region_devs.c +++ b/drivers/nvdimm/region_devs.c @@ -1037,8 +1037,9 @@ int nvdimm_has_flush(struct nd_region *nd_region) { int i; - /* no nvdimm == flushing capability unknown */ - if (nd_region->ndr_mappings == 0) + /* no nvdimm or pmem api == flushing capability unknown */ + if (nd_region->ndr_mappings == 0 + || !IS_ENABLED(CONFIG_ARCH_HAS_PMEM_API)) return -ENXIO; for (i = 0; i < nd_region->ndr_mappings; i++) { _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com> To: linux-nvdimm@lists.01.org Cc: Jan Kara <jack@suse.cz>, Matthew Wilcox <mawilcox@microsoft.com>, x86@kernel.org, linux-kernel@vger.kernel.org, Jeff Moyer <jmoyer@redhat.com>, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, Ross Zwisler <ross.zwisler@linux.intel.com>, hch@lst.de Subject: [PATCH v4 11/16] libnvdimm, pmem: fix persistence warning Date: Thu, 29 Jun 2017 10:53:56 -0700 [thread overview] Message-ID: <149875883642.10031.1077982680312378809.stgit@dwillia2-desk3.amr.corp.intel.com> (raw) In-Reply-To: <149875877608.10031.17813337234536358002.stgit@dwillia2-desk3.amr.corp.intel.com> The pmem driver assumes if platform firmware describes the memory devices associated with a persistent memory range and CONFIG_ARCH_HAS_PMEM_API=y that it has all the mechanism necessary to flush data to a power-fail safe zone. We warn if the firmware does not describe memory devices, but we also need to warn if the architecture does not claim pmem support. Cc: Jeff Moyer <jmoyer@redhat.com> Cc: Christoph Hellwig <hch@lst.de> Cc: Matthew Wilcox <mawilcox@microsoft.com> Cc: Ross Zwisler <ross.zwisler@linux.intel.com> Reviewed-by: Jan Kara <jack@suse.cz> Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- drivers/nvdimm/region_devs.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/nvdimm/region_devs.c b/drivers/nvdimm/region_devs.c index 3c06a6ea6958..41b4cdf5dea8 100644 --- a/drivers/nvdimm/region_devs.c +++ b/drivers/nvdimm/region_devs.c @@ -1037,8 +1037,9 @@ int nvdimm_has_flush(struct nd_region *nd_region) { int i; - /* no nvdimm == flushing capability unknown */ - if (nd_region->ndr_mappings == 0) + /* no nvdimm or pmem api == flushing capability unknown */ + if (nd_region->ndr_mappings == 0 + || !IS_ENABLED(CONFIG_ARCH_HAS_PMEM_API)) return -ENXIO; for (i = 0; i < nd_region->ndr_mappings; i++) {
next prev parent reply other threads:[~2017-06-29 17:58 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-06-29 17:52 [PATCH v4 00/16] pmem: stop abusing copy_user_nocache(), and other reworks Dan Williams 2017-06-29 17:52 ` Dan Williams 2017-06-29 17:53 ` [PATCH v4 01/16] x86, uaccess: introduce copy_from_iter_flushcache for pmem / cache-bypass operations Dan Williams 2017-06-29 17:53 ` Dan Williams 2017-06-29 17:53 ` [PATCH v4 02/16] dm: add ->copy_from_iter() dax operation support Dan Williams 2017-06-29 17:53 ` Dan Williams 2017-06-29 17:53 ` [PATCH v4 03/16] filesystem-dax: convert to dax_copy_from_iter() Dan Williams 2017-06-29 17:53 ` Dan Williams 2017-06-29 17:53 ` [PATCH v4 04/16] dax, pmem: introduce an optional 'flush' dax_operation Dan Williams 2017-06-29 17:53 ` Dan Williams 2017-06-29 17:53 ` [PATCH v4 05/16] dm: add ->flush() dax operation support Dan Williams 2017-06-29 17:53 ` Dan Williams 2017-06-29 17:53 ` [PATCH v4 06/16] filesystem-dax: convert to dax_flush() Dan Williams 2017-06-29 17:53 ` Dan Williams 2017-06-29 17:53 ` [PATCH v4 07/16] x86, dax: replace clear_pmem() with open coded memset + dax_ops->flush Dan Williams 2017-06-29 17:53 ` Dan Williams 2017-06-29 17:53 ` [PATCH v4 08/16] x86, dax, libnvdimm: remove wb_cache_pmem() indirection Dan Williams 2017-06-29 17:53 ` Dan Williams 2017-06-29 17:53 ` [PATCH v4 09/16] x86, libnvdimm, pmem: move arch_invalidate_pmem() to libnvdimm Dan Williams 2017-06-29 17:53 ` Dan Williams 2017-06-29 17:53 ` [PATCH v4 10/16] x86, libnvdimm, pmem: remove global pmem api Dan Williams 2017-06-29 17:53 ` Dan Williams 2017-06-29 17:53 ` Dan Williams [this message] 2017-06-29 17:53 ` [PATCH v4 11/16] libnvdimm, pmem: fix persistence warning Dan Williams 2017-06-29 17:54 ` [PATCH v4 12/16] libnvdimm, nfit: enable support for volatile ranges Dan Williams 2017-06-29 17:54 ` Dan Williams 2017-06-29 19:20 ` Linda Knippers 2017-06-29 19:20 ` Linda Knippers 2017-06-29 20:42 ` Dan Williams 2017-06-29 20:42 ` Dan Williams 2017-06-29 21:16 ` Linda Knippers 2017-06-29 21:16 ` Linda Knippers 2017-06-29 21:50 ` Dan Williams 2017-06-29 21:50 ` Dan Williams 2017-06-29 22:12 ` Linda Knippers 2017-06-29 22:12 ` Linda Knippers 2017-06-29 22:28 ` Dan Williams 2017-06-29 22:28 ` Dan Williams 2017-06-29 22:35 ` Linda Knippers 2017-06-29 22:35 ` Linda Knippers 2017-06-29 22:43 ` Dan Williams 2017-06-29 22:43 ` Dan Williams 2017-06-29 22:49 ` Linda Knippers 2017-06-29 22:49 ` Linda Knippers 2017-06-29 22:58 ` Dan Williams 2017-06-29 22:58 ` Dan Williams 2017-06-29 23:14 ` Linda Knippers 2017-06-29 23:14 ` Linda Knippers 2017-06-30 1:28 ` Dan Williams 2017-06-30 1:28 ` Dan Williams 2017-07-05 23:46 ` Kani, Toshimitsu 2017-07-05 23:46 ` Kani, Toshimitsu 2017-07-06 0:07 ` Dan Williams 2017-07-06 0:07 ` Dan Williams 2017-07-06 1:17 ` Kani, Toshimitsu 2017-07-06 1:17 ` Kani, Toshimitsu 2017-07-06 2:08 ` Dan Williams 2017-07-06 2:08 ` Dan Williams 2017-07-06 2:11 ` hch 2017-07-06 2:11 ` hch 2017-07-06 2:53 ` Oliver 2017-07-06 2:53 ` Oliver 2017-07-06 2:56 ` hch 2017-07-06 2:56 ` hch 2017-06-29 17:54 ` [PATCH v4 13/16] dax: remove default copy_from_iter fallback Dan Williams 2017-06-29 17:54 ` Dan Williams 2017-06-29 17:54 ` [PATCH v4 14/16] dax: convert to bitmask for flags Dan Williams 2017-06-29 17:54 ` Dan Williams 2017-06-29 17:54 ` [PATCH v4 15/16] libnvdimm, pmem, dax: export a cache control attribute Dan Williams 2017-06-29 17:54 ` Dan Williams 2017-06-29 17:54 ` [PATCH v4 16/16] libnvdimm, pmem: disable dax flushing when pmem is fronting a volatile region Dan Williams 2017-06-29 17:54 ` Dan Williams
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=149875883642.10031.1077982680312378809.stgit@dwillia2-desk3.amr.corp.intel.com \ --to=dan.j.williams@intel.com \ --cc=hch@lst.de \ --cc=jack@suse.cz \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvdimm@lists.01.org \ --cc=mawilcox@microsoft.com \ --cc=viro@zeniv.linux.org.uk \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.