From: Florian Echtler <floe@butterbrot.org>
To: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com,
peter.hutterer@who-t.net
Cc: Florian Echtler <floe@butterbrot.org>,
Martin Kaltenbrunner <modin@yuri.at>
Subject: [PATCH v2 2/3] silence unnecessary noisy debug output
Date: Mon, 10 Jul 2017 17:42:25 +0200 [thread overview]
Message-ID: <1499701346-12110-2-git-send-email-floe@butterbrot.org> (raw)
In-Reply-To: <1499701346-12110-1-git-send-email-floe@butterbrot.org>
This information is unneccessary, even as debug output.
Leave commented out as documentation of the packet ID quirk.
Signed-off-by: Martin Kaltenbrunner <modin@yuri.at>
Signed-off-by: Florian Echtler <floe@butterbrot.org>
---
drivers/input/touchscreen/sur40.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c
index 259aef5..953d2ff 100644
--- a/drivers/input/touchscreen/sur40.c
+++ b/drivers/input/touchscreen/sur40.c
@@ -374,10 +374,13 @@ static void sur40_poll(struct input_polled_dev *polldev)
/*
* Sanity check. when video data is also being retrieved, the
* packet ID will usually increase in the middle of a series
- * instead of at the end.
- */
- if (packet_id != le32_to_cpu(header->packet_id))
+ * instead of at the end. However, the data is still consistent,
+ * so the packet ID is probably just valid for the first packet
+ * in a series.
+
+ if (packet_id != header->packet_id)
dev_dbg(sur40->dev, "packet ID mismatch\n");
+ */
packet_blobs = result / sizeof(struct sur40_blob);
dev_dbg(sur40->dev, "received %d blobs\n", packet_blobs);
--
2.7.4
next prev parent reply other threads:[~2017-07-10 15:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 15:42 [PATCH v2 1/3] add additional reverse-engineered information Florian Echtler
2017-07-10 15:42 ` Florian Echtler [this message]
2017-07-10 15:42 ` [PATCH v2 3/3] skip all blobs that are not touches Florian Echtler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499701346-12110-2-git-send-email-floe@butterbrot.org \
--to=floe@butterbrot.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=modin@yuri.at \
--cc=peter.hutterer@who-t.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.