All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: dri-devel@lists.freedesktop.org
Cc: jani.nikula@intel.com, intel-gfx@lists.freedesktop.org
Subject: [PATCH 4/6] drm/imx: prefer snprintf over sprintf
Date: Wed, 10 Jan 2024 19:39:14 +0200	[thread overview]
Message-ID: <14c0108a54007a8360d84162a1d63cba9613b945.1704908087.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1704908087.git.jani.nikula@intel.com>

This will trade the W=1 warning -Wformat-overflow to
-Wformat-truncation. This lets us enable -Wformat-overflow subsystem
wide.

Cc: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/imx/ipuv3/imx-ldb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/imx/ipuv3/imx-ldb.c b/drivers/gpu/drm/imx/ipuv3/imx-ldb.c
index 53840ab054c7..71d70194fcbd 100644
--- a/drivers/gpu/drm/imx/ipuv3/imx-ldb.c
+++ b/drivers/gpu/drm/imx/ipuv3/imx-ldb.c
@@ -655,7 +655,7 @@ static int imx_ldb_probe(struct platform_device *pdev)
 	for (i = 0; i < 4; i++) {
 		char clkname[16];
 
-		sprintf(clkname, "di%d_sel", i);
+		snprintf(clkname, sizeof(clkname), "di%d_sel", i);
 		imx_ldb->clk_sel[i] = devm_clk_get(imx_ldb->dev, clkname);
 		if (IS_ERR(imx_ldb->clk_sel[i])) {
 			ret = PTR_ERR(imx_ldb->clk_sel[i]);
-- 
2.39.2


WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@intel.com>
To: dri-devel@lists.freedesktop.org
Cc: jani.nikula@intel.com, intel-gfx@lists.freedesktop.org,
	Philipp Zabel <p.zabel@pengutronix.de>
Subject: [PATCH 4/6] drm/imx: prefer snprintf over sprintf
Date: Wed, 10 Jan 2024 19:39:14 +0200	[thread overview]
Message-ID: <14c0108a54007a8360d84162a1d63cba9613b945.1704908087.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1704908087.git.jani.nikula@intel.com>

This will trade the W=1 warning -Wformat-overflow to
-Wformat-truncation. This lets us enable -Wformat-overflow subsystem
wide.

Cc: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/imx/ipuv3/imx-ldb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/imx/ipuv3/imx-ldb.c b/drivers/gpu/drm/imx/ipuv3/imx-ldb.c
index 53840ab054c7..71d70194fcbd 100644
--- a/drivers/gpu/drm/imx/ipuv3/imx-ldb.c
+++ b/drivers/gpu/drm/imx/ipuv3/imx-ldb.c
@@ -655,7 +655,7 @@ static int imx_ldb_probe(struct platform_device *pdev)
 	for (i = 0; i < 4; i++) {
 		char clkname[16];
 
-		sprintf(clkname, "di%d_sel", i);
+		snprintf(clkname, sizeof(clkname), "di%d_sel", i);
 		imx_ldb->clk_sel[i] = devm_clk_get(imx_ldb->dev, clkname);
 		if (IS_ERR(imx_ldb->clk_sel[i])) {
 			ret = PTR_ERR(imx_ldb->clk_sel[i]);
-- 
2.39.2


  parent reply	other threads:[~2024-01-10 17:39 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-10 17:39 [PATCH 0/6] drm: enable W=1 warnings by default across the subsystem Jani Nikula
2024-01-10 17:39 ` [PATCH 1/6] drm/nouveau/acr/ga102: remove unused but set variable Jani Nikula
2024-01-10 17:39   ` Jani Nikula
2024-01-31 12:50   ` Jani Nikula
2024-01-31 12:50     ` Jani Nikula
2024-01-31 19:01   ` Danilo Krummrich
2024-01-31 19:01     ` Danilo Krummrich
2024-02-01  9:41     ` Jani Nikula
2024-02-01  9:41       ` Jani Nikula
2024-01-10 17:39 ` [PATCH 2/6] drm/nouveau/svm: remove unused but set variables Jani Nikula
2024-01-10 17:39   ` Jani Nikula
2024-01-31 12:51   ` Jani Nikula
2024-01-31 12:51     ` Jani Nikula
2024-01-31 19:10   ` Danilo Krummrich
2024-01-31 19:10     ` Danilo Krummrich
2024-02-01  9:42     ` Jani Nikula
2024-02-01  9:42       ` Jani Nikula
2024-01-10 17:39 ` [PATCH 3/6] drm/amdgpu: prefer snprintf over sprintf Jani Nikula
2024-01-12  4:09   ` kernel test robot
2024-01-12  4:09     ` kernel test robot
2024-01-12  9:07     ` Jani Nikula
2024-01-12  9:07       ` Jani Nikula
2024-01-12 14:57   ` Alex Deucher
2024-01-31 12:48     ` Jani Nikula
2024-01-31 12:48       ` Jani Nikula
2024-01-10 17:39 ` Jani Nikula [this message]
2024-01-10 17:39   ` [PATCH 4/6] drm/imx: " Jani Nikula
2024-01-12 10:49   ` kernel test robot
2024-01-12 10:49     ` kernel test robot
2024-01-12 14:20   ` Philipp Zabel
2024-01-31 12:49     ` Jani Nikula
2024-01-10 17:39 ` [PATCH 5/6] drm: enable (most) W=1 warnings by default across the subsystem Jani Nikula
2024-01-10 17:39   ` Jani Nikula
2024-01-10 20:15   ` Hamza Mahfooz
2024-01-10 20:15     ` Hamza Mahfooz
2024-01-11  9:43     ` Jani Nikula
2024-01-11  9:43       ` Jani Nikula
2024-01-10 17:39 ` [PATCH 6/6] drm: Add CONFIG_DRM_WERROR Jani Nikula
2024-01-10 20:17   ` Hamza Mahfooz
2024-01-10 18:52 ` ✗ Fi.CI.CHECKPATCH: warning for drm: enable W=1 warnings by default across the subsystem (rev2) Patchwork
2024-01-10 18:52 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-01-10 19:03 ` ✓ Fi.CI.BAT: success " Patchwork
2024-01-10 23:00 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-04-04 15:16 ` [PATCH 0/6] drm: enable W=1 warnings by default across the subsystem Aishwarya TCV
2024-04-05  9:57   ` Jani Nikula
2024-04-05 10:28     ` Aishwarya TCV

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14c0108a54007a8360d84162a1d63cba9613b945.1704908087.git.jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.