All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Lluís Vilanova" <vilanova@ac.upc.edu>
To: qemu-devel@nongnu.org
Cc: "Emilio G. Cota" <cota@braap.org>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Richard Henderson" <rth@twiddle.net>,
	"Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"open list:ARM" <qemu-arm@nongnu.org>
Subject: [Qemu-devel] [PATCH v13 25/26] target/arm: [tcg, a64] Port to disas_log
Date: Fri, 14 Jul 2017 12:54:29 +0300	[thread overview]
Message-ID: <150002606914.22386.15524101311003685068.stgit@frigg.lan> (raw)
In-Reply-To: <150002001195.22386.4679134058536830996.stgit@frigg.lan>

Incrementally paves the way towards using the generic instruction translation
loop.

Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
Reviewed-by: Richard Henderson <rth@twiddle.net>
---
 target/arm/translate-a64.c |   14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index caeec69d93..5de7fbde29 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -11380,6 +11380,16 @@ static void aarch64_tr_tb_stop(DisasContextBase *dcbase, CPUState *cpu)
     }
 }
 
+static void aarch64_tr_disas_log(const DisasContextBase *dcbase,
+                                      CPUState *cpu)
+{
+    DisasContext *dc = container_of(dcbase, DisasContext, base);
+
+    qemu_log("IN: %s\n", lookup_symbol(dc->base.pc_first));
+    log_target_disas(cpu, dc->base.pc_first, dc->pc - dc->base.pc_first,
+                     4 | (bswap_code(dc->sctlr_b) ? 2 : 0));
+}
+
 void gen_intermediate_code_a64(DisasContextBase *dcbase, CPUState *cs,
                                TranslationBlock *tb)
 {
@@ -11461,9 +11471,7 @@ void gen_intermediate_code_a64(DisasContextBase *dcbase, CPUState *cs,
         qemu_log_in_addr_range(dc->base.pc_first)) {
         qemu_log_lock();
         qemu_log("----------------\n");
-        qemu_log("IN: %s\n", lookup_symbol(dc->base.pc_first));
-        log_target_disas(cs, dc->base.pc_first, dc->pc - dc->base.pc_first,
-                         4 | (bswap_code(dc->sctlr_b) ? 2 : 0));
+        aarch64_tr_disas_log(&dc->base, cs);
         qemu_log("\n");
         qemu_log_unlock();
     }

  parent reply	other threads:[~2017-07-14  9:54 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-14  8:13 [Qemu-devel] [PATCH v13 00/26] translate: [tcg] Generic translation framework Lluís Vilanova
2017-07-14  8:17 ` [Qemu-devel] [PATCH v13 01/26] Pass generic CPUState to gen_intermediate_code() Lluís Vilanova
2017-07-14  8:21 ` [Qemu-devel] [PATCH v13 02/26] target: [tcg] Use a generic enum for DISAS_ values Lluís Vilanova
2017-07-14  8:25 ` [Qemu-devel] [PATCH v13 03/26] target: [tcg] Add generic translation framework Lluís Vilanova
2017-07-14 16:48   ` Richard Henderson
2017-07-15  7:34     ` Lluís Vilanova
2017-07-14  8:29 ` [Qemu-devel] [PATCH v13 04/26] target/i386: [tcg] Port to DisasContextBase Lluís Vilanova
2017-07-14  8:33 ` [Qemu-devel] [PATCH v13 05/26] target/i386: [tcg] Port to init_disas_context Lluís Vilanova
2017-07-14  8:37 ` [Qemu-devel] [PATCH v13 06/26] target/i386: [tcg] Port to insn_start Lluís Vilanova
2017-07-14  8:41 ` [Qemu-devel] [PATCH v13 07/26] target/i386: [tcg] Port to breakpoint_check Lluís Vilanova
2017-07-14  8:45 ` [Qemu-devel] [PATCH v13 08/26] target/i386: [tcg] Port to translate_insn Lluís Vilanova
2017-07-14  8:49 ` [Qemu-devel] [PATCH v13 09/26] target/i386: [tcg] Port to tb_stop Lluís Vilanova
2017-07-14  8:53 ` [Qemu-devel] [PATCH v13 10/26] target/i386: [tcg] Port to disas_log Lluís Vilanova
2017-07-14  8:57 ` [Qemu-devel] [PATCH v13 11/26] target/i386: [tcg] Port to generic translation framework Lluís Vilanova
2017-07-14  9:01 ` [Qemu-devel] [PATCH v13 12/26] target/arm: [tcg] Port to DisasContextBase Lluís Vilanova
2017-07-14  9:06 ` [Qemu-devel] [PATCH v13 13/26] target/arm: [tcg] Port to init_disas_context Lluís Vilanova
2017-07-14  9:10 ` [Qemu-devel] [PATCH v13 14/26] target/arm: [tcg, a64] " Lluís Vilanova
2017-07-14  9:14 ` [Qemu-devel] [PATCH v13 15/26] target/arm: [tcg] Port to tb_start Lluís Vilanova
2017-07-14  9:18 ` [Qemu-devel] [PATCH v13 16/26] target/arm: [tcg] Port to insn_start Lluís Vilanova
2017-07-14  9:22 ` [Qemu-devel] [PATCH v13 17/26] target/arm: [tcg, a64] " Lluís Vilanova
2017-07-14  9:26 ` [Qemu-devel] [PATCH v13 18/26] target/arm: [tcg] Port to breakpoint_check Lluís Vilanova
2017-07-14 17:26   ` Richard Henderson
2017-07-14 17:42     ` Richard Henderson
2017-07-15  7:56       ` Lluís Vilanova
2017-07-15 17:52         ` Richard Henderson
2017-07-15  7:46     ` Lluís Vilanova
2017-07-14  9:30 ` [Qemu-devel] [PATCH v13 19/26] target/arm: [tcg, a64] " Lluís Vilanova
2017-07-14  9:34 ` [Qemu-devel] [PATCH v13 20/26] target/arm: [tcg] Port to translate_insn Lluís Vilanova
2017-07-14  9:38 ` [Qemu-devel] [PATCH v13 21/26] target/arm: [tcg, a64] " Lluís Vilanova
2017-07-14  9:42 ` [Qemu-devel] [PATCH v13 22/26] target/arm: [tcg] Port to tb_stop Lluís Vilanova
2017-07-14 17:33   ` Richard Henderson
2017-07-15  7:56     ` Lluís Vilanova
2017-07-15 17:54       ` Richard Henderson
2017-07-14  9:46 ` [Qemu-devel] [PATCH v13 23/26] target/arm: [tcg, a64] " Lluís Vilanova
2017-07-14  9:50 ` [Qemu-devel] [PATCH v13 24/26] target/arm: [tcg] Port to disas_log Lluís Vilanova
2017-07-14  9:54 ` Lluís Vilanova [this message]
2017-07-14  9:58 ` [Qemu-devel] [PATCH v13 26/26] target/arm: [tcg] Port to generic translation framework Lluís Vilanova
2017-07-14 12:06 ` [Qemu-devel] [PATCH v13 00/26] translate: [tcg] Generic " no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=150002606914.22386.15524101311003685068.stgit@frigg.lan \
    --to=vilanova@ac.upc.edu \
    --cc=alex.bennee@linaro.org \
    --cc=cota@braap.org \
    --cc=crosthwaite.peter@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.