From: Arvind Yadav <arvind.yadav.cs@gmail.com>
To: perex@perex.cz, tiwai@suse.com
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: [PATCH 7/7] ALSA: trident: constify snd_pcm_ops structures
Date: Thu, 10 Aug 2017 17:17:38 +0530 [thread overview]
Message-ID: <1502365658-24723-8-git-send-email-arvind.yadav.cs@gmail.com> (raw)
In-Reply-To: <1502365658-24723-1-git-send-email-arvind.yadav.cs@gmail.com>
snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
sound/pci/trident/trident_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/pci/trident/trident_main.c b/sound/pci/trident/trident_main.c
index 64d3b8e..4561040 100644
--- a/sound/pci/trident/trident_main.c
+++ b/sound/pci/trident/trident_main.c
@@ -2093,7 +2093,7 @@ static int snd_trident_foldback_close(struct snd_pcm_substream *substream)
.page = snd_pcm_sgbuf_ops_page,
};
-static struct snd_pcm_ops snd_trident_capture_ops = {
+static const struct snd_pcm_ops snd_trident_capture_ops = {
.open = snd_trident_capture_open,
.close = snd_trident_capture_close,
.ioctl = snd_trident_ioctl,
@@ -2104,7 +2104,7 @@ static int snd_trident_foldback_close(struct snd_pcm_substream *substream)
.pointer = snd_trident_capture_pointer,
};
-static struct snd_pcm_ops snd_trident_si7018_capture_ops = {
+static const struct snd_pcm_ops snd_trident_si7018_capture_ops = {
.open = snd_trident_capture_open,
.close = snd_trident_capture_close,
.ioctl = snd_trident_ioctl,
--
1.9.1
next prev parent reply other threads:[~2017-08-10 11:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 11:47 [PATCH 0/7] constify pci snd_pcm_ops structures Arvind Yadav
2017-08-10 11:47 ` [PATCH 1/7] ALSA: ali5451: constify " Arvind Yadav
2017-08-10 11:47 ` [PATCH 2/7] ALSA: au88x0: " Arvind Yadav
2017-08-10 11:47 ` [PATCH 3/7] ALSA: echoaudio: " Arvind Yadav
2017-08-10 11:47 ` [PATCH 4/7] ALSA: intel8x0: " Arvind Yadav
2017-08-10 11:47 ` [PATCH 5/7] ALSA: intel8x0m: " Arvind Yadav
2017-08-10 11:47 ` [PATCH 6/7] ALSA: sis7019: " Arvind Yadav
2017-08-10 11:47 ` Arvind Yadav [this message]
2017-08-10 15:57 ` [PATCH 0/7] constify pci " Takashi Iwai
2017-08-10 15:57 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502365658-24723-8-git-send-email-arvind.yadav.cs@gmail.com \
--to=arvind.yadav.cs@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.