From: Iyappan Subramanian <isubramanian@apm.com> To: davem@davemloft.net, netdev@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, dnelson@redhat.com, patches@apm.com, Quan Nguyen <qnguyen@apm.com>, Iyappan Subramanian <isubramanian@apm.com> Subject: [PATCH 2/3] drivers: net: xgene: Configure tx/rx delay for ACPI Date: Tue, 5 Sep 2017 11:16:31 -0700 [thread overview] Message-ID: <1504635392-19089-3-git-send-email-isubramanian@apm.com> (raw) In-Reply-To: <1504635392-19089-1-git-send-email-isubramanian@apm.com> From: Quan Nguyen <qnguyen@apm.com> This patch fixes configuring tx/rx delay values for ACPI. Signed-off-by: Quan Nguyen <qnguyen@apm.com> Signed-off-by: Iyappan Subramanian <isubramanian@apm.com> --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c index e45b587..3188f55 100644 --- a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c @@ -468,7 +468,6 @@ static void xgene_enet_configure_clock(struct xgene_enet_pdata *pdata) static void xgene_gmac_set_speed(struct xgene_enet_pdata *pdata) { - struct device *dev = &pdata->pdev->dev; u32 icm0, icm2, mc2; u32 intf_ctl, rgmii, value; @@ -500,10 +499,8 @@ static void xgene_gmac_set_speed(struct xgene_enet_pdata *pdata) intf_ctl |= ENET_GHD_MODE; CFG_MACMODE_SET(&icm0, 2); CFG_WAITASYNCRD_SET(&icm2, 0); - if (dev->of_node) { - CFG_TXCLK_MUXSEL0_SET(&rgmii, pdata->tx_delay); - CFG_RXCLK_MUXSEL0_SET(&rgmii, pdata->rx_delay); - } + CFG_TXCLK_MUXSEL0_SET(&rgmii, pdata->tx_delay); + CFG_RXCLK_MUXSEL0_SET(&rgmii, pdata->rx_delay); rgmii |= CFG_SPEED_1250; xgene_enet_rd_csr(pdata, DEBUG_REG_ADDR, &value); -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: isubramanian@apm.com (Iyappan Subramanian) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/3] drivers: net: xgene: Configure tx/rx delay for ACPI Date: Tue, 5 Sep 2017 11:16:31 -0700 [thread overview] Message-ID: <1504635392-19089-3-git-send-email-isubramanian@apm.com> (raw) In-Reply-To: <1504635392-19089-1-git-send-email-isubramanian@apm.com> From: Quan Nguyen <qnguyen@apm.com> This patch fixes configuring tx/rx delay values for ACPI. Signed-off-by: Quan Nguyen <qnguyen@apm.com> Signed-off-by: Iyappan Subramanian <isubramanian@apm.com> --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c index e45b587..3188f55 100644 --- a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c @@ -468,7 +468,6 @@ static void xgene_enet_configure_clock(struct xgene_enet_pdata *pdata) static void xgene_gmac_set_speed(struct xgene_enet_pdata *pdata) { - struct device *dev = &pdata->pdev->dev; u32 icm0, icm2, mc2; u32 intf_ctl, rgmii, value; @@ -500,10 +499,8 @@ static void xgene_gmac_set_speed(struct xgene_enet_pdata *pdata) intf_ctl |= ENET_GHD_MODE; CFG_MACMODE_SET(&icm0, 2); CFG_WAITASYNCRD_SET(&icm2, 0); - if (dev->of_node) { - CFG_TXCLK_MUXSEL0_SET(&rgmii, pdata->tx_delay); - CFG_RXCLK_MUXSEL0_SET(&rgmii, pdata->rx_delay); - } + CFG_TXCLK_MUXSEL0_SET(&rgmii, pdata->tx_delay); + CFG_RXCLK_MUXSEL0_SET(&rgmii, pdata->rx_delay); rgmii |= CFG_SPEED_1250; xgene_enet_rd_csr(pdata, DEBUG_REG_ADDR, &value); -- 2.7.4
next prev parent reply other threads:[~2017-09-05 18:16 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-09-05 18:16 [PATCH 0/3] drivers: net: xgene: Misc bug fixes Iyappan Subramanian 2017-09-05 18:16 ` Iyappan Subramanian 2017-09-05 18:16 ` [PATCH 1/3] drivers: net: xgene: Read tx/rx delay for ACPI Iyappan Subramanian 2017-09-05 18:16 ` Iyappan Subramanian 2017-09-05 18:16 ` Iyappan Subramanian [this message] 2017-09-05 18:16 ` [PATCH 2/3] drivers: net: xgene: Configure " Iyappan Subramanian 2017-09-05 18:16 ` [PATCH 3/3] drivers: net: xgene: Remove return statement from void function Iyappan Subramanian 2017-09-05 18:16 ` Iyappan Subramanian 2017-09-05 21:58 ` [PATCH 0/3] drivers: net: xgene: Misc bug fixes David Miller 2017-09-05 21:58 ` David Miller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1504635392-19089-3-git-send-email-isubramanian@apm.com \ --to=isubramanian@apm.com \ --cc=davem@davemloft.net \ --cc=dnelson@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=netdev@vger.kernel.org \ --cc=patches@apm.com \ --cc=qnguyen@apm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.