From: Yunlong Song <yunlong.song@huawei.com> To: <jaegeuk@kernel.org>, <chao@kernel.org>, <yuchao0@huawei.com>, <yunlong.song@icloud.com>, <yunlong.song@huawei.com> Cc: <miaoxie@huawei.com>, <bintian.wang@huawei.com>, <heyunlei@huawei.com>, <linux-fsdevel@vger.kernel.org>, <linux-f2fs-devel@lists.sourceforge.net>, <linux-kernel@vger.kernel.org> Subject: [PATCH] f2fs-tools: fix is_set_ckpt_flags for correct bool value Date: Sun, 10 Sep 2017 19:15:29 +0800 [thread overview] Message-ID: <1505042129-41945-1-git-send-email-yunlong.song@huawei.com> (raw) If flag bit to check is in 0xFFFFFF00, then the return value will be false, this is not correct, so fix it. Signed-off-by: Yunlong Song <yunlong.song@huawei.com> --- fsck/f2fs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fsck/f2fs.h b/fsck/f2fs.h index 871cffc..de03512 100644 --- a/fsck/f2fs.h +++ b/fsck/f2fs.h @@ -276,7 +276,7 @@ static inline void *__bitmap_ptr(struct f2fs_sb_info *sbi, int flag) static inline bool is_set_ckpt_flags(struct f2fs_checkpoint *cp, unsigned int f) { unsigned int ckpt_flags = le32_to_cpu(cp->ckpt_flags); - return ckpt_flags & f; + return ckpt_flags & f ? 1 : 0; } static inline block_t __start_cp_addr(struct f2fs_sb_info *sbi) -- 1.8.5.2
WARNING: multiple messages have this Message-ID (diff)
From: Yunlong Song <yunlong.song@huawei.com> To: jaegeuk@kernel.org, chao@kernel.org, yuchao0@huawei.com, yunlong.song@icloud.com, yunlong.song@huawei.com Cc: miaoxie@huawei.com, bintian.wang@huawei.com, heyunlei@huawei.com, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [PATCH] f2fs-tools: fix is_set_ckpt_flags for correct bool value Date: Sun, 10 Sep 2017 19:15:29 +0800 [thread overview] Message-ID: <1505042129-41945-1-git-send-email-yunlong.song@huawei.com> (raw) If flag bit to check is in 0xFFFFFF00, then the return value will be false, this is not correct, so fix it. Signed-off-by: Yunlong Song <yunlong.song@huawei.com> --- fsck/f2fs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fsck/f2fs.h b/fsck/f2fs.h index 871cffc..de03512 100644 --- a/fsck/f2fs.h +++ b/fsck/f2fs.h @@ -276,7 +276,7 @@ static inline void *__bitmap_ptr(struct f2fs_sb_info *sbi, int flag) static inline bool is_set_ckpt_flags(struct f2fs_checkpoint *cp, unsigned int f) { unsigned int ckpt_flags = le32_to_cpu(cp->ckpt_flags); - return ckpt_flags & f; + return ckpt_flags & f ? 1 : 0; } static inline block_t __start_cp_addr(struct f2fs_sb_info *sbi) -- 1.8.5.2
next reply other threads:[~2017-09-10 11:15 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-09-10 11:15 Yunlong Song [this message] 2017-09-10 11:15 ` [PATCH] f2fs-tools: fix is_set_ckpt_flags for correct bool value Yunlong Song 2017-09-12 1:11 ` Chao Yu 2017-09-12 1:11 ` Chao Yu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1505042129-41945-1-git-send-email-yunlong.song@huawei.com \ --to=yunlong.song@huawei.com \ --cc=bintian.wang@huawei.com \ --cc=chao@kernel.org \ --cc=heyunlei@huawei.com \ --cc=jaegeuk@kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=miaoxie@huawei.com \ --cc=yuchao0@huawei.com \ --cc=yunlong.song@icloud.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.