From: Amir Goldstein <amir73il@gmail.com>
To: Eryu Guan <eguan@redhat.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
linux-unionfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH 1/2] overlay/014: correct comment relating to workdir reuse
Date: Tue, 19 Sep 2017 14:39:43 +0300 [thread overview]
Message-ID: <1505821184-3913-2-git-send-email-amir73il@gmail.com> (raw)
In-Reply-To: <1505821184-3913-1-git-send-email-amir73il@gmail.com>
Clarification: EBUSY is what you get when trying to use the same
upperdir/workdir with two different *concurent* overlayfs mounts.
The EBUSY case is independent of the inodes index feature.
This is not the case in this test, but rather the case of trying
to reuse the same workdir with different upper dirs on *subsequent*
overlayfs mounts.
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
tests/overlay/014 | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/tests/overlay/014 b/tests/overlay/014
index f228b15..cd76835 100755
--- a/tests/overlay/014
+++ b/tests/overlay/014
@@ -63,10 +63,9 @@ lowerdir1=$OVL_BASE_SCRATCH_MNT/lower1
lowerdir2=$OVL_BASE_SCRATCH_MNT/lower2
upperdir=$OVL_BASE_SCRATCH_MNT/upper
workdir=$OVL_BASE_SCRATCH_MNT/workdir
-# When overlay inode index feature is enabled, using an upper layer path and/or
-# a workdir path that are already used by another overlay mount is not allowed
-# and will fail with EBUSY, so create another workdir for the second overlay
-# mount
+# When overlay inode index feature is enabled, a workdir cannot be reused
+# with a different upperdir. workdir2 in this test is used as the workdir
+# when lowerdir2 is used as the upperdir.
workdir2=$OVL_BASE_SCRATCH_MNT/workdir2
mkdir -p $lowerdir1 $lowerdir2 $upperdir $workdir $workdir2
mkdir -p $lowerdir1/testdir/d
--
2.7.4
next prev parent reply other threads:[~2017-09-19 11:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 11:39 [PATCH 0/2] overlay: fix INDEX=y regressions Amir Goldstein
2017-09-19 11:39 ` Amir Goldstein [this message]
2017-09-19 11:39 ` [PATCH 2/2] overlay/031: fix test with inodes index enabled Amir Goldstein
2017-09-19 13:02 ` zhangyi (F)
2017-09-20 3:53 ` [PATCH 0/2] overlay: fix INDEX=y regressions Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505821184-3913-2-git-send-email-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.