From: Jens Axboe <axboe@kernel.dk> To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Cc: hannes@cmpxchg.org, clm@fb.com, jack@suse.cz, Jens Axboe <axboe@kernel.dk> Subject: [PATCH 5/6] fs-writeback: move nr_pages == 0 logic to one location Date: Tue, 19 Sep 2017 13:53:06 -0600 [thread overview] Message-ID: <1505850787-18311-6-git-send-email-axboe@kernel.dk> (raw) In-Reply-To: <1505850787-18311-1-git-send-email-axboe@kernel.dk> Now that we have no external callers of wb_start_writeback(), we can move the nr_pages == 0 logic into that function. Signed-off-by: Jens Axboe <axboe@kernel.dk> --- fs/fs-writeback.c | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index 7564347914f8..a9a86644cb9f 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c @@ -933,6 +933,17 @@ static void bdi_split_work_to_wbs(struct backing_dev_info *bdi, #endif /* CONFIG_CGROUP_WRITEBACK */ +/* + * Add in the number of potentially dirty inodes, because each inode + * write can dirty pagecache in the underlying blockdev. + */ +static unsigned long get_nr_dirty_pages(void) +{ + return global_node_page_state(NR_FILE_DIRTY) + + global_node_page_state(NR_UNSTABLE_NFS) + + get_nr_dirty_inodes(); +} + static void wb_start_writeback(struct bdi_writeback *wb, long nr_pages, bool range_cyclic, enum wb_reason reason) { @@ -942,6 +953,12 @@ static void wb_start_writeback(struct bdi_writeback *wb, long nr_pages, return; /* + * If someone asked for zero pages, we write out the WORLD + */ + if (!nr_pages) + nr_pages = get_nr_dirty_pages(); + + /* * This is WB_SYNC_NONE writeback, so if allocation fails just * wakeup the thread for old dirty data writeback */ @@ -1814,17 +1831,6 @@ static struct wb_writeback_work *get_next_work_item(struct bdi_writeback *wb) return work; } -/* - * Add in the number of potentially dirty inodes, because each inode - * write can dirty pagecache in the underlying blockdev. - */ -static unsigned long get_nr_dirty_pages(void) -{ - return global_node_page_state(NR_FILE_DIRTY) + - global_node_page_state(NR_UNSTABLE_NFS) + - get_nr_dirty_inodes(); -} - static long wb_check_background_flush(struct bdi_writeback *wb) { if (wb_over_bg_thresh(wb)) { @@ -1966,9 +1972,6 @@ static void __wakeup_flusher_threads_bdi(struct backing_dev_info *bdi, void wakeup_flusher_threads_bdi(struct backing_dev_info *bdi, long nr_pages, enum wb_reason reason) { - if (!nr_pages) - nr_pages = get_nr_dirty_pages(); - rcu_read_lock(); __wakeup_flusher_threads_bdi(bdi, nr_pages, reason); rcu_read_unlock(); @@ -1988,9 +1991,6 @@ void wakeup_flusher_threads(long nr_pages, enum wb_reason reason) if (blk_needs_flush_plug(current)) blk_schedule_flush_plug(current); - if (!nr_pages) - nr_pages = get_nr_dirty_pages(); - rcu_read_lock(); list_for_each_entry_rcu(bdi, &bdi_list, bdi_list) __wakeup_flusher_threads_bdi(bdi, nr_pages, reason); -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk> To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Cc: hannes@cmpxchg.org, clm@fb.com, jack@suse.cz, Jens Axboe <axboe@kernel.dk> Subject: [PATCH 5/6] fs-writeback: move nr_pages == 0 logic to one location Date: Tue, 19 Sep 2017 13:53:06 -0600 [thread overview] Message-ID: <1505850787-18311-6-git-send-email-axboe@kernel.dk> (raw) In-Reply-To: <1505850787-18311-1-git-send-email-axboe@kernel.dk> Now that we have no external callers of wb_start_writeback(), we can move the nr_pages == 0 logic into that function. Signed-off-by: Jens Axboe <axboe@kernel.dk> --- fs/fs-writeback.c | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index 7564347914f8..a9a86644cb9f 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c @@ -933,6 +933,17 @@ static void bdi_split_work_to_wbs(struct backing_dev_info *bdi, #endif /* CONFIG_CGROUP_WRITEBACK */ +/* + * Add in the number of potentially dirty inodes, because each inode + * write can dirty pagecache in the underlying blockdev. + */ +static unsigned long get_nr_dirty_pages(void) +{ + return global_node_page_state(NR_FILE_DIRTY) + + global_node_page_state(NR_UNSTABLE_NFS) + + get_nr_dirty_inodes(); +} + static void wb_start_writeback(struct bdi_writeback *wb, long nr_pages, bool range_cyclic, enum wb_reason reason) { @@ -942,6 +953,12 @@ static void wb_start_writeback(struct bdi_writeback *wb, long nr_pages, return; /* + * If someone asked for zero pages, we write out the WORLD + */ + if (!nr_pages) + nr_pages = get_nr_dirty_pages(); + + /* * This is WB_SYNC_NONE writeback, so if allocation fails just * wakeup the thread for old dirty data writeback */ @@ -1814,17 +1831,6 @@ static struct wb_writeback_work *get_next_work_item(struct bdi_writeback *wb) return work; } -/* - * Add in the number of potentially dirty inodes, because each inode - * write can dirty pagecache in the underlying blockdev. - */ -static unsigned long get_nr_dirty_pages(void) -{ - return global_node_page_state(NR_FILE_DIRTY) + - global_node_page_state(NR_UNSTABLE_NFS) + - get_nr_dirty_inodes(); -} - static long wb_check_background_flush(struct bdi_writeback *wb) { if (wb_over_bg_thresh(wb)) { @@ -1966,9 +1972,6 @@ static void __wakeup_flusher_threads_bdi(struct backing_dev_info *bdi, void wakeup_flusher_threads_bdi(struct backing_dev_info *bdi, long nr_pages, enum wb_reason reason) { - if (!nr_pages) - nr_pages = get_nr_dirty_pages(); - rcu_read_lock(); __wakeup_flusher_threads_bdi(bdi, nr_pages, reason); rcu_read_unlock(); @@ -1988,9 +1991,6 @@ void wakeup_flusher_threads(long nr_pages, enum wb_reason reason) if (blk_needs_flush_plug(current)) blk_schedule_flush_plug(current); - if (!nr_pages) - nr_pages = get_nr_dirty_pages(); - rcu_read_lock(); list_for_each_entry_rcu(bdi, &bdi_list, bdi_list) __wakeup_flusher_threads_bdi(bdi, nr_pages, reason); -- 2.7.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-09-19 19:53 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-09-19 19:53 [PATCH 0/6] More graceful flusher thread memory reclaim wakeup Jens Axboe 2017-09-19 19:53 ` Jens Axboe 2017-09-19 19:53 ` [PATCH 1/6] buffer: cleanup free_more_memory() flusher wakeup Jens Axboe 2017-09-19 19:53 ` Jens Axboe 2017-09-19 20:05 ` Johannes Weiner 2017-09-19 20:05 ` Johannes Weiner 2017-09-20 14:17 ` Jan Kara 2017-09-20 14:17 ` Jan Kara 2017-09-20 15:18 ` Jens Axboe 2017-09-20 15:18 ` Jens Axboe 2017-09-19 19:53 ` [PATCH 2/6] fs-writeback: provide a wakeup_flusher_threads_bdi() Jens Axboe 2017-09-19 19:53 ` Jens Axboe 2017-09-19 20:05 ` Johannes Weiner 2017-09-19 20:05 ` Johannes Weiner 2017-09-20 14:19 ` Jan Kara 2017-09-20 14:19 ` Jan Kara 2017-09-19 19:53 ` [PATCH 3/6] page-writeback: pass in '0' for nr_pages writeback in laptop mode Jens Axboe 2017-09-19 19:53 ` Jens Axboe 2017-09-19 20:06 ` Johannes Weiner 2017-09-19 20:06 ` Johannes Weiner 2017-09-20 14:35 ` Jan Kara 2017-09-20 14:35 ` Jan Kara 2017-09-20 15:19 ` Jens Axboe 2017-09-20 15:19 ` Jens Axboe 2017-09-19 19:53 ` [PATCH 4/6] fs-writeback: make wb_start_writeback() static Jens Axboe 2017-09-19 19:53 ` Jens Axboe 2017-09-19 20:07 ` Johannes Weiner 2017-09-19 20:07 ` Johannes Weiner 2017-09-20 14:35 ` Jan Kara 2017-09-20 14:35 ` Jan Kara 2017-09-19 19:53 ` Jens Axboe [this message] 2017-09-19 19:53 ` [PATCH 5/6] fs-writeback: move nr_pages == 0 logic to one location Jens Axboe 2017-09-19 20:07 ` Johannes Weiner 2017-09-19 20:07 ` Johannes Weiner 2017-09-20 14:41 ` Jan Kara 2017-09-20 14:41 ` Jan Kara 2017-09-20 15:05 ` Jens Axboe 2017-09-20 15:05 ` Jens Axboe 2017-09-20 15:36 ` Jan Kara 2017-09-20 15:36 ` Jan Kara 2017-09-20 15:40 ` Jens Axboe 2017-09-20 15:40 ` Jens Axboe 2017-09-19 19:53 ` [PATCH 6/6] fs-writeback: only allow one inflight and pending !nr_pages flush Jens Axboe 2017-09-19 19:53 ` Jens Axboe 2017-09-19 20:18 ` Johannes Weiner 2017-09-19 20:18 ` Johannes Weiner 2017-09-19 20:39 ` Jens Axboe 2017-09-19 20:39 ` Jens Axboe 2017-09-20 1:57 ` Jens Axboe 2017-09-20 1:57 ` Jens Axboe 2017-09-20 3:10 ` Amir Goldstein 2017-09-20 3:10 ` Amir Goldstein 2017-09-20 4:13 ` Jens Axboe 2017-09-20 4:13 ` Jens Axboe 2017-09-20 6:05 ` Amir Goldstein 2017-09-20 6:05 ` Amir Goldstein 2017-09-20 12:35 ` Jens Axboe 2017-09-20 12:35 ` Jens Axboe 2017-09-20 14:43 ` Jan Kara 2017-09-20 14:43 ` Jan Kara 2017-09-20 19:29 ` [PATCH 0/6] More graceful flusher thread memory reclaim wakeup John Stoffel 2017-09-20 19:29 ` John Stoffel 2017-09-20 19:32 ` Jens Axboe 2017-09-20 19:32 ` Jens Axboe 2017-09-20 23:11 ` Johannes Weiner 2017-09-20 23:11 ` Johannes Weiner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1505850787-18311-6-git-send-email-axboe@kernel.dk \ --to=axboe@kernel.dk \ --cc=clm@fb.com \ --cc=hannes@cmpxchg.org \ --cc=jack@suse.cz \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.