From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: linux-kbuild@vger.kernel.org
Cc: Douglas Anderson <dianders@chromium.org>,
Sam Ravnborg <sam@ravnborg.org>,
linux-kernel@vger.kernel.org,
Masahiro Yamada <yamada.masahiro@socionext.com>
Subject: [PATCH 2/4] kbuild: move "_all" target out of $(KBUILD_SRC) conditional
Date: Wed, 4 Oct 2017 12:56:05 +0900 [thread overview]
Message-ID: <1507089367-10402-2-git-send-email-yamada.masahiro@socionext.com> (raw)
In-Reply-To: <1507089367-10402-1-git-send-email-yamada.masahiro@socionext.com>
The first "_all" occurrence around line 120 is only visible when
KBUILD_SRC is unset.
If O=... is specified, the working directory is relocated, then the
only second occurrence around line 193 is visible, that is not set
to PHONY.
Move the first one to an always visible place. This clarifies "_all"
is our default target and it is always set to PHONY.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
Makefile | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Makefile b/Makefile
index 8d900ba..39a7c03 100644
--- a/Makefile
+++ b/Makefile
@@ -10,6 +10,10 @@ NAME = Fearless Coyote
# Comments in this file are targeted only to the developer, do not
# expect to learn how to build the kernel reading this file.
+# That's our default target when none is given on the command line
+PHONY := _all
+_all:
+
# o Do not use make's built-in rules and variables
# (this increases performance and avoids hard-to-debug behaviour);
# o Look for make include files relative to root of kernel src
@@ -116,10 +120,6 @@ ifeq ("$(origin O)", "command line")
KBUILD_OUTPUT := $(O)
endif
-# That's our default target when none is given on the command line
-PHONY := _all
-_all:
-
# Cancel implicit rules on top Makefile
$(CURDIR)/Makefile Makefile: ;
--
2.7.4
next prev parent reply other threads:[~2017-10-04 3:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 3:56 [PATCH 1/4] kbuild: replace $(hdr-arch) with $(SRCARCH) Masahiro Yamada
2017-10-04 3:56 ` Masahiro Yamada [this message]
2017-10-09 22:02 ` [PATCH 2/4] kbuild: move "_all" target out of $(KBUILD_SRC) conditional Doug Anderson
2017-10-10 11:53 ` Masahiro Yamada
2017-10-04 3:56 ` [PATCH 3/4] kbuild: re-order the code to not parse unnecessary variables Masahiro Yamada
2017-10-09 22:03 ` Doug Anderson
2017-10-10 0:08 ` Masahiro Yamada
2017-10-12 0:59 ` Masahiro Yamada
2017-10-04 3:56 ` [RFC PATCH 4/4] kbuild: evaluate cc-option and friends only when building kernel Masahiro Yamada
2017-10-09 22:04 ` Doug Anderson
2017-10-10 0:23 ` Masahiro Yamada
2017-10-10 0:27 ` Doug Anderson
2017-10-09 22:02 ` [PATCH 1/4] kbuild: replace $(hdr-arch) with $(SRCARCH) Doug Anderson
2017-10-10 11:51 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507089367-10402-2-git-send-email-yamada.masahiro@socionext.com \
--to=yamada.masahiro@socionext.com \
--cc=dianders@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.