All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: linux-sh@vger.kernel.org
Cc: linux-kbuild@vger.kernel.org,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] sh: remove pointless select of KBUILD_DEFCONFIG
Date: Wed, 04 Oct 2017 09:33:55 +0000	[thread overview]
Message-ID: <1507109635-28977-1-git-send-email-yamada.masahiro@socionext.com> (raw)

KBUILD_DEFCONFIG := shx3_defconfig

is never used in a sensible way.  KBUILD_DEFCONFIG specifies the
defconfig file used by "make defconfig", but CONFIG_SUPERH32 is
never set when building config targets.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 arch/sh/Makefile | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/sh/Makefile b/arch/sh/Makefile
index 280bbff..c937ec0 100644
--- a/arch/sh/Makefile
+++ b/arch/sh/Makefile
@@ -96,6 +96,7 @@ defaultimage-$(CONFIG_SH_7619_SOLUTION_ENGINE)	:= vmlinux
 # Set some sensible Kbuild defaults
 boot := arch/sh/boot
 KBUILD_IMAGE		:= $(boot)/$(defaultimage-y)
+KBUILD_DEFCONFIG	:= cayman_defconfig
 
 #
 # Choosing incompatible machines durings configuration will result in
@@ -105,14 +106,12 @@ ifdef CONFIG_SUPERH32
 UTS_MACHINE		:= sh
 BITS			:= 32
 LDFLAGS_vmlinux		+= -e _stext
-KBUILD_DEFCONFIG	:= shx3_defconfig
 else
 UTS_MACHINE		:= sh64
 BITS			:= 64
 LDFLAGS_vmlinux		+= --defsym phys_stext=_stext-$(CONFIG_PAGE_OFFSET) \
 			   --defsym phys_stext_shmedia=phys_stext+1 \
 			   -e phys_stext_shmedia
-KBUILD_DEFCONFIG	:= cayman_defconfig
 endif
 
 ifdef CONFIG_CPU_LITTLE_ENDIAN
-- 
2.7.4


WARNING: multiple messages have this Message-ID (diff)
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: linux-sh@vger.kernel.org
Cc: linux-kbuild@vger.kernel.org,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] sh: remove pointless select of KBUILD_DEFCONFIG
Date: Wed,  4 Oct 2017 18:33:55 +0900	[thread overview]
Message-ID: <1507109635-28977-1-git-send-email-yamada.masahiro@socionext.com> (raw)

KBUILD_DEFCONFIG := shx3_defconfig

is never used in a sensible way.  KBUILD_DEFCONFIG specifies the
defconfig file used by "make defconfig", but CONFIG_SUPERH32 is
never set when building config targets.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 arch/sh/Makefile | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/sh/Makefile b/arch/sh/Makefile
index 280bbff..c937ec0 100644
--- a/arch/sh/Makefile
+++ b/arch/sh/Makefile
@@ -96,6 +96,7 @@ defaultimage-$(CONFIG_SH_7619_SOLUTION_ENGINE)	:= vmlinux
 # Set some sensible Kbuild defaults
 boot := arch/sh/boot
 KBUILD_IMAGE		:= $(boot)/$(defaultimage-y)
+KBUILD_DEFCONFIG	:= cayman_defconfig
 
 #
 # Choosing incompatible machines durings configuration will result in
@@ -105,14 +106,12 @@ ifdef CONFIG_SUPERH32
 UTS_MACHINE		:= sh
 BITS			:= 32
 LDFLAGS_vmlinux		+= -e _stext
-KBUILD_DEFCONFIG	:= shx3_defconfig
 else
 UTS_MACHINE		:= sh64
 BITS			:= 64
 LDFLAGS_vmlinux		+= --defsym phys_stext=_stext-$(CONFIG_PAGE_OFFSET) \
 			   --defsym phys_stext_shmedia=phys_stext+1 \
 			   -e phys_stext_shmedia
-KBUILD_DEFCONFIG	:= cayman_defconfig
 endif
 
 ifdef CONFIG_CPU_LITTLE_ENDIAN
-- 
2.7.4

             reply	other threads:[~2017-10-04  9:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-04  9:33 Masahiro Yamada [this message]
2017-10-04  9:33 ` [PATCH] sh: remove pointless select of KBUILD_DEFCONFIG Masahiro Yamada
2017-11-02  3:09 ` Masahiro Yamada
2017-11-02  3:09   ` Masahiro Yamada
2017-11-02  9:18 ` Geert Uytterhoeven
2017-11-02  9:18   ` Geert Uytterhoeven
2017-11-02  9:26   ` Masahiro Yamada
2017-11-02  9:26     ` Masahiro Yamada
2017-11-02  9:45     ` Masahiro Yamada
2017-11-02  9:45       ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1507109635-28977-1-git-send-email-yamada.masahiro@socionext.com \
    --to=yamada.masahiro@socionext.com \
    --cc=dalias@libc.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.