From: Christos Gkekas <chris.gekas@gmail.com> To: Kalle Valo <kvalo@qca.qualcomm.com>, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Christos Gkekas <chris.gekas@gmail.com> Subject: [PATCH] ath10k: spectral: Simplify error checking Date: Sun, 8 Oct 2017 20:30:26 +0100 [thread overview] Message-ID: <1507491026-28690-1-git-send-email-chris.gekas@gmail.com> (raw) Variable val is unsigned so checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas <chris.gekas@gmail.com> --- drivers/net/wireless/ath/ath10k/spectral.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/spectral.c b/drivers/net/wireless/ath/ath10k/spectral.c index dd9cc09..1867937 100644 --- a/drivers/net/wireless/ath/ath10k/spectral.c +++ b/drivers/net/wireless/ath/ath10k/spectral.c @@ -403,10 +403,7 @@ static ssize_t write_file_spectral_count(struct file *file, return -EFAULT; buf[len] = '\0'; - if (kstrtoul(buf, 0, &val)) - return -EINVAL; - - if (val < 0 || val > 255) + if (kstrtoul(buf, 0, &val) || val > 255) return -EINVAL; mutex_lock(&ar->conf_mutex); -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Christos Gkekas <chris.gekas@gmail.com> To: Kalle Valo <kvalo@qca.qualcomm.com>, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Christos Gkekas <chris.gekas@gmail.com> Subject: [PATCH] ath10k: spectral: Simplify error checking Date: Sun, 8 Oct 2017 20:30:26 +0100 [thread overview] Message-ID: <1507491026-28690-1-git-send-email-chris.gekas@gmail.com> (raw) Variable val is unsigned so checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas <chris.gekas@gmail.com> --- drivers/net/wireless/ath/ath10k/spectral.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/spectral.c b/drivers/net/wireless/ath/ath10k/spectral.c index dd9cc09..1867937 100644 --- a/drivers/net/wireless/ath/ath10k/spectral.c +++ b/drivers/net/wireless/ath/ath10k/spectral.c @@ -403,10 +403,7 @@ static ssize_t write_file_spectral_count(struct file *file, return -EFAULT; buf[len] = '\0'; - if (kstrtoul(buf, 0, &val)) - return -EINVAL; - - if (val < 0 || val > 255) + if (kstrtoul(buf, 0, &val) || val > 255) return -EINVAL; mutex_lock(&ar->conf_mutex); -- 2.7.4 _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next reply other threads:[~2017-10-08 19:30 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-10-08 19:30 Christos Gkekas [this message] 2017-10-08 19:30 ` [PATCH] ath10k: spectral: Simplify error checking Christos Gkekas 2017-10-13 12:28 ` Kalle Valo 2017-10-13 12:28 ` Kalle Valo 2017-10-13 12:28 ` Kalle Valo 2017-10-14 8:12 ` Christos Gkekas 2017-10-14 8:12 ` Christos Gkekas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1507491026-28690-1-git-send-email-chris.gekas@gmail.com \ --to=chris.gekas@gmail.com \ --cc=ath10k@lists.infradead.org \ --cc=kvalo@qca.qualcomm.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.