All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: linux-kbuild@vger.kernel.org
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
	Mark Salter <msalter@redhat.com>,
	linux-c6x-dev@linux-c6x.org,
	Aurelien Jacquiot <jacquiot.aurelien@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] c6x: add KBUILD_ prefix to CFLAGS_MODULE
Date: Mon,  9 Oct 2017 23:35:15 +0900	[thread overview]
Message-ID: <1507559715-30918-4-git-send-email-yamada.masahiro@socionext.com> (raw)
In-Reply-To: <1507559715-30918-1-git-send-email-yamada.masahiro@socionext.com>

CFLAGS_MODULE is supposed to be set by users, not by in-kernel
makefiles.

Documentation/kbuild/makefiles.txt clearly explains the difference:

  KBUILD_CFLAGS_MODULE   Options for $(CC) when building modules

      $(KBUILD_CFLAGS_MODULE) is used to add arch-specific options that
      are used for $(CC).
      From commandline CFLAGS_MODULE shall be used (see kbuild.txt).

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 arch/c6x/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/c6x/Makefile b/arch/c6x/Makefile
index 6b0be67..6f6096f 100644
--- a/arch/c6x/Makefile
+++ b/arch/c6x/Makefile
@@ -12,7 +12,7 @@ cflags-y += -mno-dsbt -msdata=none -D__linux__
 
 cflags-$(CONFIG_C6X_BIG_KERNEL) += -mlong-calls
 
-CFLAGS_MODULE   += -mlong-calls -mno-dsbt -msdata=none
+KBUILD_CFLAGS_MODULE   += -mlong-calls -mno-dsbt -msdata=none
 
 CHECKFLAGS      +=
 
-- 
2.7.4

  parent reply	other threads:[~2017-10-09 14:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-09 14:35 [PATCH 0/3] ARM, hexagon, c6x: build: fix usage of CFLAGS_MODULE, LDFLAGS_MODULE Masahiro Yamada
2017-10-09 14:35 ` Masahiro Yamada
2017-10-09 14:35 ` Masahiro Yamada
2017-10-09 14:35 ` [PATCH 1/3] ARM: add KBUILD_ prefix to " Masahiro Yamada
2017-10-09 14:35   ` Masahiro Yamada
2017-10-09 15:06   ` Russell King - ARM Linux
2017-10-09 15:06     ` Russell King - ARM Linux
2017-10-09 14:35 ` [PATCH 2/3] hexagon: " Masahiro Yamada
2017-10-09 14:35 ` Masahiro Yamada [this message]
2017-10-15  7:47 ` [PATCH 0/3] ARM, hexagon, c6x: build: fix usage of " Masahiro Yamada
2017-10-15  7:47   ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1507559715-30918-4-git-send-email-yamada.masahiro@socionext.com \
    --to=yamada.masahiro@socionext.com \
    --cc=jacquiot.aurelien@gmail.com \
    --cc=linux-c6x-dev@linux-c6x.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=msalter@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.