From: Sagar Arun Kamble <sagar.a.kamble@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 09/11] drm/i915/guc: Fix GuC interrupts disabling with Logging
Date: Wed, 18 Oct 2017 12:17:00 +0530 [thread overview]
Message-ID: <1508309222-26406-10-git-send-email-sagar.a.kamble@intel.com> (raw)
In-Reply-To: <1508309222-26406-1-git-send-email-sagar.a.kamble@intel.com>
With guc_log_unregister disabling runtime logging and interrupts there
is no need to disable interrupts during uc_fini_hw hence it is removed.
With GuC CT buffer mechanism, interrupt disabling can be added at a point
where CT mechanism ceases.
Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
drivers/gpu/drm/i915/intel_uc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
index d96c847..9715eda 100644
--- a/drivers/gpu/drm/i915/intel_uc.c
+++ b/drivers/gpu/drm/i915/intel_uc.c
@@ -287,9 +287,6 @@ void intel_uc_fini_hw(struct drm_i915_private *dev_priv)
guc_disable_communication(&dev_priv->guc);
- if (i915_modparams.guc_log_level >= 0)
- intel_put_guc_interrupts(&dev_priv->guc, GUC_INTR_CLIENT_LOG);
-
if (i915_modparams.enable_guc_submission)
i915_guc_submission_fini(dev_priv);
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-18 6:43 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 6:46 [PATCH 00/11] GuC Interrupts/Log updates Sagar Arun Kamble
2017-10-18 6:46 ` [PATCH 01/11] drm/i915: Export low level PM IRQ functions to control from GuC functions Sagar Arun Kamble
2017-10-18 12:42 ` Tvrtko Ursulin
2017-10-18 13:48 ` Sagar Arun Kamble
2017-10-18 6:46 ` [PATCH 02/11] drm/i915/guc: Move GuC interrupts related functions from i915_irq.c to intel_guc.c Sagar Arun Kamble
2017-10-18 12:46 ` Tvrtko Ursulin
2017-10-18 14:06 ` Sagar Arun Kamble
2017-10-18 6:46 ` [PATCH 03/11] drm/i915/guc: Pass intel_guc struct parameter to GuC interrupts functions Sagar Arun Kamble
2017-10-18 12:47 ` Tvrtko Ursulin
2017-10-18 6:46 ` [PATCH 04/11] drm/i915/guc: Sanitize module parameter guc_log_level Sagar Arun Kamble
2017-10-18 12:59 ` Tvrtko Ursulin
2017-10-18 15:50 ` Sagar Arun Kamble
2017-10-19 7:22 ` Tvrtko Ursulin
2017-10-21 8:11 ` Sagar Arun Kamble
2017-10-18 6:46 ` [PATCH 05/11] drm/i915/guc: Make GuC log related functions depend only on log level Sagar Arun Kamble
2017-10-18 13:07 ` Tvrtko Ursulin
2017-10-18 15:57 ` Sagar Arun Kamble
2017-10-18 6:46 ` [PATCH 06/11] drm/i915/guc: Only release GuC log object during submission_fini Sagar Arun Kamble
2017-10-18 13:12 ` Tvrtko Ursulin
2017-10-18 16:04 ` Sagar Arun Kamble
2017-10-19 7:18 ` Tvrtko Ursulin
2017-10-21 8:09 ` Sagar Arun Kamble
2017-10-18 6:46 ` [PATCH 07/11] drm/i915/guc: Grab RPM wakelock while disabling GuC interrupts Sagar Arun Kamble
2017-10-19 10:09 ` Tvrtko Ursulin
2017-10-21 13:27 ` Sagar Arun Kamble
2017-10-18 6:46 ` [PATCH 08/11] drm/i915/guc: Add client support to enable/disable " Sagar Arun Kamble
2017-10-19 10:19 ` Tvrtko Ursulin
2017-10-21 16:38 ` Sagar Arun Kamble
2017-10-18 6:47 ` Sagar Arun Kamble [this message]
2017-10-19 10:24 ` [PATCH 09/11] drm/i915/guc: Fix GuC interrupts disabling with Logging Tvrtko Ursulin
2017-10-21 16:39 ` Sagar Arun Kamble
2017-10-18 6:47 ` [PATCH 10/11] drm/i915/guc: Skip interrupt enabling if logging is already enabled Sagar Arun Kamble
2017-10-19 10:31 ` Tvrtko Ursulin
2017-10-21 16:47 ` Sagar Arun Kamble
2017-10-18 6:47 ` [PATCH 11/11] drm/i915/guc: Restore GuC interrupts across suspend/reset if enabled Sagar Arun Kamble
2017-10-19 11:03 ` Tvrtko Ursulin
2017-10-21 17:09 ` Sagar Arun Kamble
2017-10-18 7:02 ` ✓ Fi.CI.BAT: success for GuC Interrupts/Log updates Patchwork
2017-10-18 13:41 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508309222-26406-10-git-send-email-sagar.a.kamble@intel.com \
--to=sagar.a.kamble@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.