From: Masahiro Yamada <yamada.masahiro@socionext.com> To: cocci@systeme.lip6.fr, linux-kbuild@vger.kernel.org, Julia Lawall <Julia.Lawall@lip6.fr> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>, Nicolas Palix <nicolas.palix@imag.fr>, linux-kernel@vger.kernel.org, Gilles Muller <Gilles.Muller@lip6.fr>, Michal Marek <michal.lkml@markovi.net> Subject: [RFC PATCH] coccinelle: fix parallel build with CHECK=scripts/coccicheck Date: Thu, 26 Oct 2017 13:56:46 +0900 [thread overview] Message-ID: <1508993806-17320-1-git-send-email-yamada.masahiro@socionext.com> (raw) If I run the following: $ make -j8 C=1 CHECK=scripts/coccicheck lots of "coccicheck failed" messages are displayed. I do not know the coccinell internals, but I guess --jobs does not work well if spatch is invoked from Make running in parallel. Disable --jobs in this case. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- scripts/coccicheck | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scripts/coccicheck b/scripts/coccicheck index 9d18662..b74c789 100755 --- a/scripts/coccicheck +++ b/scripts/coccicheck @@ -69,6 +69,9 @@ if [ "$C" = "1" -o "$C" = "2" ]; then # Take only the last argument, which is the C file to test shift $(( $# - 1 )) OPTIONS="$COCCIINCLUDE $1" + + # --jobs does not work if Make is running in parallel + echo $MAKEFLAGS | grep "\-\-jobserver-auth" && USE_JOBS="no" else ONLINE=0 if [ "$KBUILD_EXTMOD" = "" ] ; then -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: yamada.masahiro@socionext.com (Masahiro Yamada) To: cocci@systeme.lip6.fr Subject: [Cocci] [RFC PATCH] coccinelle: fix parallel build with CHECK=scripts/coccicheck Date: Thu, 26 Oct 2017 13:56:46 +0900 [thread overview] Message-ID: <1508993806-17320-1-git-send-email-yamada.masahiro@socionext.com> (raw) If I run the following: $ make -j8 C=1 CHECK=scripts/coccicheck lots of "coccicheck failed" messages are displayed. I do not know the coccinell internals, but I guess --jobs does not work well if spatch is invoked from Make running in parallel. Disable --jobs in this case. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- scripts/coccicheck | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scripts/coccicheck b/scripts/coccicheck index 9d18662..b74c789 100755 --- a/scripts/coccicheck +++ b/scripts/coccicheck @@ -69,6 +69,9 @@ if [ "$C" = "1" -o "$C" = "2" ]; then # Take only the last argument, which is the C file to test shift $(( $# - 1 )) OPTIONS="$COCCIINCLUDE $1" + + # --jobs does not work if Make is running in parallel + echo $MAKEFLAGS | grep "\-\-jobserver-auth" && USE_JOBS="no" else ONLINE=0 if [ "$KBUILD_EXTMOD" = "" ] ; then -- 2.7.4
next reply other threads:[~2017-10-26 4:58 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-10-26 4:56 Masahiro Yamada [this message] 2017-10-26 4:56 ` [Cocci] [RFC PATCH] coccinelle: fix parallel build with CHECK=scripts/coccicheck Masahiro Yamada
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1508993806-17320-1-git-send-email-yamada.masahiro@socionext.com \ --to=yamada.masahiro@socionext.com \ --cc=Gilles.Muller@lip6.fr \ --cc=Julia.Lawall@lip6.fr \ --cc=cocci@systeme.lip6.fr \ --cc=linux-kbuild@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=michal.lkml@markovi.net \ --cc=nicolas.palix@imag.fr \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.