From: "Javier González" <jg@lightnvm.io> To: hch@lst.de, sagi@grimberg.me, keith.busch@intel.com Cc: linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, "Javier González" <javier@cnexlabs.com> Subject: [PATCH 1/3] nvme: do not check for ns on rw path Date: Fri, 3 Nov 2017 11:02:48 +0100 [thread overview] Message-ID: <1509703370-20379-2-git-send-email-javier@cnexlabs.com> (raw) In-Reply-To: <1509703370-20379-1-git-send-email-javier@cnexlabs.com> On the rw path, the ns is assumed to be set. However, a check is still done, inherited from the time the code resided at nvme_queue_rq(). Eliminate this check, which also eliminates a smatch complain for not doing proper NULL checks on ns. Signed-off-by: Javier González <javier@cnexlabs.com> --- drivers/nvme/host/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 5a14cc7f28ee..bd1d5ff911c9 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -472,7 +472,7 @@ static inline blk_status_t nvme_setup_rw(struct nvme_ns *ns, * unless this namespace is formated such that the metadata can be * stripped/generated by the controller with PRACT=1. */ - if (ns && ns->ms && + if (ns->ms && (!ns->pi_type || ns->ms != sizeof(struct t10_pi_tuple)) && !blk_integrity_rq(req) && !blk_rq_is_passthrough(req)) return BLK_STS_NOTSUPP; -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: jg@lightnvm.io (Javier González) Subject: [PATCH 1/3] nvme: do not check for ns on rw path Date: Fri, 3 Nov 2017 11:02:48 +0100 [thread overview] Message-ID: <1509703370-20379-2-git-send-email-javier@cnexlabs.com> (raw) In-Reply-To: <1509703370-20379-1-git-send-email-javier@cnexlabs.com> On the rw path, the ns is assumed to be set. However, a check is still done, inherited from the time the code resided at nvme_queue_rq(). Eliminate this check, which also eliminates a smatch complain for not doing proper NULL checks on ns. Signed-off-by: Javier Gonz?lez <javier at cnexlabs.com> --- drivers/nvme/host/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 5a14cc7f28ee..bd1d5ff911c9 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -472,7 +472,7 @@ static inline blk_status_t nvme_setup_rw(struct nvme_ns *ns, * unless this namespace is formated such that the metadata can be * stripped/generated by the controller with PRACT=1. */ - if (ns && ns->ms && + if (ns->ms && (!ns->pi_type || ns->ms != sizeof(struct t10_pi_tuple)) && !blk_integrity_rq(req) && !blk_rq_is_passthrough(req)) return BLK_STS_NOTSUPP; -- 2.7.4
next prev parent reply other threads:[~2017-11-03 10:02 UTC|newest] Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-03 10:02 [PATCH 0/3] nvme: small fixes reported by smatch Javier González 2017-11-03 10:02 ` Javier González 2017-11-03 10:02 ` Javier González [this message] 2017-11-03 10:02 ` [PATCH 1/3] nvme: do not check for ns on rw path Javier González 2017-11-03 12:53 ` Christoph Hellwig 2017-11-03 12:53 ` Christoph Hellwig 2017-11-03 13:00 ` Javier González 2017-11-03 13:00 ` Javier González 2017-11-03 15:02 ` Keith Busch 2017-11-03 15:02 ` Keith Busch 2017-11-04 8:18 ` Christoph Hellwig 2017-11-04 8:18 ` Christoph Hellwig 2017-11-04 15:38 ` Keith Busch 2017-11-04 15:38 ` Keith Busch 2017-11-06 9:13 ` Christoph Hellwig 2017-11-06 9:13 ` Christoph Hellwig 2017-11-06 9:13 ` Christoph Hellwig 2017-11-06 14:43 ` Keith Busch 2017-11-06 14:43 ` Keith Busch 2017-11-03 10:02 ` [PATCH 2/3] nvme: compare NQN string with right size Javier González 2017-11-03 10:02 ` Javier González 2017-11-03 12:54 ` Christoph Hellwig 2017-11-03 12:54 ` Christoph Hellwig 2017-11-03 12:54 ` Christoph Hellwig 2017-11-03 12:56 ` Javier González 2017-11-03 12:56 ` Javier González 2017-11-03 10:02 ` [PATCH 3/3] nvme: fix eui_show() print format Javier González 2017-11-03 10:02 ` Javier González 2017-11-03 12:55 ` Christoph Hellwig 2017-11-03 12:55 ` Christoph Hellwig 2017-11-03 12:55 ` Christoph Hellwig 2017-11-03 15:13 ` Keith Busch 2017-11-03 15:13 ` Keith Busch 2017-11-03 15:13 ` Keith Busch 2017-11-03 15:16 ` Joe Perches 2017-11-03 15:16 ` Joe Perches 2017-11-03 15:16 ` Joe Perches 2017-11-04 11:22 ` Javier González 2017-11-04 11:22 ` Javier González 2017-11-07 16:28 ` Christoph Hellwig 2017-11-07 16:28 ` Christoph Hellwig 2017-11-07 16:28 ` Christoph Hellwig 2017-11-07 16:36 ` Javier González 2017-11-07 16:36 ` Javier González 2017-11-07 16:36 ` Javier González
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1509703370-20379-2-git-send-email-javier@cnexlabs.com \ --to=jg@lightnvm.io \ --cc=hch@lst.de \ --cc=javier@cnexlabs.com \ --cc=keith.busch@intel.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=sagi@grimberg.me \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.