All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arvind Yadav <arvind.yadav.cs@gmail.com>
To: dmitry.torokhov@gmail.com, maxime.ripard@free-electrons.com,
	wens@csie.org, linux@roeck-us.net, wsa@the-dreams.de,
	daniel.thompson@linaro.org, mcuos.com@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/10] Input: sirfsoc-onkey: Handle return value of platform_get_irq
Date: Sat, 18 Nov 2017 00:45:31 +0530	[thread overview]
Message-ID: <1510946132-13554-10-git-send-email-arvind.yadav.cs@gmail.com> (raw)
In-Reply-To: <1510946132-13554-1-git-send-email-arvind.yadav.cs@gmail.com>

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/input/misc/sirfsoc-onkey.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/input/misc/sirfsoc-onkey.c b/drivers/input/misc/sirfsoc-onkey.c
index 4fd038d..de04b48 100644
--- a/drivers/input/misc/sirfsoc-onkey.c
+++ b/drivers/input/misc/sirfsoc-onkey.c
@@ -149,6 +149,9 @@ static int sirfsoc_pwrc_probe(struct platform_device *pdev)
 	sirfsoc_pwrc_toggle_interrupts(pwrcdrv, false);
 
 	irq = platform_get_irq(pdev, 0);
+	if (irq < 0)
+		return irq;
+
 	error = devm_request_irq(&pdev->dev, irq,
 				 sirfsoc_pwrc_isr, 0,
 				 "sirfsoc_pwrc_int", pwrcdrv);
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: arvind.yadav.cs@gmail.com (Arvind Yadav)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/10] Input: sirfsoc-onkey: Handle return value of platform_get_irq
Date: Sat, 18 Nov 2017 00:45:31 +0530	[thread overview]
Message-ID: <1510946132-13554-10-git-send-email-arvind.yadav.cs@gmail.com> (raw)
In-Reply-To: <1510946132-13554-1-git-send-email-arvind.yadav.cs@gmail.com>

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/input/misc/sirfsoc-onkey.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/input/misc/sirfsoc-onkey.c b/drivers/input/misc/sirfsoc-onkey.c
index 4fd038d..de04b48 100644
--- a/drivers/input/misc/sirfsoc-onkey.c
+++ b/drivers/input/misc/sirfsoc-onkey.c
@@ -149,6 +149,9 @@ static int sirfsoc_pwrc_probe(struct platform_device *pdev)
 	sirfsoc_pwrc_toggle_interrupts(pwrcdrv, false);
 
 	irq = platform_get_irq(pdev, 0);
+	if (irq < 0)
+		return irq;
+
 	error = devm_request_irq(&pdev->dev, irq,
 				 sirfsoc_pwrc_isr, 0,
 				 "sirfsoc_pwrc_int", pwrcdrv);
-- 
2.7.4

  parent reply	other threads:[~2017-11-17 19:17 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-17 19:15 [PATCH 00/10] Handle platform_get_irq's error checking and returns Arvind Yadav
2017-11-17 19:15 ` Arvind Yadav
2017-11-17 19:15 ` [PATCH 01/10] Input: ep93xx_keypad: Fix platform_get_irq's error checking Arvind Yadav
2017-11-17 19:15   ` Arvind Yadav
2017-11-17 19:15   ` Arvind Yadav
2017-11-17 19:50   ` Dmitry Torokhov
2017-11-17 19:50     ` Dmitry Torokhov
2017-11-17 19:15 ` [PATCH 02/10] Input: omap4-keypad: " Arvind Yadav
2017-11-17 19:15   ` Arvind Yadav
2017-11-17 20:25   ` Dmitry Torokhov
2017-11-17 20:25     ` Dmitry Torokhov
2017-11-17 20:25     ` Dmitry Torokhov
2017-11-17 19:15 ` [PATCH 03/10] Input: twl4030_keypad: " Arvind Yadav
2017-11-17 19:15   ` Arvind Yadav
2017-11-17 20:27   ` Dmitry Torokhov
2017-11-17 20:27     ` Dmitry Torokhov
2017-11-17 20:27     ` Dmitry Torokhov
2017-11-17 19:15 ` [PATCH 04/10] Input: serio: " Arvind Yadav
2017-11-17 19:15   ` Arvind Yadav
2017-11-17 20:27   ` Dmitry Torokhov
2017-11-17 20:27     ` Dmitry Torokhov
2017-11-17 19:15 ` [PATCH 05/10] Input: cpcap-pwrbutton: Handle return value of platform_get_irq Arvind Yadav
2017-11-17 19:15   ` Arvind Yadav
2017-11-17 19:15 ` [PATCH 06/10] Input: w90p910_ts: " Arvind Yadav
2017-11-17 19:15   ` Arvind Yadav
2017-11-17 19:15 ` [PATCH 07/10] Input: sun4i-ts: " Arvind Yadav
2017-11-17 19:15   ` Arvind Yadav
2017-11-17 19:56   ` Dmitry Torokhov
2017-11-17 19:56     ` Dmitry Torokhov
2017-11-17 19:15 ` [PATCH 08/10] Input: twl4030-pwrbutton: " Arvind Yadav
2017-11-17 19:15   ` Arvind Yadav
2017-11-17 19:56   ` Dmitry Torokhov
2017-11-17 19:56     ` Dmitry Torokhov
2017-11-17 19:15 ` Arvind Yadav [this message]
2017-11-17 19:15   ` [PATCH 09/10] Input: sirfsoc-onkey: " Arvind Yadav
2017-11-17 19:58   ` Dmitry Torokhov
2017-11-17 19:58     ` Dmitry Torokhov
2017-11-17 19:15 ` [PATCH 10/10] Input: palmas-pwrbutton: " Arvind Yadav
2017-11-17 19:15   ` Arvind Yadav
2017-11-18  8:18 ` [PATCH 00/10] Handle platform_get_irq's error checking and returns Russell King - ARM Linux
2017-11-18  8:18   ` Russell King - ARM Linux
2017-11-18  8:18   ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1510946132-13554-10-git-send-email-arvind.yadav.cs@gmail.com \
    --to=arvind.yadav.cs@gmail.com \
    --cc=daniel.thompson@linaro.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=maxime.ripard@free-electrons.com \
    --cc=mcuos.com@gmail.com \
    --cc=wens@csie.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.