All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arvind Yadav <arvind.yadav.cs@gmail.com>
To: ulf.hansson@linaro.org, carlo@caione.org, khilman@baylibre.com,
	ben-linux@fluff.org, adrian.hunter@intel.com, vireshk@kernel.org,
	maxime.ripard@free-electrons.com, wens@csie.org
Cc: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org
Subject: [PATCH 4/6] mmc: sdhci-spear: Handle return value of platform_get_irq
Date: Sat, 18 Nov 2017 01:58:20 +0530	[thread overview]
Message-ID: <1510950502-22565-5-git-send-email-arvind.yadav.cs@gmail.com> (raw)
In-Reply-To: <1510950502-22565-1-git-send-email-arvind.yadav.cs@gmail.com>

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/mmc/host/sdhci-spear.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c
index 8c0f884..900838b 100644
--- a/drivers/mmc/host/sdhci-spear.c
+++ b/drivers/mmc/host/sdhci-spear.c
@@ -82,6 +82,10 @@ static int sdhci_probe(struct platform_device *pdev)
 	host->hw_name = "sdhci";
 	host->ops = &sdhci_pltfm_ops;
 	host->irq = platform_get_irq(pdev, 0);
+	if (host->irq < 0) {
+		ret = host->irq;
+		goto err_host;
+	}
 	host->quirks = SDHCI_QUIRK_BROKEN_ADMA;
 
 	sdhci = sdhci_priv(host);
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: arvind.yadav.cs@gmail.com (Arvind Yadav)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] mmc: sdhci-spear: Handle return value of platform_get_irq
Date: Sat, 18 Nov 2017 01:58:20 +0530	[thread overview]
Message-ID: <1510950502-22565-5-git-send-email-arvind.yadav.cs@gmail.com> (raw)
In-Reply-To: <1510950502-22565-1-git-send-email-arvind.yadav.cs@gmail.com>

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/mmc/host/sdhci-spear.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c
index 8c0f884..900838b 100644
--- a/drivers/mmc/host/sdhci-spear.c
+++ b/drivers/mmc/host/sdhci-spear.c
@@ -82,6 +82,10 @@ static int sdhci_probe(struct platform_device *pdev)
 	host->hw_name = "sdhci";
 	host->ops = &sdhci_pltfm_ops;
 	host->irq = platform_get_irq(pdev, 0);
+	if (host->irq < 0) {
+		ret = host->irq;
+		goto err_host;
+	}
 	host->quirks = SDHCI_QUIRK_BROKEN_ADMA;
 
 	sdhci = sdhci_priv(host);
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: arvind.yadav.cs@gmail.com (Arvind Yadav)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 4/6] mmc: sdhci-spear: Handle return value of platform_get_irq
Date: Sat, 18 Nov 2017 01:58:20 +0530	[thread overview]
Message-ID: <1510950502-22565-5-git-send-email-arvind.yadav.cs@gmail.com> (raw)
In-Reply-To: <1510950502-22565-1-git-send-email-arvind.yadav.cs@gmail.com>

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/mmc/host/sdhci-spear.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c
index 8c0f884..900838b 100644
--- a/drivers/mmc/host/sdhci-spear.c
+++ b/drivers/mmc/host/sdhci-spear.c
@@ -82,6 +82,10 @@ static int sdhci_probe(struct platform_device *pdev)
 	host->hw_name = "sdhci";
 	host->ops = &sdhci_pltfm_ops;
 	host->irq = platform_get_irq(pdev, 0);
+	if (host->irq < 0) {
+		ret = host->irq;
+		goto err_host;
+	}
 	host->quirks = SDHCI_QUIRK_BROKEN_ADMA;
 
 	sdhci = sdhci_priv(host);
-- 
2.7.4

  parent reply	other threads:[~2017-11-17 20:29 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-17 20:28 [PATCH 0/6] mmc: Handle platform_get_irq's error checking and return Arvind Yadav
2017-11-17 20:28 ` Arvind Yadav
2017-11-17 20:28 ` Arvind Yadav
2017-11-17 20:28 ` [PATCH 1/6] mmc: meson-gx-mmc: Fix platform_get_irq's error checking Arvind Yadav
2017-11-17 20:28   ` Arvind Yadav
2017-11-17 20:28   ` Arvind Yadav
2017-12-07  0:55   ` Kevin Hilman
2017-12-07  0:55     ` Kevin Hilman
2017-12-07  0:55     ` Kevin Hilman
2017-11-17 20:28 ` [PATCH 2/6] mmc: s3cmci: " Arvind Yadav
2017-11-17 20:28   ` Arvind Yadav
2017-11-17 20:28   ` Arvind Yadav
2017-11-17 20:28 ` [PATCH 3/6] mmc: sdhci-acpi: Handle return value of platform_get_irq Arvind Yadav
2017-11-17 20:28   ` Arvind Yadav
2017-11-17 20:28   ` Arvind Yadav
2017-11-17 20:28 ` Arvind Yadav [this message]
2017-11-17 20:28   ` [PATCH 4/6] mmc: sdhci-spear: " Arvind Yadav
2017-11-17 20:28   ` Arvind Yadav
2017-11-20  5:43   ` Viresh Kumar
2017-11-20  5:43     ` Viresh Kumar
2017-11-20  5:43     ` Viresh Kumar
2017-11-20  6:43     ` Arvind Yadav
2017-11-20  6:43       ` Arvind Yadav
2017-11-20  6:43       ` Arvind Yadav
2017-11-17 20:28 ` [PATCH 5/6] mmc: sh_mmcif: " Arvind Yadav
2017-11-17 20:28   ` Arvind Yadav
2017-11-17 20:28   ` Arvind Yadav
2017-11-17 20:28 ` [PATCH 6/6] mmc: sunxi-mmc: " Arvind Yadav
2017-11-17 20:28   ` Arvind Yadav
2017-11-17 20:28   ` Arvind Yadav
2017-11-18  8:19 ` [PATCH 0/6] mmc: Handle platform_get_irq's error checking and return Russell King - ARM Linux
2017-11-18  8:19   ` Russell King - ARM Linux
2017-11-18  8:19   ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1510950502-22565-5-git-send-email-arvind.yadav.cs@gmail.com \
    --to=arvind.yadav.cs@gmail.com \
    --cc=adrian.hunter@intel.com \
    --cc=ben-linux@fluff.org \
    --cc=carlo@caione.org \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=maxime.ripard@free-electrons.com \
    --cc=ulf.hansson@linaro.org \
    --cc=vireshk@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.