From: Geert Uytterhoeven <geert+renesas@glider.be> To: "Rafael J . Wysocki" <rjw@rjwysocki.net>, Kevin Hilman <khilman@kernel.org>, Ulf Hansson <ulf.hansson@linaro.org>, Kukjin Kim <kgene@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org> Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven <geert+renesas@glider.be> Subject: [PATCH v2] PM / Domains: Remove obsolete "samsung,power-domain" check Date: Thu, 30 Nov 2017 12:54:28 +0100 [thread overview] Message-ID: <1512042868-23017-1-git-send-email-geert+renesas@glider.be> (raw) Currently the generic PM Domain code code checks for the presence of both (generic) "power-domains" and (Samsung Exynos legacy) "samsung,power-domain" properties in all device tree nodes representing devices. There are two issues with this: 1. This imposes a small boot-time penalty on all platforms using DT, 2. Platform-specific checks do not really belong in core framework code. Remove the platform-specific check, as the last user of "samsung,power-domain" was removed in commit 46dcf0ff0de35da8 ("ARM: dts: exynos: Remove exynos4415.dtsi"). All other users were converted before in commit 0da6587041363033 ("ARM: dts: convert to generic power domain bindings for exynos DT"). Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- This is v2 of 'PM / Domains: Restrict "samsung,power-domain" checks to ARCH_EXYNOS'. "samsung,power-domain" was only ever used in: - arch/arm/boot/dts/exynos4415.dtsi: Removed - arch/arm/boot/dts/exynos3250.dtsi: CONFIG_ARCH_EXYNOS3 - arch/arm/boot/dts/exynos4.dtsi: CONFIG_ARCH_EXYNOS4 - arch/arm/boot/dts/exynos4x12.dtsi: CONFIG_ARCH_EXYNOS4 - arch/arm/boot/dts/exynos5250.dtsi: CONFIG_ARCH_EXYNOS5 - arch/arm/boot/dts/exynos5420.dtsi: CONFIG_ARCH_EXYNOS5 v2: - Remove the check completely instead of restricting it to ARCH_EXYNOS, as suggested Javier Martinez Canillas one year ago ("Removing the support for the deprecated property sound sensible to me", http://lists.infradead.org/pipermail/linux-arm-kernel/2016-October/462868.html). --- drivers/base/power/domain.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 0c80bea05bcb92be..f9dcc981b6b9328c 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -2199,20 +2199,8 @@ int genpd_dev_pm_attach(struct device *dev) ret = of_parse_phandle_with_args(dev->of_node, "power-domains", "#power-domain-cells", 0, &pd_args); - if (ret < 0) { - if (ret != -ENOENT) - return ret; - - /* - * Try legacy Samsung-specific bindings - * (for backwards compatibility of DT ABI) - */ - pd_args.args_count = 0; - pd_args.np = of_parse_phandle(dev->of_node, - "samsung,power-domain", 0); - if (!pd_args.np) - return -ENOENT; - } + if (ret < 0) + return ret; mutex_lock(&gpd_list_lock); pd = genpd_get_from_provider(&pd_args); -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: geert+renesas@glider.be (Geert Uytterhoeven) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2] PM / Domains: Remove obsolete "samsung, power-domain" check Date: Thu, 30 Nov 2017 12:54:28 +0100 [thread overview] Message-ID: <1512042868-23017-1-git-send-email-geert+renesas@glider.be> (raw) Currently the generic PM Domain code code checks for the presence of both (generic) "power-domains" and (Samsung Exynos legacy) "samsung,power-domain" properties in all device tree nodes representing devices. There are two issues with this: 1. This imposes a small boot-time penalty on all platforms using DT, 2. Platform-specific checks do not really belong in core framework code. Remove the platform-specific check, as the last user of "samsung,power-domain" was removed in commit 46dcf0ff0de35da8 ("ARM: dts: exynos: Remove exynos4415.dtsi"). All other users were converted before in commit 0da6587041363033 ("ARM: dts: convert to generic power domain bindings for exynos DT"). Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- This is v2 of 'PM / Domains: Restrict "samsung,power-domain" checks to ARCH_EXYNOS'. "samsung,power-domain" was only ever used in: - arch/arm/boot/dts/exynos4415.dtsi: Removed - arch/arm/boot/dts/exynos3250.dtsi: CONFIG_ARCH_EXYNOS3 - arch/arm/boot/dts/exynos4.dtsi: CONFIG_ARCH_EXYNOS4 - arch/arm/boot/dts/exynos4x12.dtsi: CONFIG_ARCH_EXYNOS4 - arch/arm/boot/dts/exynos5250.dtsi: CONFIG_ARCH_EXYNOS5 - arch/arm/boot/dts/exynos5420.dtsi: CONFIG_ARCH_EXYNOS5 v2: - Remove the check completely instead of restricting it to ARCH_EXYNOS, as suggested Javier Martinez Canillas one year ago ("Removing the support for the deprecated property sound sensible to me", http://lists.infradead.org/pipermail/linux-arm-kernel/2016-October/462868.html). --- drivers/base/power/domain.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 0c80bea05bcb92be..f9dcc981b6b9328c 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -2199,20 +2199,8 @@ int genpd_dev_pm_attach(struct device *dev) ret = of_parse_phandle_with_args(dev->of_node, "power-domains", "#power-domain-cells", 0, &pd_args); - if (ret < 0) { - if (ret != -ENOENT) - return ret; - - /* - * Try legacy Samsung-specific bindings - * (for backwards compatibility of DT ABI) - */ - pd_args.args_count = 0; - pd_args.np = of_parse_phandle(dev->of_node, - "samsung,power-domain", 0); - if (!pd_args.np) - return -ENOENT; - } + if (ret < 0) + return ret; mutex_lock(&gpd_list_lock); pd = genpd_get_from_provider(&pd_args); -- 2.7.4
next reply other threads:[~2017-11-30 11:54 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-30 11:54 Geert Uytterhoeven [this message] 2017-11-30 11:54 ` [PATCH v2] PM / Domains: Remove obsolete "samsung, power-domain" check Geert Uytterhoeven 2017-11-30 13:21 ` [PATCH v2] PM / Domains: Remove obsolete "samsung,power-domain" check Ulf Hansson 2017-11-30 13:21 ` [PATCH v2] PM / Domains: Remove obsolete "samsung, power-domain" check Ulf Hansson 2017-11-30 13:21 ` [PATCH v2] PM / Domains: Remove obsolete "samsung,power-domain" check Ulf Hansson 2017-12-01 12:26 ` Krzysztof Kozlowski 2017-12-01 12:26 ` [PATCH v2] PM / Domains: Remove obsolete "samsung, power-domain" check Krzysztof Kozlowski 2017-12-17 17:59 ` [PATCH v2] PM / Domains: Remove obsolete "samsung,power-domain" check Rafael J. Wysocki 2017-12-17 17:59 ` [PATCH v2] PM / Domains: Remove obsolete "samsung, power-domain" check Rafael J. Wysocki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1512042868-23017-1-git-send-email-geert+renesas@glider.be \ --to=geert+renesas@glider.be \ --cc=kgene@kernel.org \ --cc=khilman@kernel.org \ --cc=krzk@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=rjw@rjwysocki.net \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.