From: Nikolay Borisov <nborisov@suse.com>
To: linux-btrfs@vger.kernel.org
Cc: Nikolay Borisov <nborisov@suse.com>
Subject: [PATCH 4/7] btrfs-progs: Use list_for_each_entry in write_dev_all_supers
Date: Tue, 5 Dec 2017 10:39:46 +0200 [thread overview]
Message-ID: <1512463189-24724-5-git-send-email-nborisov@suse.com> (raw)
In-Reply-To: <1512463189-24724-1-git-send-email-nborisov@suse.com>
No need to use extra variable and 2 macros when we can succintly use 1.
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
disk-io.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/disk-io.c b/disk-io.c
index f5edc4796619..3d8785d5bb37 100644
--- a/disk-io.c
+++ b/disk-io.c
@@ -1556,7 +1556,6 @@ static int write_dev_supers(struct btrfs_fs_info *fs_info,
int write_all_supers(struct btrfs_fs_info *fs_info)
{
- struct list_head *cur;
struct list_head *head = &fs_info->fs_devices->devices;
struct btrfs_device *dev;
struct btrfs_super_block *sb;
@@ -1566,8 +1565,7 @@ int write_all_supers(struct btrfs_fs_info *fs_info)
sb = fs_info->super_copy;
dev_item = &sb->dev_item;
- list_for_each(cur, head) {
- dev = list_entry(cur, struct btrfs_device, dev_list);
+ list_for_each_entry(dev, head, dev_list) {
if (!dev->writeable)
continue;
--
2.7.4
next prev parent reply other threads:[~2017-12-05 8:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 8:39 [PATCH 0/7] Misc btrfs-progs cleanups/fixes Nikolay Borisov
2017-12-05 8:39 ` [PATCH 1/7] btrfs-progs: Explictly state test.sh must be executable Nikolay Borisov
2017-12-05 8:57 ` Qu Wenruo
2017-12-05 8:39 ` [PATCH 2/7] btrfs-progs: Factor out common print_device_info Nikolay Borisov
2017-12-05 9:02 ` Qu Wenruo
2017-12-05 8:39 ` [PATCH 3/7] btrfs-progs: Remove recover_get_good_super Nikolay Borisov
2017-12-05 9:10 ` Qu Wenruo
2017-12-05 8:39 ` Nikolay Borisov [this message]
2017-12-05 9:14 ` [PATCH 4/7] btrfs-progs: Use list_for_each_entry in write_dev_all_supers Qu Wenruo
2017-12-05 9:16 ` Nikolay Borisov
2017-12-07 9:10 ` [PATCH v2] btrfs-progs: Replace usage of list_for_each with list_for_each_entry Nikolay Borisov
2017-12-07 9:59 ` Qu Wenruo
2017-12-05 8:39 ` [PATCH 5/7] btrfs-progs: Document logic of btrfs_read_dev_super Nikolay Borisov
2017-12-05 9:21 ` Qu Wenruo
2017-12-05 8:39 ` [PATCH 6/7] btrfs-progs: Add test for super block recovery Nikolay Borisov
2017-12-05 9:33 ` Qu Wenruo
2017-12-05 10:04 ` Nikolay Borisov
2017-12-05 11:12 ` Qu Wenruo
2017-12-05 11:26 ` Nikolay Borisov
2017-12-05 12:13 ` Qu Wenruo
2018-01-23 15:07 ` David Sterba
2018-01-23 15:29 ` Nikolay Borisov
2018-01-23 15:39 ` David Sterba
2017-12-05 8:39 ` [PATCH 7/7] btrfs-progs: Fix super-recovery Nikolay Borisov
2017-12-05 9:35 ` Qu Wenruo
2018-01-15 9:17 ` [PATCH 0/7] Misc btrfs-progs cleanups/fixes Nikolay Borisov
2018-01-23 15:40 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512463189-24724-5-git-send-email-nborisov@suse.com \
--to=nborisov@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.