From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: linux-kbuild@vger.kernel.org
Cc: lukas.bulwahn@gmail.com, Nicholas Mc Guire <der.herr@hofr.at>,
sil2review@lists.osadl.org,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
linux-kernel@vger.kernel.org
Subject: [PATCH] fixdep: exit with error code in error branches of do_config_file()
Date: Wed, 20 Dec 2017 21:27:02 +0100 [thread overview]
Message-ID: <1513801623-19069-1-git-send-email-lukas.bulwahn@gmail.com> (raw)
do_config_file() should exit with an error code, and not return if it fails
as then the error in do_config_file() would go unnoticed in the current
code and allow the build to continue. The exit with error code will make
the build fail in those very exceptional cases. If this occurs, this
actually indicates a deeper problem in the execution of the kernel build
process.
Now, that the function exists, we do not explicitly free memory and close
the file handlers in do_config_file(), as this is covered by exit().
This issue in the fixdep script was present already before its initial
import into the git repository in 2005 (Linux-2.6.12-rc2). Hence, the Fixes
tag would be imprecise and we do not include a Fixes tag to this commit.
This issue was identified during the review of a previous patch that
intended to address a memory leak detected by a static analysis tool.
Link: https://lkml.org/lkml/2017/12/14/736
Suggested-by: Nicholas Mc Guire <der.herr@hofr.at>
Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
compile tested on top of next-20171220 with clang and gcc
scripts/basic/fixdep.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/scripts/basic/fixdep.c b/scripts/basic/fixdep.c
index bbf62cb..4274610 100644
--- a/scripts/basic/fixdep.c
+++ b/scripts/basic/fixdep.c
@@ -284,19 +284,18 @@ static void do_config_file(const char *filename)
exit(2);
}
if (st.st_size == 0) {
- close(fd);
- return;
+ fprintf(stderr, "fixdep: error empty file config file: ");
+ perror(filename);
+ exit(2);
}
map = malloc(st.st_size + 1);
if (!map) {
perror("fixdep: malloc");
- close(fd);
- return;
+ exit(2);
}
if (read(fd, map, st.st_size) != st.st_size) {
perror("fixdep: read");
- close(fd);
- return;
+ exit(2);
}
map[st.st_size] = '\0';
close(fd);
--
2.7.4
next reply other threads:[~2017-12-20 20:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 20:27 Lukas Bulwahn [this message]
2017-12-21 15:33 ` [PATCH] fixdep: exit with error code in error branches of do_config_file() Nicholas Mc Guire
2017-12-21 19:10 ` [PATCH v2] " Lukas Bulwahn
2017-12-30 16:51 ` Masahiro Yamada
2017-12-31 15:45 ` Nicholas Mc Guire
2018-01-01 6:41 ` Masahiro Yamada
2018-01-01 9:31 ` Nicholas Mc Guire
2018-01-01 9:55 ` Sam Ravnborg
2018-01-08 10:17 ` Lukas Bulwahn
2018-01-09 8:39 ` Masahiro Yamada
2018-01-08 10:04 ` [PATCH v3] " Lukas Bulwahn
2018-01-09 8:26 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513801623-19069-1-git-send-email-lukas.bulwahn@gmail.com \
--to=lukas.bulwahn@gmail.com \
--cc=der.herr@hofr.at \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=sil2review@lists.osadl.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.