All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
Subject: [v2 PATCH 2/2] drm/i915/guc : GEM_BUG_ON on invoking GuC reset function
Date: Wed, 27 Dec 2017 14:48:18 -0800	[thread overview]
Message-ID: <1514414898-18721-2-git-send-email-sujaritha.sundaresan@intel.com> (raw)
In-Reply-To: <1514414898-18721-1-git-send-email-sujaritha.sundaresan@intel.com>

Instead of returning -EINVAL, GEM_BUG_ON when GuC reset is invoked for
platforms not supporting as we don't expect to invoke it.

v2: re-wording commit message and subject (Sagar)

Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Sagar Arun Kamble <sagar.a.kamble@intel.com>
---
 drivers/gpu/drm/i915/intel_uncore.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
index 89547b61..94e1fb3 100644
--- a/drivers/gpu/drm/i915/intel_uncore.c
+++ b/drivers/gpu/drm/i915/intel_uncore.c
@@ -1936,8 +1936,7 @@ int intel_reset_guc(struct drm_i915_private *dev_priv)
 {
 	int ret;
 
-	if (!HAS_GUC(dev_priv))
-		return -EINVAL;
+	GEM_BUG_ON(!HAS_GUC(dev_priv));
 
 	intel_uncore_forcewake_get(dev_priv, FORCEWAKE_ALL);
 	ret = gen6_hw_domain_reset(dev_priv, GEN9_GRDOM_GUC);
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-12-27 22:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-27 22:48 [PATCH 1/2] drm/i915/guc : Decoupling ADS and logs from submission Sujaritha Sundaresan
2017-12-27 22:48 ` Sujaritha Sundaresan [this message]
2017-12-28  8:59   ` [v2 PATCH 2/2] drm/i915/guc : GEM_BUG_ON on invoking GuC reset function Sagar Arun Kamble
2017-12-27 23:18 ` ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915/guc : Decoupling ADS and logs from submission Patchwork
2017-12-28  8:58 ` [PATCH 1/2] " Sagar Arun Kamble
  -- strict thread matches above, loose matches on Subject: below --
2018-01-02 21:20 [v2 PATCH " Sujaritha Sundaresan
2018-01-02 21:20 ` [v2 PATCH 2/2] drm/i915/guc : GEM_BUG_ON on invoking GuC reset function Sujaritha Sundaresan
2017-12-27 19:17 Sujaritha Sundaresan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1514414898-18721-2-git-send-email-sujaritha.sundaresan@intel.com \
    --to=sujaritha.sundaresan@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.