From: venkat.prashanth2498@gmail.com
To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org
Cc: knaack.h@gmx.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org,
Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
Subject: [PATCH v2] Drivers:iio:dac: Remove unneeded conversion to bool
Date: Thu, 4 Jan 2018 21:49:07 +0530 [thread overview]
Message-ID: <1515082747-386-1-git-send-email-venkat.prashanth2498@gmail.com> (raw)
From: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
This is a patch to the mcp4725.c file which
fixes the following coccinelle warning:
WARNING: conversion to bool not needed here
Signed-off-by: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
Changes since v1:
-----------------
Instead of inadvertent removal of complete statement, only the
conversion to bool is removed.
---
drivers/iio/dac/mcp4725.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/dac/mcp4725.c b/drivers/iio/dac/mcp4725.c
index afa856d..8b5aad4 100644
--- a/drivers/iio/dac/mcp4725.c
+++ b/drivers/iio/dac/mcp4725.c
@@ -476,7 +476,7 @@ static int mcp4725_probe(struct i2c_client *client,
goto err_disable_vref_reg;
}
pd = (inbuf[0] >> 1) & 0x3;
- data->powerdown = pd > 0 ? true : false;
+ data->powerdown = pd > 0;
data->powerdown_mode = pd ? pd - 1 : 2; /* largest resistor to gnd */
data->dac_value = (inbuf[1] << 4) | (inbuf[2] >> 4);
if (data->id == MCP4726)
--
1.9.1
next reply other threads:[~2018-01-04 16:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 16:19 venkat.prashanth2498 [this message]
2018-01-06 12:36 ` [PATCH v2] Drivers:iio:dac: Remove unneeded conversion to bool Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515082747-386-1-git-send-email-venkat.prashanth2498@gmail.com \
--to=venkat.prashanth2498@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.