All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sagar Arun Kamble <sagar.a.kamble@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v4 4/9] drm/i915/guc: Grab RPM wakelock while disabling GuC interrupts
Date: Fri,  5 Jan 2018 14:16:56 +0530	[thread overview]
Message-ID: <1515142021-24232-5-git-send-email-sagar.a.kamble@intel.com> (raw)
In-Reply-To: <1515142021-24232-1-git-send-email-sagar.a.kamble@intel.com>

Disabling GuC interrupts involves access to GuC IRQ control registers
hence ensure device is RPM awake.

v2: Add comment about need to synchronize flush work and log runtime
    destroy

v3: Moved patch earlier in the series and removed comment about future
work. (Tvrtko)

v4: Rebase.

Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_guc_log.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_guc_log.c b/drivers/gpu/drm/i915/intel_guc_log.c
index d866645..7bae6eb 100644
--- a/drivers/gpu/drm/i915/intel_guc_log.c
+++ b/drivers/gpu/drm/i915/intel_guc_log.c
@@ -631,7 +631,10 @@ void i915_guc_log_unregister(struct drm_i915_private *dev_priv)
 
 	mutex_lock(&dev_priv->drm.struct_mutex);
 	/* GuC logging is currently the only user of Guc2Host interrupts */
+	intel_runtime_pm_get(dev_priv);
 	intel_guc_disable_interrupts(&dev_priv->guc);
+	intel_runtime_pm_put(dev_priv);
+
 	intel_guc_log_runtime_destroy(&dev_priv->guc);
 	mutex_unlock(&dev_priv->drm.struct_mutex);
 }
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-01-05  8:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-05  8:46 [PATCH v4 0/9] GuC Interrupts/Log updates Sagar Arun Kamble
2018-01-05  8:46 ` [PATCH v4 1/9] drm/i915/guc: Move GuC interrupts related functions from i915_irq.c to intel_guc.c Sagar Arun Kamble
2018-01-05  8:46 ` [PATCH v4 2/9] drm/i915/guc: Fix GuC interrupts disabling with logging Sagar Arun Kamble
2018-01-05  8:46 ` [PATCH v4 3/9] drm/i915/guc: Separate creation/release of runtime logging data from base logging data Sagar Arun Kamble
2018-01-05  8:46 ` Sagar Arun Kamble [this message]
2018-01-05  8:46 ` [PATCH v4 5/9] drm/i915/guc: Make guc_log_level parameter immutable Sagar Arun Kamble
2018-01-05  8:46 ` [PATCH v4 6/9] drm/i915/guc: Make GuC log related functions depend only on log level Sagar Arun Kamble
2018-01-05  8:46 ` [PATCH v4 7/9] drm/i915/guc: Add client support to enable/disable GuC interrupts Sagar Arun Kamble
2018-01-05  8:47 ` [PATCH v4 8/9] drm/i915/guc: Restore GuC interrupts across suspend/reset if enabled Sagar Arun Kamble
2018-01-05  8:47 ` [PATCH v4 9/9] HAX: drm/i915/guc: enable GuC submission/logging for CI Sagar Arun Kamble
2018-01-05  9:12 ` ✗ Fi.CI.BAT: failure for GuC Interrupts/Log updates (rev3) Patchwork
2018-01-05 10:24   ` Sagar Arun Kamble

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1515142021-24232-5-git-send-email-sagar.a.kamble@intel.com \
    --to=sagar.a.kamble@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.