From: Wei Yongjun <weiyongjun1@huawei.com> To: <l.stelmach@samsung.com>, <mpm@selenic.com>, <herbert@gondor.apana.org.au>, <arnd@arndb.de>, <gregkh@linuxfoundation.org>, <kgene@kernel.org>, <krzk@kernel.org> Cc: Wei Yongjun <weiyongjun1@huawei.com>, <linux-samsung-soc@vger.kernel.org>, <linux-crypto@vger.kernel.org>, <kernel-janitors@vger.kernel.org> Subject: [PATCH -next] hwrng: exynos - remove redundant dev_err call in exynos_trng_probe() Date: Wed, 10 Jan 2018 13:30:59 +0000 [thread overview] Message-ID: <1515591059-73230-1-git-send-email-weiyongjun1@huawei.com> (raw) There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/char/hw_random/exynos-trng.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_random/exynos-trng.c index 34d6f51..4c8a2be 100644 --- a/drivers/char/hw_random/exynos-trng.c +++ b/drivers/char/hw_random/exynos-trng.c @@ -129,10 +129,8 @@ static int exynos_trng_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); trng->mem = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(trng->mem)) { - dev_err(&pdev->dev, "Could not map IO resources.\n"); + if (IS_ERR(trng->mem)) return PTR_ERR(trng->mem); - } pm_runtime_enable(&pdev->dev); ret = pm_runtime_get_sync(&pdev->dev);
WARNING: multiple messages have this Message-ID (diff)
From: Wei Yongjun <weiyongjun1@huawei.com> To: l.stelmach@samsung.com, mpm@selenic.com, herbert@gondor.apana.org.au, arnd@arndb.de, gregkh@linuxfoundation.org, kgene@kernel.org, krzk@kernel.org Cc: Wei Yongjun <weiyongjun1@huawei.com>, linux-samsung-soc@vger.kernel.org, linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH -next] hwrng: exynos - remove redundant dev_err call in exynos_trng_probe() Date: Wed, 10 Jan 2018 13:30:59 +0000 [thread overview] Message-ID: <1515591059-73230-1-git-send-email-weiyongjun1@huawei.com> (raw) There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/char/hw_random/exynos-trng.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_random/exynos-trng.c index 34d6f51..4c8a2be 100644 --- a/drivers/char/hw_random/exynos-trng.c +++ b/drivers/char/hw_random/exynos-trng.c @@ -129,10 +129,8 @@ static int exynos_trng_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); trng->mem = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(trng->mem)) { - dev_err(&pdev->dev, "Could not map IO resources.\n"); + if (IS_ERR(trng->mem)) return PTR_ERR(trng->mem); - } pm_runtime_enable(&pdev->dev); ret = pm_runtime_get_sync(&pdev->dev);
next reply other threads:[~2018-01-10 13:24 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-10 13:30 Wei Yongjun [this message] 2018-01-10 13:30 ` [PATCH -next] hwrng: exynos - remove redundant dev_err call in exynos_trng_probe() Wei Yongjun 2018-01-10 14:24 ` Krzysztof Kozlowski 2018-01-10 14:24 ` Krzysztof Kozlowski [not found] ` <CGME20180111111347eucas1p1207cc5450f132c7579e9bd7ebc9c31df@eucas1p1.samsung.com> 2018-01-11 11:13 ` Łukasz Stelmach 2018-01-11 11:13 ` Łukasz Stelmach 2018-01-18 12:03 ` Herbert Xu 2018-01-18 12:03 ` Herbert Xu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1515591059-73230-1-git-send-email-weiyongjun1@huawei.com \ --to=weiyongjun1@huawei.com \ --cc=arnd@arndb.de \ --cc=gregkh@linuxfoundation.org \ --cc=herbert@gondor.apana.org.au \ --cc=kernel-janitors@vger.kernel.org \ --cc=kgene@kernel.org \ --cc=krzk@kernel.org \ --cc=l.stelmach@samsung.com \ --cc=linux-crypto@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=mpm@selenic.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.