All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sagar Arun Kamble <sagar.a.kamble@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 1/2] drm/i915/guc: Don't enable GuC when vGPU is active
Date: Thu, 11 Jan 2018 22:01:17 +0530	[thread overview]
Message-ID: <1515688278-5583-1-git-send-email-sagar.a.kamble@intel.com> (raw)

In GVT-g, if GuC is to be used it is to be loaded by Host and not by
VM/vGPU. Currently, GVT-g host is not supported with GuC submission.
Also currently vGPU is to be not supported with GuC submission AFAIK.
CI BAT highlighted GuC init issue on skl-gvtdvm due to lack of movntdqa
needed for logging with below warning:

 WARN_ON(!i915_memcpy_from_wc(((void *)0), ((void *)0), 0))
 WARNING: CPU: 0 PID: 216 at drivers/gpu/drm/i915/intel_guc_log.c:383

This patch disables GuC when vGPU is active.

Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Changbin Du <changbin.du@intel.com>
---
 drivers/gpu/drm/i915/intel_uc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
index d82ca0f..a836cf8 100644
--- a/drivers/gpu/drm/i915/intel_uc.c
+++ b/drivers/gpu/drm/i915/intel_uc.c
@@ -61,6 +61,8 @@ static int __get_platform_enable_guc(struct drm_i915_private *dev_priv)
 		enable_guc |= ENABLE_GUC_LOAD_HUC;
 
 	/* Any platform specific fine-tuning can be done here */
+	if (intel_vgpu_active(dev_priv))
+		enable_guc = 0;
 
 	return enable_guc;
 }
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2018-01-11 16:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-11 16:31 Sagar Arun Kamble [this message]
2018-01-11 16:31 ` [PATCH 2/2] HAX: drm/i915/uc: Enable GuC/HuC for CI Sagar Arun Kamble
2018-01-11 16:57 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/guc: Don't enable GuC when vGPU is active Patchwork
2018-01-12  6:02   ` Sagar Arun Kamble
2018-01-12  6:08     ` Du, Changbin
2018-01-15 10:07       ` Joonas Lahtinen
2018-01-15 10:28         ` Zhenyu Wang
2018-01-15 11:10           ` Tomi Sarvela
2018-01-16  9:53             ` Joonas Lahtinen
2018-01-16 10:17               ` Michal Wajdeczko
2018-01-17  2:36                 ` Du, Changbin
2018-01-17 11:18                   ` Tvrtko Ursulin
2018-01-18  9:42                 ` Joonas Lahtinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1515688278-5583-1-git-send-email-sagar.a.kamble@intel.com \
    --to=sagar.a.kamble@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.