From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: linux-mmc@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Ulf Magnusson <ulfalizer@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Simon Horman <horms+renesas@verge.net.au>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
linux-renesas-soc@vger.kernel.org,
Masahiro Yamada <yamada.masahiro@socionext.com>,
devicetree@vger.kernel.org, Rob Herring <robh@kernel.org>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: [PATCH v3 11/16] mmc: tmio: deprecate "toshiba,mmc-wrprotect-disable" DT property
Date: Thu, 18 Jan 2018 01:28:11 +0900 [thread overview]
Message-ID: <1516206496-16612-12-git-send-email-yamada.masahiro@socionext.com> (raw)
In-Reply-To: <1516206496-16612-1-git-send-email-yamada.masahiro@socionext.com>
This property is equivalent to "disable-wp" defined in
Documentation/devicetree/bindings/mmc/tmio_mmc.txt
The TMIO MMC core calls mmc_of_parse(), and it sets
MMC_CAP2_NO_WRITE_PROTECT if "disable-wp" property is present.
We do not need a vendor-specific property to do the same thing.
Let's remove the description from the dt-binding to prevent new boards
from using it.
I am keeping the driver code for existing DT files, but added
comments that this is deprecated.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
Changes in v3:
- newly added
Changes in v2: None
Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 1 -
drivers/mmc/host/tmio_mmc_core.c | 5 +++++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
index 3c67624..cb7d40e 100644
--- a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
+++ b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
@@ -49,7 +49,6 @@ Required properties:
2: R7S72100
Optional properties:
-- toshiba,mmc-wrprotect-disable: write-protect detection is unavailable
- pinctrl-names: should be "default", "state_uhs"
- pinctrl-0: should contain default/high speed pin ctrl
- pinctrl-1: should contain uhs mode pin ctrl
diff --git a/drivers/mmc/host/tmio_mmc_core.c b/drivers/mmc/host/tmio_mmc_core.c
index 7ad3433c..f30ac69 100644
--- a/drivers/mmc/host/tmio_mmc_core.c
+++ b/drivers/mmc/host/tmio_mmc_core.c
@@ -1134,6 +1134,11 @@ static void tmio_mmc_of_parse(struct platform_device *pdev,
if (!np)
return;
+ /*
+ * DEPRECATED:
+ * For new platforms, please use "disable-wp" instead of
+ * "toshiba,mmc-wrprotect-disable"
+ */
if (of_get_property(np, "toshiba,mmc-wrprotect-disable", NULL))
mmc->caps2 |= MMC_CAP2_NO_WRITE_PROTECT;
}
--
2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Masahiro Yamada <yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
To: linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Wolfram Sang
<wsa+renesas-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>
Cc: Ulf Magnusson <ulfalizer-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Geert Uytterhoeven
<geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>,
Simon Horman
<horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>,
Yoshihiro Shimoda
<yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>,
linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Masahiro Yamada
<yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: [PATCH v3 11/16] mmc: tmio: deprecate "toshiba,mmc-wrprotect-disable" DT property
Date: Thu, 18 Jan 2018 01:28:11 +0900 [thread overview]
Message-ID: <1516206496-16612-12-git-send-email-yamada.masahiro@socionext.com> (raw)
In-Reply-To: <1516206496-16612-1-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
This property is equivalent to "disable-wp" defined in
Documentation/devicetree/bindings/mmc/tmio_mmc.txt
The TMIO MMC core calls mmc_of_parse(), and it sets
MMC_CAP2_NO_WRITE_PROTECT if "disable-wp" property is present.
We do not need a vendor-specific property to do the same thing.
Let's remove the description from the dt-binding to prevent new boards
from using it.
I am keeping the driver code for existing DT files, but added
comments that this is deprecated.
Signed-off-by: Masahiro Yamada <yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
---
Changes in v3:
- newly added
Changes in v2: None
Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 1 -
drivers/mmc/host/tmio_mmc_core.c | 5 +++++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
index 3c67624..cb7d40e 100644
--- a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
+++ b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
@@ -49,7 +49,6 @@ Required properties:
2: R7S72100
Optional properties:
-- toshiba,mmc-wrprotect-disable: write-protect detection is unavailable
- pinctrl-names: should be "default", "state_uhs"
- pinctrl-0: should contain default/high speed pin ctrl
- pinctrl-1: should contain uhs mode pin ctrl
diff --git a/drivers/mmc/host/tmio_mmc_core.c b/drivers/mmc/host/tmio_mmc_core.c
index 7ad3433c..f30ac69 100644
--- a/drivers/mmc/host/tmio_mmc_core.c
+++ b/drivers/mmc/host/tmio_mmc_core.c
@@ -1134,6 +1134,11 @@ static void tmio_mmc_of_parse(struct platform_device *pdev,
if (!np)
return;
+ /*
+ * DEPRECATED:
+ * For new platforms, please use "disable-wp" instead of
+ * "toshiba,mmc-wrprotect-disable"
+ */
if (of_get_property(np, "toshiba,mmc-wrprotect-disable", NULL))
mmc->caps2 |= MMC_CAP2_NO_WRITE_PROTECT;
}
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-01-17 16:29 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 16:28 [PATCH v3 00/16] mmc: tmio: another batch of TMIO MMC fixes and cleanups Masahiro Yamada
2018-01-17 16:28 ` Masahiro Yamada
2018-01-17 16:28 ` [PATCH v3 01/16] mmc: tmio: ioremap memory resource in tmio_mmc_host_alloc() Masahiro Yamada
2018-01-17 16:28 ` [PATCH v3 02/16] mmc: tmio: move clk_enable/disable out of tmio_mmc_host_probe() Masahiro Yamada
2018-01-17 16:28 ` [PATCH v3 03/16] mmc: tmio: move {tmio_}mmc_of_parse() to tmio_mmc_host_alloc() Masahiro Yamada
2018-01-17 16:28 ` [PATCH v3 04/16] mmc: tmio: remove dma_ops from tmio_mmc_host_probe() argument Masahiro Yamada
2018-01-17 16:28 ` [PATCH v3 05/16] mmc: slot-gpio: add a helper to check capability of GPIO WP detection Masahiro Yamada
2018-02-07 19:06 ` Wolfram Sang
2018-01-17 16:28 ` [PATCH v3 06/16] mmc: tmio: refactor .get_ro hook Masahiro Yamada
2018-02-07 19:09 ` Wolfram Sang
2018-01-17 16:28 ` [PATCH v3 07/16] mmc: renesas_sdhi: use MMC_CAP2_NO_WRITE_PROTECT instead of TMIO own flag Masahiro Yamada
2018-02-07 19:28 ` Wolfram Sang
2018-01-17 16:28 ` [PATCH v3 08/16] sh: kfr2r09: " Masahiro Yamada
2018-01-17 16:28 ` Masahiro Yamada
2018-02-07 19:28 ` Wolfram Sang
2018-02-07 19:28 ` Wolfram Sang
2018-01-17 16:28 ` [PATCH v3 09/16] mmc: tmio: " Masahiro Yamada
2018-02-07 19:31 ` Wolfram Sang
2018-01-17 16:28 ` [PATCH v3 10/16] mmc: tmio: remove TMIO_MMC_WRPROTECT_DISABLE Masahiro Yamada
2018-01-18 8:27 ` Lee Jones
2018-02-07 19:31 ` Wolfram Sang
2018-01-17 16:28 ` Masahiro Yamada [this message]
2018-01-17 16:28 ` [PATCH v3 11/16] mmc: tmio: deprecate "toshiba,mmc-wrprotect-disable" DT property Masahiro Yamada
2018-01-18 1:58 ` Masahiro Yamada
2018-01-29 17:18 ` Rob Herring
2018-01-29 17:18 ` Rob Herring
2018-02-07 19:32 ` Wolfram Sang
2018-02-07 19:32 ` Wolfram Sang
2018-03-18 2:46 ` Masahiro Yamada
2018-01-17 16:28 ` [PATCH v3 12/16] mmc: tmio: support IP-builtin card detection logic Masahiro Yamada
2018-02-07 19:34 ` Wolfram Sang
2018-02-08 1:02 ` Masahiro Yamada
2018-01-17 16:28 ` [PATCH v3 13/16] mmc: tmio: fix never-detected card insertion bug Masahiro Yamada
2018-02-07 19:38 ` Wolfram Sang
2018-01-17 16:28 ` [PATCH v3 14/16] mmc: tmio: move TMIO_MASK_{READOP,WRITEOP} handling to correct place Masahiro Yamada
2018-02-07 21:47 ` Wolfram Sang
2018-02-08 1:11 ` Masahiro Yamada
2018-03-04 22:34 ` Wolfram Sang
2018-01-17 16:28 ` [PATCH v3 15/16] mmc: tmio: clear force_pio flag before starting data transfer Masahiro Yamada
2018-03-04 22:39 ` Wolfram Sang
2018-01-17 16:28 ` [PATCH v3 16/16] mmc: tmio: remove useless TMIO_MASK_CMD handling in tmio_mmc_host_probe() Masahiro Yamada
2018-03-04 22:39 ` Wolfram Sang
2018-01-18 8:13 ` [PATCH v3 00/16] mmc: tmio: another batch of TMIO MMC fixes and cleanups Ulf Hansson
2018-01-18 8:13 ` Ulf Hansson
2018-02-07 19:11 ` Wolfram Sang
2018-02-07 19:11 ` Wolfram Sang
2018-02-14 9:36 ` Ulf Hansson
2018-02-14 9:36 ` Ulf Hansson
2018-02-14 9:43 ` Masahiro Yamada
2018-02-14 9:43 ` Masahiro Yamada
2018-02-14 9:46 ` Ulf Hansson
2018-02-14 9:46 ` Ulf Hansson
[not found] ` <CAPDyKFoxp7p0atQTV=PoQ7Bwt0fOs2aEq1KJHPtrq+zA3eFYgw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-14 10:23 ` Wolfram Sang
2018-02-14 10:23 ` Wolfram Sang
2018-02-14 10:23 ` Wolfram Sang
2018-02-14 10:39 ` Ulf Hansson
2018-02-14 10:39 ` Ulf Hansson
2018-03-04 22:42 ` Wolfram Sang
2018-03-04 22:42 ` Wolfram Sang
2018-03-05 8:45 ` Ulf Hansson
2018-03-05 8:45 ` Ulf Hansson
2018-03-05 9:22 ` Wolfram Sang
2018-03-05 9:22 ` Wolfram Sang
2018-03-05 9:34 ` Masahiro Yamada
2018-03-05 9:34 ` Masahiro Yamada
2018-03-05 9:39 ` Wolfram Sang
2018-03-05 9:39 ` Wolfram Sang
2018-03-05 12:06 ` Ulf Hansson
2018-03-05 12:06 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516206496-16612-12-git-send-email-yamada.masahiro@socionext.com \
--to=yamada.masahiro@socionext.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=horms+renesas@verge.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=ulfalizer@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.