All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ramalingam C <ramalingam.c@intel.com>
To: intel-gfx@lists.freedesktop.org, seanpaul@chromium.org
Cc: daniel.vetter@ffwll.ch, rodrigo.vivi@intel.com
Subject: [PATCH v3 5/8] drm/i915: Optimize HDCP key load
Date: Sat,  3 Feb 2018 03:39:07 +0530	[thread overview]
Message-ID: <1517609350-10698-6-git-send-email-ramalingam.c@intel.com> (raw)
In-Reply-To: <1517609350-10698-1-git-send-email-ramalingam.c@intel.com>

HDCP key need not be cleared on each hdcp disable. And HDCP key Load
is skipped if key is already loaded.

v2:
  No change. Added Reviewed-by tag.

v3:
  No change.

Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
---
 drivers/gpu/drm/i915/intel_hdcp.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_hdcp.c b/drivers/gpu/drm/i915/intel_hdcp.c
index b1047dbf3393..65bdb95c0ad7 100644
--- a/drivers/gpu/drm/i915/intel_hdcp.c
+++ b/drivers/gpu/drm/i915/intel_hdcp.c
@@ -49,6 +49,10 @@ static int intel_hdcp_load_keys(struct drm_i915_private *dev_priv)
 	int ret;
 	u32 val;
 
+	val = I915_READ(HDCP_KEY_STATUS);
+	if ((val & HDCP_KEY_LOAD_DONE) && (val & HDCP_KEY_LOAD_STATUS))
+		return 0;
+
 	/*
 	 * On HSW and BDW HW loads the HDCP1.4 Key when Display comes
 	 * out of reset. So if Key is not already loaded, its an error state.
@@ -545,8 +549,6 @@ static int _intel_hdcp_disable(struct intel_connector *connector)
 		return -ETIMEDOUT;
 	}
 
-	intel_hdcp_clear_keys(dev_priv);
-
 	ret = connector->hdcp_shim->toggle_signalling(intel_dig_port, false);
 	if (ret) {
 		DRM_ERROR("Failed to disable HDCP signalling\n");
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-02-02 22:15 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-02 22:09 [PATCH v3 0/8] Adhering to HDCP1.4 Compliance Test Spec Ramalingam C
2018-02-02 22:09 ` [PATCH v3 1/8] drm/i915: Handle failure from 2nd stage HDCP auth Ramalingam C
2018-02-02 22:09 ` [PATCH v3 2/8] drm/i915: Stop encryption for repeater with no sink Ramalingam C
2018-02-02 22:09 ` [PATCH v3 3/8] drm/i915: Connector info in HDCP debug msgs Ramalingam C
2018-02-02 22:09 ` [PATCH v3 4/8] drm/i915: Retry HDCP bksv read Ramalingam C
2018-02-05 16:47   ` Sean Paul
2018-02-05 17:14   ` [PATCH v4] " Ramalingam C
2018-02-05 17:24     ` Sean Paul
2018-02-05 17:24       ` Ramalingam C
2018-02-05 17:32     ` [PATCH v5] " Ramalingam C
2018-02-02 22:09 ` Ramalingam C [this message]
2018-02-02 22:09 ` [PATCH v3 6/8] drm/i915: Detect panel's hdcp capability Ramalingam C
2018-02-02 22:09 ` [PATCH v3 7/8] drm/i915: Reauthenticate HDCP on failure Ramalingam C
2018-02-02 22:09 ` [PATCH v3 8/8] drm/i915: fix misalignment in HDCP register def Ramalingam C
2018-02-03  5:37 ` ✓ Fi.CI.BAT: success for Adhering to HDCP1.4 Compliance Test Spec (rev3) Patchwork
2018-02-03  8:46 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-02-05 16:50 ` [PATCH v3 0/8] Adhering to HDCP1.4 Compliance Test Spec Sean Paul
2018-02-05 17:13   ` C, Ramalingam
2018-02-05 18:39 ` Sean Paul
2018-02-05 19:00 ` ✓ Fi.CI.BAT: success for Adhering to HDCP1.4 Compliance Test Spec (rev5) Patchwork
2018-02-05 21:51 ` ✗ Fi.CI.IGT: warning " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1517609350-10698-6-git-send-email-ramalingam.c@intel.com \
    --to=ramalingam.c@intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=seanpaul@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.