All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Javier González" <jg@lightnvm.io>
To: mb@lightnvm.io
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-nvme@lists.infradead.org,
	"Javier González" <javier@cnexlabs.com>
Subject: [PATCH 14/20] lightnvm: make address conversions depend on generic device
Date: Wed, 21 Feb 2018 10:26:52 +0100	[thread overview]
Message-ID: <1519205218-26994-15-git-send-email-javier@cnexlabs.com> (raw)
In-Reply-To: <1519205218-26994-1-git-send-email-javier@cnexlabs.com>

On address conversions, use the generic device, instead of the target
device. This allows to use conversions outside of the target's realm.

Signed-off-by: Javier González <javier@cnexlabs.com>
---
 drivers/lightnvm/core.c  | 4 ++--
 include/linux/lightnvm.h | 8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
index baec963b2c96..59b62ca65596 100644
--- a/drivers/lightnvm/core.c
+++ b/drivers/lightnvm/core.c
@@ -588,7 +588,7 @@ static void nvm_ppa_tgt_to_dev(struct nvm_tgt_dev *tgt_dev,
 
 	for (i = 0; i < nr_ppas; i++) {
 		nvm_map_to_dev(tgt_dev, &ppa_list[i]);
-		ppa_list[i] = generic_to_dev_addr(tgt_dev, ppa_list[i]);
+		ppa_list[i] = generic_to_dev_addr(tgt_dev->parent, ppa_list[i]);
 	}
 }
 
@@ -598,7 +598,7 @@ static void nvm_ppa_dev_to_tgt(struct nvm_tgt_dev *tgt_dev,
 	int i;
 
 	for (i = 0; i < nr_ppas; i++) {
-		ppa_list[i] = dev_to_generic_addr(tgt_dev, ppa_list[i]);
+		ppa_list[i] = dev_to_generic_addr(tgt_dev->parent, ppa_list[i]);
 		nvm_map_to_tgt(tgt_dev, &ppa_list[i]);
 	}
 }
diff --git a/include/linux/lightnvm.h b/include/linux/lightnvm.h
index cd310bf06051..91340998f0c3 100644
--- a/include/linux/lightnvm.h
+++ b/include/linux/lightnvm.h
@@ -415,10 +415,10 @@ struct nvm_dev {
 	struct list_head targets;
 };
 
-static inline struct ppa_addr generic_to_dev_addr(struct nvm_tgt_dev *tgt_dev,
+static inline struct ppa_addr generic_to_dev_addr(struct nvm_dev *dev,
 						  struct ppa_addr r)
 {
-	struct nvm_geo *geo = &tgt_dev->geo;
+	struct nvm_dev_geo *geo = &dev->dev_geo;
 	struct ppa_addr l;
 
 	if (geo->c.version == NVM_OCSSD_SPEC_12) {
@@ -443,10 +443,10 @@ static inline struct ppa_addr generic_to_dev_addr(struct nvm_tgt_dev *tgt_dev,
 	return l;
 }
 
-static inline struct ppa_addr dev_to_generic_addr(struct nvm_tgt_dev *tgt_dev,
+static inline struct ppa_addr dev_to_generic_addr(struct nvm_dev *dev,
 						  struct ppa_addr r)
 {
-	struct nvm_geo *geo = &tgt_dev->geo;
+	struct nvm_dev_geo *geo = &dev->dev_geo;
 	struct ppa_addr l;
 
 	l.ppa = 0;
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: jg@lightnvm.io (Javier González)
Subject: [PATCH 14/20] lightnvm: make address conversions depend on generic device
Date: Wed, 21 Feb 2018 10:26:52 +0100	[thread overview]
Message-ID: <1519205218-26994-15-git-send-email-javier@cnexlabs.com> (raw)
In-Reply-To: <1519205218-26994-1-git-send-email-javier@cnexlabs.com>

On address conversions, use the generic device, instead of the target
device. This allows to use conversions outside of the target's realm.

Signed-off-by: Javier Gonz?lez <javier at cnexlabs.com>
---
 drivers/lightnvm/core.c  | 4 ++--
 include/linux/lightnvm.h | 8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
index baec963b2c96..59b62ca65596 100644
--- a/drivers/lightnvm/core.c
+++ b/drivers/lightnvm/core.c
@@ -588,7 +588,7 @@ static void nvm_ppa_tgt_to_dev(struct nvm_tgt_dev *tgt_dev,
 
 	for (i = 0; i < nr_ppas; i++) {
 		nvm_map_to_dev(tgt_dev, &ppa_list[i]);
-		ppa_list[i] = generic_to_dev_addr(tgt_dev, ppa_list[i]);
+		ppa_list[i] = generic_to_dev_addr(tgt_dev->parent, ppa_list[i]);
 	}
 }
 
@@ -598,7 +598,7 @@ static void nvm_ppa_dev_to_tgt(struct nvm_tgt_dev *tgt_dev,
 	int i;
 
 	for (i = 0; i < nr_ppas; i++) {
-		ppa_list[i] = dev_to_generic_addr(tgt_dev, ppa_list[i]);
+		ppa_list[i] = dev_to_generic_addr(tgt_dev->parent, ppa_list[i]);
 		nvm_map_to_tgt(tgt_dev, &ppa_list[i]);
 	}
 }
diff --git a/include/linux/lightnvm.h b/include/linux/lightnvm.h
index cd310bf06051..91340998f0c3 100644
--- a/include/linux/lightnvm.h
+++ b/include/linux/lightnvm.h
@@ -415,10 +415,10 @@ struct nvm_dev {
 	struct list_head targets;
 };
 
-static inline struct ppa_addr generic_to_dev_addr(struct nvm_tgt_dev *tgt_dev,
+static inline struct ppa_addr generic_to_dev_addr(struct nvm_dev *dev,
 						  struct ppa_addr r)
 {
-	struct nvm_geo *geo = &tgt_dev->geo;
+	struct nvm_dev_geo *geo = &dev->dev_geo;
 	struct ppa_addr l;
 
 	if (geo->c.version == NVM_OCSSD_SPEC_12) {
@@ -443,10 +443,10 @@ static inline struct ppa_addr generic_to_dev_addr(struct nvm_tgt_dev *tgt_dev,
 	return l;
 }
 
-static inline struct ppa_addr dev_to_generic_addr(struct nvm_tgt_dev *tgt_dev,
+static inline struct ppa_addr dev_to_generic_addr(struct nvm_dev *dev,
 						  struct ppa_addr r)
 {
-	struct nvm_geo *geo = &tgt_dev->geo;
+	struct nvm_dev_geo *geo = &dev->dev_geo;
 	struct ppa_addr l;
 
 	l.ppa = 0;
-- 
2.7.4

  parent reply	other threads:[~2018-02-21  9:27 UTC|newest]

Thread overview: 99+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-21  9:26 [PATCH V2 00/20] lightnvm: pblk: implement 2.0 support Javier González
2018-02-21  9:26 ` Javier González
2018-02-21  9:26 ` [PATCH 01/20] lightnvm: simplify geometry structure Javier González
2018-02-21  9:26   ` Javier González
2018-02-22  7:25   ` Matias Bjørling
2018-02-22  7:25     ` Matias Bjørling
2018-02-22  7:44     ` Javier Gonzalez
2018-02-22  7:44       ` Javier Gonzalez
2018-02-22 12:22       ` Matias Bjørling
2018-02-22 12:22         ` Matias Bjørling
2018-02-22 14:13         ` Javier Gonzalez
2018-02-22 14:13           ` Javier Gonzalez
2018-02-21  9:26 ` [PATCH 02/20] lightnvm: add controller capabilities to 2.0 Javier González
2018-02-21  9:26   ` Javier González
2018-02-22  7:26   ` Matias Bjørling
2018-02-22  7:26     ` Matias Bjørling
2018-02-21  9:26 ` [PATCH 03/20] lightnvm: fix capabilities for 2.0 sysfs Javier González
2018-02-21  9:26   ` Javier González
2018-02-22  7:28   ` Matias Bjørling
2018-02-22  7:28     ` Matias Bjørling
2018-02-22  7:47     ` Javier Gonzalez
2018-02-22  7:47       ` Javier Gonzalez
2018-02-22  9:39       ` Matias Bjørling
2018-02-22  9:39         ` Matias Bjørling
2018-02-22 10:25         ` Javier Gonzalez
2018-02-22 10:25           ` Javier Gonzalez
2018-02-22 10:25           ` Javier Gonzalez
2018-02-22 11:10           ` Matias Bjørling
2018-02-22 11:10             ` Matias Bjørling
2018-02-22 11:12             ` Javier Gonzalez
2018-02-22 11:12               ` Javier Gonzalez
2018-02-21  9:26 ` [PATCH 04/20] lightnvm: add minor version to generic geometry Javier González
2018-02-21  9:26   ` Javier González
2018-02-22  7:34   ` Matias Bjørling
2018-02-22  7:34     ` Matias Bjørling
2018-02-22  7:53     ` Javier González
2018-02-22  7:53       ` Javier González
2018-02-21  9:26 ` [PATCH 05/20] lightnvm: rename number of channels and luns Javier González
2018-02-21  9:26   ` Javier González
2018-02-21  9:26 ` [PATCH 06/20] lightnvm: add shorten OCSSD version in geo Javier González
2018-02-21  9:26   ` Javier González
2018-02-21  9:26 ` [PATCH 07/20] lightnvm: rename sect_* to sec_* Javier González
2018-02-21  9:26   ` Javier González
2018-02-22  7:43   ` Matias Bjørling
2018-02-22  7:43     ` Matias Bjørling
2018-02-21  9:26 ` [PATCH 08/20] lightnvm: complete geo structure with maxoc* Javier González
2018-02-21  9:26   ` Javier González
2018-02-22  7:45   ` Matias Bjørling
2018-02-22  7:45     ` Matias Bjørling
2018-02-22  7:55     ` Javier Gonzalez
2018-02-22  7:55       ` Javier Gonzalez
2018-02-22  9:45       ` Matias Bjørling
2018-02-22  9:45         ` Matias Bjørling
2018-02-22  9:52         ` Javier Gonzalez
2018-02-22  9:52           ` Javier Gonzalez
2018-02-22 10:00           ` Matias Bjørling
2018-02-22 10:00             ` Matias Bjørling
2018-02-22 10:03             ` Javier Gonzalez
2018-02-22 10:03               ` Javier Gonzalez
2018-02-21  9:26 ` [PATCH 09/20] lightnvm: use generic identify structure Javier González
2018-02-21  9:26   ` Javier González
2018-02-22  7:47   ` Matias Bjørling
2018-02-22  7:47     ` Matias Bjørling
2018-02-22  7:49     ` Javier González
2018-02-22  7:49       ` Javier González
2018-02-22  9:41       ` Matias Bjørling
2018-02-22  9:41         ` Matias Bjørling
2018-02-21  9:26 ` [PATCH 10/20] lightnvm: pblk: rename ppaf* to addrf* Javier González
2018-02-21  9:26   ` Javier González
2018-02-21  9:26   ` Javier González
2018-02-22  7:47   ` Matias Bjørling
2018-02-22  7:47     ` Matias Bjørling
2018-02-22  7:47     ` Matias Bjørling
2018-02-21  9:26 ` [PATCH 11/20] lightnvm: pblk: check for supported version Javier González
2018-02-21  9:26   ` Javier González
2018-02-22  7:48   ` Matias Bjørling
2018-02-22  7:48     ` Matias Bjørling
2018-02-21  9:26 ` [PATCH 12/20] lightnvm: complete 2.0 values in sysfs Javier González
2018-02-21  9:26   ` Javier González
2018-02-21  9:26 ` [PATCH 13/20] lightnvm: add support for 2.0 address format Javier González
2018-02-21  9:26   ` Javier González
2018-02-22  9:24   ` Matias Bjørling
2018-02-22  9:24     ` Matias Bjørling
2018-02-21  9:26 ` Javier González [this message]
2018-02-21  9:26   ` [PATCH 14/20] lightnvm: make address conversions depend on generic device Javier González
2018-02-21  9:26 ` [PATCH 15/20] nvme: make nvme_get_log_ext available Javier González
2018-02-21  9:26   ` Javier González
2018-02-21  9:26 ` [PATCH 16/20] lightnvm: implement get log report chunk helpers Javier González
2018-02-21  9:26   ` Javier González
2018-02-21  9:26 ` [PATCH 17/20] lightnvm: define chunk states Javier González
2018-02-21  9:26   ` Javier González
2018-02-21  9:26 ` [PATCH 18/20] lightnvm: pblk: implement get log report chunk Javier González
2018-02-21  9:26   ` Javier González
2018-02-21  9:26 ` [PATCH 19/20] lightnvm: pblk: refactor init/exit sequences Javier González
2018-02-21  9:26   ` Javier González
2018-02-21  9:26 ` [PATCH 20/20] lightnvm: pblk: implement 2.0 support Javier González
2018-02-21  9:26   ` Javier González
2018-02-21 14:30   ` Javier González
2018-02-21 14:30     ` Javier González

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1519205218-26994-15-git-send-email-javier@cnexlabs.com \
    --to=jg@lightnvm.io \
    --cc=javier@cnexlabs.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=mb@lightnvm.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.