All of lore.kernel.org
 help / color / mirror / Atom feed
From: Babu Moger <babu.moger@amd.com>
To: pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com,
	rkrcmar@redhat.com
Cc: Thomas.Lendacky@amd.com, brijesh.singh@amd.com,
	kvm@vger.kernel.org, kash@tripleback.net, mtosatti@redhat.com,
	Gary.Hook@amd.com, qemu-devel@nongnu.org, babu.moger@amd.com
Subject: [PATCH v4 4/5] target/i386: Enable TOPOEXT feature on AMD EPYC CPU
Date: Mon, 12 Mar 2018 17:00:48 -0400	[thread overview]
Message-ID: <1520888449-4352-5-git-send-email-babu.moger@amd.com> (raw)
In-Reply-To: <1520888449-4352-1-git-send-email-babu.moger@amd.com>

Enable TOPOEXT feature on EPYC CPU. This is required to support
hyperthreading on VM guests. Also extend xlevel to 0x8000001E.

Signed-off-by: Babu Moger <babu.moger@amd.com>
---
 target/i386/cpu.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index ba63d0c..ade272e 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -1955,7 +1955,8 @@ static X86CPUDefinition builtin_x86_defs[] = {
         .features[FEAT_8000_0001_ECX] =
             CPUID_EXT3_OSVW | CPUID_EXT3_3DNOWPREFETCH |
             CPUID_EXT3_MISALIGNSSE | CPUID_EXT3_SSE4A | CPUID_EXT3_ABM |
-            CPUID_EXT3_CR8LEG | CPUID_EXT3_SVM | CPUID_EXT3_LAHF_LM,
+            CPUID_EXT3_CR8LEG | CPUID_EXT3_SVM | CPUID_EXT3_LAHF_LM |
+            CPUID_EXT3_TOPOEXT,
         .features[FEAT_7_0_EBX] =
             CPUID_7_0_EBX_FSGSBASE | CPUID_7_0_EBX_BMI1 | CPUID_7_0_EBX_AVX2 |
             CPUID_7_0_EBX_SMEP | CPUID_7_0_EBX_BMI2 | CPUID_7_0_EBX_RDSEED |
@@ -1999,7 +2000,8 @@ static X86CPUDefinition builtin_x86_defs[] = {
         .features[FEAT_8000_0001_ECX] =
             CPUID_EXT3_OSVW | CPUID_EXT3_3DNOWPREFETCH |
             CPUID_EXT3_MISALIGNSSE | CPUID_EXT3_SSE4A | CPUID_EXT3_ABM |
-            CPUID_EXT3_CR8LEG | CPUID_EXT3_SVM | CPUID_EXT3_LAHF_LM,
+            CPUID_EXT3_CR8LEG | CPUID_EXT3_SVM | CPUID_EXT3_LAHF_LM |
+            CPUID_EXT3_TOPOEXT,
         .features[FEAT_8000_0008_EBX] =
             CPUID_8000_0008_EBX_IBPB,
         .features[FEAT_7_0_EBX] =
@@ -4113,6 +4115,11 @@ static void x86_cpu_expand_features(X86CPU *cpu, Error **errp)
         if (env->features[FEAT_8000_0001_ECX] & CPUID_EXT3_SVM) {
             x86_cpu_adjust_level(cpu, &env->cpuid_min_xlevel, 0x8000000A);
         }
+
+        /* TOPOEXT feature requires 0x8000001E */
+        if (env->features[FEAT_8000_0001_ECX] & CPUID_EXT3_TOPOEXT) {
+            x86_cpu_adjust_level(cpu, &env->cpuid_min_xlevel, 0x8000001E);
+        }
     }
 
     /* Set cpuid_*level* based on cpuid_min_*level, if not explicitly set */
-- 
1.8.3.1

WARNING: multiple messages have this Message-ID (diff)
From: Babu Moger <babu.moger@amd.com>
To: pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com,
	rkrcmar@redhat.com
Cc: mtosatti@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org,
	Gary.Hook@amd.com, Thomas.Lendacky@amd.com,
	brijesh.singh@amd.com, babu.moger@amd.com, kash@tripleback.net
Subject: [Qemu-devel] [PATCH v4 4/5] target/i386: Enable TOPOEXT feature on AMD EPYC CPU
Date: Mon, 12 Mar 2018 17:00:48 -0400	[thread overview]
Message-ID: <1520888449-4352-5-git-send-email-babu.moger@amd.com> (raw)
In-Reply-To: <1520888449-4352-1-git-send-email-babu.moger@amd.com>

Enable TOPOEXT feature on EPYC CPU. This is required to support
hyperthreading on VM guests. Also extend xlevel to 0x8000001E.

Signed-off-by: Babu Moger <babu.moger@amd.com>
---
 target/i386/cpu.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index ba63d0c..ade272e 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -1955,7 +1955,8 @@ static X86CPUDefinition builtin_x86_defs[] = {
         .features[FEAT_8000_0001_ECX] =
             CPUID_EXT3_OSVW | CPUID_EXT3_3DNOWPREFETCH |
             CPUID_EXT3_MISALIGNSSE | CPUID_EXT3_SSE4A | CPUID_EXT3_ABM |
-            CPUID_EXT3_CR8LEG | CPUID_EXT3_SVM | CPUID_EXT3_LAHF_LM,
+            CPUID_EXT3_CR8LEG | CPUID_EXT3_SVM | CPUID_EXT3_LAHF_LM |
+            CPUID_EXT3_TOPOEXT,
         .features[FEAT_7_0_EBX] =
             CPUID_7_0_EBX_FSGSBASE | CPUID_7_0_EBX_BMI1 | CPUID_7_0_EBX_AVX2 |
             CPUID_7_0_EBX_SMEP | CPUID_7_0_EBX_BMI2 | CPUID_7_0_EBX_RDSEED |
@@ -1999,7 +2000,8 @@ static X86CPUDefinition builtin_x86_defs[] = {
         .features[FEAT_8000_0001_ECX] =
             CPUID_EXT3_OSVW | CPUID_EXT3_3DNOWPREFETCH |
             CPUID_EXT3_MISALIGNSSE | CPUID_EXT3_SSE4A | CPUID_EXT3_ABM |
-            CPUID_EXT3_CR8LEG | CPUID_EXT3_SVM | CPUID_EXT3_LAHF_LM,
+            CPUID_EXT3_CR8LEG | CPUID_EXT3_SVM | CPUID_EXT3_LAHF_LM |
+            CPUID_EXT3_TOPOEXT,
         .features[FEAT_8000_0008_EBX] =
             CPUID_8000_0008_EBX_IBPB,
         .features[FEAT_7_0_EBX] =
@@ -4113,6 +4115,11 @@ static void x86_cpu_expand_features(X86CPU *cpu, Error **errp)
         if (env->features[FEAT_8000_0001_ECX] & CPUID_EXT3_SVM) {
             x86_cpu_adjust_level(cpu, &env->cpuid_min_xlevel, 0x8000000A);
         }
+
+        /* TOPOEXT feature requires 0x8000001E */
+        if (env->features[FEAT_8000_0001_ECX] & CPUID_EXT3_TOPOEXT) {
+            x86_cpu_adjust_level(cpu, &env->cpuid_min_xlevel, 0x8000001E);
+        }
     }
 
     /* Set cpuid_*level* based on cpuid_min_*level, if not explicitly set */
-- 
1.8.3.1

  parent reply	other threads:[~2018-03-12 21:00 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-12 21:00 [PATCH v4 0/5] Enable TOPOEXT to support hyperthreading on AMD CPU Babu Moger
2018-03-12 21:00 ` [Qemu-devel] " Babu Moger
2018-03-12 21:00 ` [PATCH v4 1/5] target/i386: Generalize some of the macro definitions Babu Moger
2018-03-12 21:00   ` [Qemu-devel] " Babu Moger
2018-03-15 19:07   ` Eduardo Habkost
2018-03-15 19:07     ` [Qemu-devel] " Eduardo Habkost
2018-03-12 21:00 ` [PATCH v4 2/5] target/i386: Populate AMD Processor Cache Information Babu Moger
2018-03-12 21:00   ` [Qemu-devel] " Babu Moger
2018-03-15 19:04   ` Eduardo Habkost
2018-03-15 19:04     ` [Qemu-devel] " Eduardo Habkost
2018-03-16 18:00   ` Eduardo Habkost
2018-03-16 18:00     ` [Qemu-devel] " Eduardo Habkost
2018-03-20 17:25     ` Moger, Babu
2018-03-20 17:25       ` [Qemu-devel] " Moger, Babu
2018-03-20 17:54       ` Eduardo Habkost
2018-03-20 17:54         ` [Qemu-devel] " Eduardo Habkost
2018-03-20 19:20         ` Moger, Babu
2018-03-20 19:20           ` [Qemu-devel] " Moger, Babu
2018-03-21 15:58         ` Moger, Babu
2018-03-21 15:58           ` [Qemu-devel] " Moger, Babu
2018-03-21 17:09           ` Eduardo Habkost
2018-03-21 17:09             ` [Qemu-devel] " Eduardo Habkost
2018-03-21 17:12             ` Kash Pande
2018-03-21 17:12               ` [Qemu-devel] " Kash Pande
2018-03-21 17:47             ` Moger, Babu
2018-03-21 17:47               ` [Qemu-devel] " Moger, Babu
2018-03-21 18:15               ` Eduardo Habkost
2018-03-21 18:15                 ` [Qemu-devel] " Eduardo Habkost
2018-03-21 20:07                 ` Moger, Babu
2018-03-21 20:07                   ` [Qemu-devel] " Moger, Babu
2018-03-21 20:29                   ` Eduardo Habkost
2018-03-21 20:29                     ` [Qemu-devel] " Eduardo Habkost
2018-03-27 21:36                     ` Moger, Babu
2018-03-27 21:36                       ` [Qemu-devel] " Moger, Babu
2018-03-12 21:00 ` [PATCH v4 3/5] target/i386: Add support for CPUID_8000_001E for AMD Babu Moger
2018-03-12 21:00   ` [Qemu-devel] " Babu Moger
2018-03-12 21:00 ` Babu Moger [this message]
2018-03-12 21:00   ` [Qemu-devel] [PATCH v4 4/5] target/i386: Enable TOPOEXT feature on AMD EPYC CPU Babu Moger
2018-03-12 21:00 ` [PATCH v4 5/5] target/i386: Remove generic SMT thread check Babu Moger
2018-03-12 21:00   ` [Qemu-devel] " Babu Moger
2018-03-13 21:39 ` [PATCH v4 0/5] Enable TOPOEXT to support hyperthreading on AMD CPU Kash Pande
2018-03-13 21:39   ` [Qemu-devel] " Kash Pande

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1520888449-4352-5-git-send-email-babu.moger@amd.com \
    --to=babu.moger@amd.com \
    --cc=Gary.Hook@amd.com \
    --cc=Thomas.Lendacky@amd.com \
    --cc=brijesh.singh@amd.com \
    --cc=ehabkost@redhat.com \
    --cc=kash@tripleback.net \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rkrcmar@redhat.com \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.