All of lore.kernel.org
 help / color / mirror / Atom feed
From: <twischer@de.adit-jv.com>
To: patch@alsa-project.org
Cc: Timo Wischer <twischer@de.adit-jv.com>, alsa-devel@alsa-project.org
Subject: [PATCH - JACK PCM 1/1] jack: Use correct parameter order for snd_pcm_areas_silence()
Date: Wed, 21 Mar 2018 12:42:32 +0100	[thread overview]
Message-ID: <1521632552-24858-1-git-send-email-twischer@de.adit-jv.com> (raw)

From: Timo Wischer <twischer@de.adit-jv.com>

Without this fix it will sometimes fail with a segmentation fault.

Signed-off-by: Timo Wischer <twischer@de.adit-jv.com>

diff --git a/jack/pcm_jack.c b/jack/pcm_jack.c
index a655668..e3df4d2 100644
--- a/jack/pcm_jack.c
+++ b/jack/pcm_jack.c
@@ -200,7 +200,7 @@ snd_pcm_jack_process_cb(jack_nframes_t nframes, snd_pcm_ioplug_t *io)
 		if (io->stream == SND_PCM_STREAM_PLAYBACK) {
 			const snd_pcm_uframes_t frames = nframes - xfer;
 
-			snd_pcm_areas_silence(jack->areas, io->channels, xfer,
+			snd_pcm_areas_silence(jack->areas, xfer, io->channels,
 					      frames, io->format);
 		}
 
-- 
2.7.4

             reply	other threads:[~2018-03-21 11:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-21 11:42 twischer [this message]
2018-03-21 12:11 ` [PATCH - JACK PCM 1/1] jack: Use correct parameter order for snd_pcm_areas_silence() Jaroslav Kysela
2018-03-21 13:07 ` Takashi Iwai
2018-03-21 13:09   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1521632552-24858-1-git-send-email-twischer@de.adit-jv.com \
    --to=twischer@de.adit-jv.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=patch@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.