All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: balbi@kernel.org
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org, stable@vger.kernel.org,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: [PATCH 2/4] usb: gadget: udc: renesas_usb3: should remove debugfs
Date: Mon,  2 Apr 2018 21:21:32 +0900	[thread overview]
Message-ID: <1522671694-10229-3-git-send-email-yoshihiro.shimoda.uh@renesas.com> (raw)
In-Reply-To: <1522671694-10229-1-git-send-email-yoshihiro.shimoda.uh@renesas.com>

This patch fixes an issue that this driver doesn't remove its debugfs.

Fixes: 43ba968b00ea ("usb: gadget: udc: renesas_usb3: add debugfs to set the b-device mode")
Cc: <stable@vger.kernel.org> # v4.14+
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
 drivers/usb/gadget/udc/renesas_usb3.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c
index 78a12a5..1c54a77 100644
--- a/drivers/usb/gadget/udc/renesas_usb3.c
+++ b/drivers/usb/gadget/udc/renesas_usb3.c
@@ -333,6 +333,7 @@ struct renesas_usb3 {
 	struct extcon_dev *extcon;
 	struct work_struct extcon_work;
 	struct phy *phy;
+	struct dentry *dentry;
 
 	struct renesas_usb3_ep *usb3_ep;
 	int num_usb3_eps;
@@ -2393,8 +2394,12 @@ static void renesas_usb3_debugfs_init(struct renesas_usb3 *usb3,
 
 	file = debugfs_create_file("b_device", 0644, root, usb3,
 				   &renesas_usb3_b_device_fops);
-	if (!file)
+	if (!file) {
 		dev_info(dev, "%s: Can't create debugfs mode\n", __func__);
+		debugfs_remove_recursive(root);
+	} else {
+		usb3->dentry = root;
+	}
 }
 
 /*------- platform_driver ------------------------------------------------*/
@@ -2402,6 +2407,7 @@ static int renesas_usb3_remove(struct platform_device *pdev)
 {
 	struct renesas_usb3 *usb3 = platform_get_drvdata(pdev);
 
+	debugfs_remove_recursive(usb3->dentry);
 	device_remove_file(&pdev->dev, &dev_attr_role);
 
 	usb_del_gadget_udc(&usb3->gadget);
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: balbi@kernel.org
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org, stable@vger.kernel.org,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: [2/4] usb: gadget: udc: renesas_usb3: should remove debugfs
Date: Mon,  2 Apr 2018 21:21:32 +0900	[thread overview]
Message-ID: <1522671694-10229-3-git-send-email-yoshihiro.shimoda.uh@renesas.com> (raw)

This patch fixes an issue that this driver doesn't remove its debugfs.

Fixes: 43ba968b00ea ("usb: gadget: udc: renesas_usb3: add debugfs to set the b-device mode")
Cc: <stable@vger.kernel.org> # v4.14+
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
 drivers/usb/gadget/udc/renesas_usb3.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c
index 78a12a5..1c54a77 100644
--- a/drivers/usb/gadget/udc/renesas_usb3.c
+++ b/drivers/usb/gadget/udc/renesas_usb3.c
@@ -333,6 +333,7 @@ struct renesas_usb3 {
 	struct extcon_dev *extcon;
 	struct work_struct extcon_work;
 	struct phy *phy;
+	struct dentry *dentry;
 
 	struct renesas_usb3_ep *usb3_ep;
 	int num_usb3_eps;
@@ -2393,8 +2394,12 @@ static void renesas_usb3_debugfs_init(struct renesas_usb3 *usb3,
 
 	file = debugfs_create_file("b_device", 0644, root, usb3,
 				   &renesas_usb3_b_device_fops);
-	if (!file)
+	if (!file) {
 		dev_info(dev, "%s: Can't create debugfs mode\n", __func__);
+		debugfs_remove_recursive(root);
+	} else {
+		usb3->dentry = root;
+	}
 }
 
 /*------- platform_driver ------------------------------------------------*/
@@ -2402,6 +2407,7 @@ static int renesas_usb3_remove(struct platform_device *pdev)
 {
 	struct renesas_usb3 *usb3 = platform_get_drvdata(pdev);
 
+	debugfs_remove_recursive(usb3->dentry);
 	device_remove_file(&pdev->dev, &dev_attr_role);
 
 	usb_del_gadget_udc(&usb3->gadget);

  parent reply	other threads:[~2018-04-02 12:21 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-02 12:21 [PATCH 0/4] usb: gadget: udc: renesas_usb3: fix some major issues Yoshihiro Shimoda
2018-04-02 12:21 ` [PATCH 1/4] usb: gadget: udc: renesas_usb3: fix double phy_put() Yoshihiro Shimoda
2018-04-02 12:21   ` [1/4] " Yoshihiro Shimoda
2018-04-05  1:34   ` [PATCH 1/4] " Sasha Levin
2018-04-05  1:34     ` [1/4] " Sasha Levin
2018-04-09 11:49   ` [PATCH 1/4] " Simon Horman
2018-04-09 11:49     ` [1/4] " Simon Horman
2018-04-02 12:21 ` Yoshihiro Shimoda [this message]
2018-04-02 12:21   ` [2/4] usb: gadget: udc: renesas_usb3: should remove debugfs Yoshihiro Shimoda
2018-04-05  1:34   ` [PATCH 2/4] " Sasha Levin
2018-04-05  1:34     ` [2/4] " Sasha Levin
2018-04-09 11:51   ` [PATCH 2/4] " Simon Horman
2018-04-09 11:51     ` [2/4] " Simon Horman
2018-04-02 12:21 ` [PATCH 3/4] usb: gadget: udc: renesas_usb3: should call pm_runtime_enable() before add udc Yoshihiro Shimoda
2018-04-02 12:21   ` [3/4] " Yoshihiro Shimoda
2018-04-05  1:34   ` [PATCH 3/4] " Sasha Levin
2018-04-05  1:34     ` [3/4] " Sasha Levin
2018-04-09 11:52   ` [PATCH 3/4] " Simon Horman
2018-04-09 11:52     ` [3/4] " Simon Horman
2018-04-02 12:21 ` [PATCH 4/4] usb: gadget: udc: renesas_usb3: should call devm_phy_get() " Yoshihiro Shimoda
2018-04-02 12:21   ` [4/4] " Yoshihiro Shimoda
2018-04-05  1:34   ` [PATCH 4/4] " Sasha Levin
2018-04-05  1:34     ` [4/4] " Sasha Levin
2018-04-09 11:58   ` [PATCH 4/4] " Simon Horman
2018-04-09 11:58     ` [4/4] " Simon Horman
2018-04-10  1:28     ` [PATCH 4/4] " Yoshihiro Shimoda
2018-04-10  1:28       ` [4/4] " Yoshihiro Shimoda
2018-04-10  9:33       ` [PATCH 4/4] " Simon Horman
2018-04-10  9:33         ` [4/4] " Simon Horman
2018-04-10  9:44         ` [PATCH 4/4] " Yoshihiro Shimoda
2018-04-10  9:44           ` [4/4] " Yoshihiro Shimoda
2018-04-11  7:04           ` [PATCH 4/4] " Simon Horman
2018-04-11  7:04             ` [4/4] " Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1522671694-10229-3-git-send-email-yoshihiro.shimoda.uh@renesas.com \
    --to=yoshihiro.shimoda.uh@renesas.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.