From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> To: balbi@kernel.org Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-renesas-soc@vger.kernel.org, stable@vger.kernel.org, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Subject: [PATCH 3/4] usb: gadget: udc: renesas_usb3: should call pm_runtime_enable() before add udc Date: Mon, 2 Apr 2018 21:21:33 +0900 [thread overview] Message-ID: <1522671694-10229-4-git-send-email-yoshihiro.shimoda.uh@renesas.com> (raw) In-Reply-To: <1522671694-10229-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> This patch fixes an issue that this driver causes panic if a gadget driver is already loaded because usb_add_gadget_udc() might call renesas_usb3_start() via .udc_start, and then pm_runtime_get_sync() in renesas_usb3_start() doesn't work correctly. Note that the usb3_to_dev() macro should not be called at this timing because the macro uses the gadget structure. Fixes: cf06df3fae28 ("usb: gadget: udc: renesas_usb3: move pm_runtime_{en,dis}able()") Cc: <stable@vger.kernel.org> # v4.15+ Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- drivers/usb/gadget/udc/renesas_usb3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c index 1c54a77..738b734 100644 --- a/drivers/usb/gadget/udc/renesas_usb3.c +++ b/drivers/usb/gadget/udc/renesas_usb3.c @@ -2632,6 +2632,7 @@ static int renesas_usb3_probe(struct platform_device *pdev) if (ret < 0) goto err_alloc_prd; + pm_runtime_enable(&pdev->dev); ret = usb_add_gadget_udc(&pdev->dev, &usb3->gadget); if (ret < 0) goto err_add_udc; @@ -2653,7 +2654,6 @@ static int renesas_usb3_probe(struct platform_device *pdev) renesas_usb3_debugfs_init(usb3, &pdev->dev); dev_info(&pdev->dev, "probed%s\n", usb3->phy ? " with phy" : ""); - pm_runtime_enable(usb3_to_dev(usb3)); return 0; -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> To: balbi@kernel.org Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-renesas-soc@vger.kernel.org, stable@vger.kernel.org, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Subject: [3/4] usb: gadget: udc: renesas_usb3: should call pm_runtime_enable() before add udc Date: Mon, 2 Apr 2018 21:21:33 +0900 [thread overview] Message-ID: <1522671694-10229-4-git-send-email-yoshihiro.shimoda.uh@renesas.com> (raw) This patch fixes an issue that this driver causes panic if a gadget driver is already loaded because usb_add_gadget_udc() might call renesas_usb3_start() via .udc_start, and then pm_runtime_get_sync() in renesas_usb3_start() doesn't work correctly. Note that the usb3_to_dev() macro should not be called at this timing because the macro uses the gadget structure. Fixes: cf06df3fae28 ("usb: gadget: udc: renesas_usb3: move pm_runtime_{en,dis}able()") Cc: <stable@vger.kernel.org> # v4.15+ Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- drivers/usb/gadget/udc/renesas_usb3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c index 1c54a77..738b734 100644 --- a/drivers/usb/gadget/udc/renesas_usb3.c +++ b/drivers/usb/gadget/udc/renesas_usb3.c @@ -2632,6 +2632,7 @@ static int renesas_usb3_probe(struct platform_device *pdev) if (ret < 0) goto err_alloc_prd; + pm_runtime_enable(&pdev->dev); ret = usb_add_gadget_udc(&pdev->dev, &usb3->gadget); if (ret < 0) goto err_add_udc; @@ -2653,7 +2654,6 @@ static int renesas_usb3_probe(struct platform_device *pdev) renesas_usb3_debugfs_init(usb3, &pdev->dev); dev_info(&pdev->dev, "probed%s\n", usb3->phy ? " with phy" : ""); - pm_runtime_enable(usb3_to_dev(usb3)); return 0;
next prev parent reply other threads:[~2018-04-02 12:21 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-02 12:21 [PATCH 0/4] usb: gadget: udc: renesas_usb3: fix some major issues Yoshihiro Shimoda 2018-04-02 12:21 ` [PATCH 1/4] usb: gadget: udc: renesas_usb3: fix double phy_put() Yoshihiro Shimoda 2018-04-02 12:21 ` [1/4] " Yoshihiro Shimoda 2018-04-05 1:34 ` [PATCH 1/4] " Sasha Levin 2018-04-05 1:34 ` [1/4] " Sasha Levin 2018-04-09 11:49 ` [PATCH 1/4] " Simon Horman 2018-04-09 11:49 ` [1/4] " Simon Horman 2018-04-02 12:21 ` [PATCH 2/4] usb: gadget: udc: renesas_usb3: should remove debugfs Yoshihiro Shimoda 2018-04-02 12:21 ` [2/4] " Yoshihiro Shimoda 2018-04-05 1:34 ` [PATCH 2/4] " Sasha Levin 2018-04-05 1:34 ` [2/4] " Sasha Levin 2018-04-09 11:51 ` [PATCH 2/4] " Simon Horman 2018-04-09 11:51 ` [2/4] " Simon Horman 2018-04-02 12:21 ` Yoshihiro Shimoda [this message] 2018-04-02 12:21 ` [3/4] usb: gadget: udc: renesas_usb3: should call pm_runtime_enable() before add udc Yoshihiro Shimoda 2018-04-05 1:34 ` [PATCH 3/4] " Sasha Levin 2018-04-05 1:34 ` [3/4] " Sasha Levin 2018-04-09 11:52 ` [PATCH 3/4] " Simon Horman 2018-04-09 11:52 ` [3/4] " Simon Horman 2018-04-02 12:21 ` [PATCH 4/4] usb: gadget: udc: renesas_usb3: should call devm_phy_get() " Yoshihiro Shimoda 2018-04-02 12:21 ` [4/4] " Yoshihiro Shimoda 2018-04-05 1:34 ` [PATCH 4/4] " Sasha Levin 2018-04-05 1:34 ` [4/4] " Sasha Levin 2018-04-09 11:58 ` [PATCH 4/4] " Simon Horman 2018-04-09 11:58 ` [4/4] " Simon Horman 2018-04-10 1:28 ` [PATCH 4/4] " Yoshihiro Shimoda 2018-04-10 1:28 ` [4/4] " Yoshihiro Shimoda 2018-04-10 9:33 ` [PATCH 4/4] " Simon Horman 2018-04-10 9:33 ` [4/4] " Simon Horman 2018-04-10 9:44 ` [PATCH 4/4] " Yoshihiro Shimoda 2018-04-10 9:44 ` [4/4] " Yoshihiro Shimoda 2018-04-11 7:04 ` [PATCH 4/4] " Simon Horman 2018-04-11 7:04 ` [4/4] " Simon Horman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1522671694-10229-4-git-send-email-yoshihiro.shimoda.uh@renesas.com \ --to=yoshihiro.shimoda.uh@renesas.com \ --cc=balbi@kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=stable@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.