All of lore.kernel.org
 help / color / mirror / Atom feed
From: clinton.a.taylor@intel.com
To: Intel-gfx@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [PATCH] drm/i915/edp: Only use alternate fixed mode when requested
Date: Tue, 10 Apr 2018 11:33:36 -0700	[thread overview]
Message-ID: <1523385216-31673-1-git-send-email-clinton.a.taylor@intel.com> (raw)

From: Clint Taylor <clinton.a.taylor@intel.com>

In commit dc911f5bd8aa ("drm/i915/edp: Allow alternate fixed mode for eDP
if available."), the patch was always selecting the alternate refresh rate
even though user space was asking for the higher rate. This patch adds a
check for vrefresh rate as well as the rest of the mode geometry.

Fixes: dc911f5bd8aac ("Allow alternate fixed mode for eDP if available.")
Cc: David Weinehall <david.weinehall@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>
---
 drivers/gpu/drm/i915/intel_dp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 62f82c4..c4c0e79 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -1681,7 +1681,8 @@ static bool intel_edp_compare_alt_mode(struct drm_display_mode *m1,
 			m1->vdisplay == m2->vdisplay &&
 			m1->vsync_start == m2->vsync_start &&
 			m1->vsync_end == m2->vsync_end &&
-			m1->vtotal == m2->vtotal);
+			m1->vtotal == m2->vtotal &&
+			m1->vrefresh == m2->vrefresh);
 	return bres;
 }
 
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2018-04-10 18:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-10 18:33 clinton.a.taylor [this message]
2018-04-10 18:46 ` ✗ Fi.CI.BAT: warning for drm/i915/edp: Only use alternate fixed mode when requested Patchwork
2018-04-10 20:19 ` [PATCH] " Chris Wilson
2018-04-10 20:40 ` ✗ Fi.CI.IGT: warning for " Patchwork
2018-04-11 23:13 ` [PATCH] " clinton.a.taylor
2018-04-11 23:11   ` Chris Wilson
2018-04-12 21:31     ` Clint Taylor
2018-04-14 17:57       ` Vivi, Rodrigo
2018-04-30  7:49         ` Jani Nikula
2018-04-30 21:54           ` Clint Taylor
2018-04-12  0:04 ` ✓ Fi.CI.BAT: success for drm/i915/edp: Only use alternate fixed mode when requested (rev2) Patchwork
2018-04-12  3:55 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-05-01  0:09 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/edp: Only use alternate fixed mode when requested (rev3) Patchwork
2018-05-01  0:11 ` [PATCH V3] drn/i915/edp: Only use alternate fixed mode when requested clinton.a.taylor
2018-05-02  7:22   ` Jani Nikula
2018-05-02 13:56     ` Rodrigo Vivi
2018-05-01  0:28 ` ✓ Fi.CI.BAT: success for drm/i915/edp: Only use alternate fixed mode when requested (rev3) Patchwork
2018-05-01  2:52 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1523385216-31673-1-git-send-email-clinton.a.taylor@intel.com \
    --to=clinton.a.taylor@intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.