From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> To: gregkh@linuxfoundation.org, robh+dt@kernel.org, mark.rutland@arm.com, frowand.list@gmail.com Cc: heikki.krogerus@linux.intel.com, hdegoede@redhat.com, andy.shevchenko@gmail.com, p.zabel@pengutronix.de, linux-usb@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Subject: [PATCH/RFC 06/11] usb: common: roles: Allow if the parent dev_name matches Date: Wed, 18 Apr 2018 17:10:00 +0900 [thread overview] Message-ID: <1524039005-30618-7-git-send-email-yoshihiro.shimoda.uh@renesas.com> (raw) In-Reply-To: <1524039005-30618-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> THis patch adds a condition in __switch_match() to allow if the parent dev_name matches. Otherwise, OF environment cannot match the usb role switch devices because the usb role switch framework adds the names of a new child device as the parent dev_name with "-role-switch". Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- drivers/usb/common/roles.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/usb/common/roles.c b/drivers/usb/common/roles.c index cc1c55a..381259c 100644 --- a/drivers/usb/common/roles.c +++ b/drivers/usb/common/roles.c @@ -88,7 +88,13 @@ enum usb_role usb_role_switch_get_role(struct usb_role_switch *sw) static int __switch_match(struct device *dev, const void *name) { - return !strcmp((const char *)name, dev_name(dev)); + int ret = !strcmp((const char *)name, dev_name(dev)); + + /* If doesn't match, this also checks the parent dev_name */ + if (!ret && dev->parent) + ret = !strcmp((const char *)name, dev_name(dev->parent)); + + return ret; } static void *usb_role_switch_match(struct device_connection *con, int ep, -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> To: gregkh@linuxfoundation.org, robh+dt@kernel.org, mark.rutland@arm.com, frowand.list@gmail.com Cc: heikki.krogerus@linux.intel.com, hdegoede@redhat.com, andy.shevchenko@gmail.com, p.zabel@pengutronix.de, linux-usb@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Subject: [PATCH/RFC,06/11] usb: common: roles: Allow if the parent dev_name matches Date: Wed, 18 Apr 2018 17:10:00 +0900 [thread overview] Message-ID: <1524039005-30618-7-git-send-email-yoshihiro.shimoda.uh@renesas.com> (raw) THis patch adds a condition in __switch_match() to allow if the parent dev_name matches. Otherwise, OF environment cannot match the usb role switch devices because the usb role switch framework adds the names of a new child device as the parent dev_name with "-role-switch". Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- drivers/usb/common/roles.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/usb/common/roles.c b/drivers/usb/common/roles.c index cc1c55a..381259c 100644 --- a/drivers/usb/common/roles.c +++ b/drivers/usb/common/roles.c @@ -88,7 +88,13 @@ enum usb_role usb_role_switch_get_role(struct usb_role_switch *sw) static int __switch_match(struct device *dev, const void *name) { - return !strcmp((const char *)name, dev_name(dev)); + int ret = !strcmp((const char *)name, dev_name(dev)); + + /* If doesn't match, this also checks the parent dev_name */ + if (!ret && dev->parent) + ret = !strcmp((const char *)name, dev_name(dev->parent)); + + return ret; } static void *usb_role_switch_match(struct device_connection *con, int ep,
next prev parent reply other threads:[~2018-04-18 8:10 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-18 8:09 [PATCH/RFC 00/11] add support for R-Car USB3.0 role switch Yoshihiro Shimoda 2018-04-18 8:09 ` [PATCH/RFC 01/11] Documentation: of: Add device-connection-id property Yoshihiro Shimoda 2018-04-18 8:09 ` [PATCH/RFC,01/11] " Yoshihiro Shimoda 2018-04-24 14:33 ` [PATCH/RFC 01/11] " Rob Herring 2018-04-24 14:33 ` [PATCH/RFC,01/11] " Rob Herring 2018-04-25 9:09 ` [PATCH/RFC 01/11] " Yoshihiro Shimoda 2018-04-25 9:09 ` [PATCH/RFC,01/11] " Yoshihiro Shimoda 2018-04-18 8:09 ` [PATCH/RFC 02/11] dt-bindings: usb: add usb role switch driver Yoshihiro Shimoda 2018-04-18 8:09 ` [PATCH/RFC,02/11] " Yoshihiro Shimoda 2018-04-24 14:35 ` [PATCH/RFC 02/11] " Rob Herring 2018-04-24 14:35 ` [PATCH/RFC,02/11] " Rob Herring 2018-04-18 8:09 ` [PATCH/RFC 03/11] dt-bindings: usb: add Renesas R-Car USB 3.0 " Yoshihiro Shimoda 2018-04-18 8:09 ` [PATCH/RFC,03/11] " Yoshihiro Shimoda 2018-04-18 8:09 ` [PATCH/RFC 04/11] of: platform: add device connection parsing Yoshihiro Shimoda 2018-04-18 8:09 ` [PATCH/RFC,04/11] " Yoshihiro Shimoda 2018-04-24 12:33 ` [PATCH/RFC 04/11] " Heikki Krogerus 2018-04-24 12:33 ` [PATCH/RFC,04/11] " Heikki Krogerus 2018-04-25 8:59 ` [PATCH/RFC 04/11] " Yoshihiro Shimoda 2018-04-25 8:59 ` [PATCH/RFC,04/11] " Yoshihiro Shimoda 2018-04-18 8:09 ` [PATCH/RFC 05/11] usb: common: roles: add fwnode graph parsing Yoshihiro Shimoda 2018-04-18 8:09 ` [PATCH/RFC,05/11] " Yoshihiro Shimoda 2018-04-18 8:10 ` Yoshihiro Shimoda [this message] 2018-04-18 8:10 ` [PATCH/RFC,06/11] usb: common: roles: Allow if the parent dev_name matches Yoshihiro Shimoda 2018-04-18 8:10 ` [PATCH/RFC 07/11] usb: common: roles: add getting device pointer APIs Yoshihiro Shimoda 2018-04-18 8:10 ` [PATCH/RFC,07/11] " Yoshihiro Shimoda 2018-04-18 8:10 ` [PATCH/RFC 08/11] usb: role: rcar-usb3-role-switch: add support for R-Car SoCs Yoshihiro Shimoda 2018-04-18 8:10 ` [PATCH/RFC,08/11] " Yoshihiro Shimoda 2018-04-18 8:47 ` [PATCH/RFC 08/11] " Geert Uytterhoeven 2018-04-18 8:47 ` [PATCH/RFC,08/11] " Geert Uytterhoeven 2018-04-18 8:10 ` [PATCH/RFC 09/11] usb: gadget: udc: renesas_usb3: add support for a usb role switch Yoshihiro Shimoda 2018-04-18 8:10 ` [PATCH/RFC,09/11] " Yoshihiro Shimoda 2018-04-18 8:10 ` [PATCH/RFC 10/11] arm64: dts: renesas: r8a7795: add OF graph for " Yoshihiro Shimoda 2018-04-18 8:10 ` [PATCH/RFC,10/11] " Yoshihiro Shimoda 2018-04-18 8:10 ` [PATCH/RFC 11/11] arm64: dts: renesas: r8a7795: salvator-xs: " Yoshihiro Shimoda 2018-04-18 8:10 ` [PATCH/RFC,11/11] " Yoshihiro Shimoda
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1524039005-30618-7-git-send-email-yoshihiro.shimoda.uh@renesas.com \ --to=yoshihiro.shimoda.uh@renesas.com \ --cc=andy.shevchenko@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=frowand.list@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=hdegoede@redhat.com \ --cc=heikki.krogerus@linux.intel.com \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=p.zabel@pengutronix.de \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.