All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Eduardo Valentin <edubezval@gmail.com>
Cc: Zhang Rui <rui.zhang@intel.com>,
	linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, b.zolnierkie@samsung.com
Subject: [PATCH 01/18] thermal: exynos: fix setting rising_threshold for Exynos5433
Date: Thu, 26 Apr 2018 13:51:16 +0200	[thread overview]
Message-ID: <1524743493-28113-2-git-send-email-b.zolnierkie@samsung.com> (raw)
In-Reply-To: <1524743493-28113-1-git-send-email-b.zolnierkie@samsung.com>

Add missing clearing of the previous value when setting rising
temperature threshold.

Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
 drivers/thermal/samsung/exynos_tmu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index cda716c..523d26e 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -577,6 +577,7 @@ static int exynos5433_tmu_initialize(struct platform_device *pdev)
 		threshold_code = temp_to_code(data, temp);
 
 		rising_threshold = readl(data->base + rising_reg_offset);
+		rising_threshold &= ~(0xff << j * 8);
 		rising_threshold |= (threshold_code << j * 8);
 		writel(rising_threshold, data->base + rising_reg_offset);
 
-- 
1.9.1

  parent reply	other threads:[~2018-04-26 11:52 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180426115159epcas2p3b8d995ba552b403b5052f74970fdef0f@epcas2p3.samsung.com>
2018-04-26 11:51 ` [PATCH 00/18] thermal: exynos: further fixes and cleanups Bartlomiej Zolnierkiewicz
     [not found]   ` <CGME20180426115201epcas2p17e5cdb0f79927903880e58c290b663e6@epcas2p1.samsung.com>
2018-04-26 11:51     ` Bartlomiej Zolnierkiewicz [this message]
2018-04-30 14:36       ` [PATCH 01/18] thermal: exynos: fix setting rising_threshold for Exynos5433 Daniel Lezcano
     [not found]         ` <CGME20180430152141eucas1p2f39d7e8ee83a1fa66ccd19f74442357f@eucas1p2.samsung.com>
2018-04-30 15:21           ` Bartlomiej Zolnierkiewicz
     [not found]   ` <CGME20180426115204epcas2p3a0b53d8b2bdd687b1acc19db98f30227@epcas2p3.samsung.com>
2018-04-26 11:51     ` [PATCH 02/18] thermal: exynos: always check for trips points existence Bartlomiej Zolnierkiewicz
     [not found]   ` <CGME20180426115206epcas1p2da6ae1d85708907dc99a97baf0791b4d@epcas1p2.samsung.com>
2018-04-26 11:51     ` [PATCH 03/18] thermal: exynos: always check for critical trip " Bartlomiej Zolnierkiewicz
2018-04-30 14:44       ` Daniel Lezcano
     [not found]         ` <CGME20180430152416eucas1p10bde2c1501e7f5f4b284caca3b630ea3@eucas1p1.samsung.com>
2018-04-30 15:24           ` Bartlomiej Zolnierkiewicz
2018-05-01  9:00             ` Daniel Lezcano
     [not found]               ` <CGME20180502091631eucas1p1e310f34a39383e01cfbf9eef992db260@eucas1p1.samsung.com>
2018-05-02  9:16                 ` Bartlomiej Zolnierkiewicz
     [not found]   ` <CGME20180426115209epcas2p1af89ecf3180a396261af3b18f952877a@epcas2p1.samsung.com>
2018-04-26 11:51     ` [PATCH 04/18] thermal: exynos: check STATUS register in exynos_tmu_initialize() Bartlomiej Zolnierkiewicz
2018-04-30 15:23       ` Daniel Lezcano
     [not found]   ` <CGME20180426115211epcas1p3db7cbe215a3dfb49567a771931574a2f@epcas1p3.samsung.com>
2018-04-26 11:51     ` [PATCH 05/18] thermal: exynos: use sanitize_temp_error() in exynos7_tmu_initialize() Bartlomiej Zolnierkiewicz
2018-04-30 15:30       ` Daniel Lezcano
     [not found]   ` <CGME20180426115214epcas2p33003bbbe84310405c6871853f0df40e3@epcas2p3.samsung.com>
2018-04-26 11:51     ` [PATCH 06/18] thermal: exynos: fix trips limit checking in get_th_reg() Bartlomiej Zolnierkiewicz
2018-04-30 15:34       ` Daniel Lezcano
     [not found]         ` <CGME20180430154830eucas1p20a5d8e1d4d50c60f8072ce022b6afb1d@eucas1p2.samsung.com>
2018-04-30 15:48           ` Bartlomiej Zolnierkiewicz
2018-05-01  9:39             ` Daniel Lezcano
     [not found]               ` <CGME20180502091907eucas1p17017c6793fb49f0c90660b3042b803bb@eucas1p1.samsung.com>
2018-05-02  9:19                 ` Bartlomiej Zolnierkiewicz
     [not found]   ` <CGME20180426115216epcas1p3ed61f0fd8563e7ea72f3d7d17c9c039f@epcas1p3.samsung.com>
2018-04-26 11:51     ` [PATCH 07/18] thermal: exynos: remove threshold_code checking from exynos4210_tmu_initialize() Bartlomiej Zolnierkiewicz
2018-04-30 15:37       ` Daniel Lezcano
     [not found]   ` <CGME20180426115219epcas2p48747814c37573e56473fe246955656fd@epcas2p4.samsung.com>
2018-04-26 11:51     ` [PATCH 08/18] thermal: exynos: make ->tmu_initialize method void Bartlomiej Zolnierkiewicz
2018-04-30 15:40       ` Daniel Lezcano
     [not found]   ` <CGME20180426115221epcas2p29faeae4b9bd5eb023e9696e2c33c01e9@epcas2p2.samsung.com>
2018-04-26 11:51     ` [PATCH 09/18] thermal: exynos: clear IRQs later in exynos4412_tmu_initialize() Bartlomiej Zolnierkiewicz
2018-04-30 14:47       ` Daniel Lezcano
     [not found]   ` <CGME20180426115224epcas1p3dde7044de7d11c7ec7a7411df1123552@epcas1p3.samsung.com>
2018-04-26 11:51     ` [PATCH 10/18] thermal: exynos: move IRQs clearing to exynos_tmu_initialize() Bartlomiej Zolnierkiewicz
2018-04-30 14:47       ` Daniel Lezcano
2018-05-06 23:27       ` Eduardo Valentin
     [not found]   ` <CGME20180426115226epcas1p2e902011524b5ef6e0b53c314b72f35e0@epcas1p2.samsung.com>
2018-04-26 11:51     ` [PATCH 11/18] thermal: exynos: add exynos*_tmu_set_[trip,hyst]() helpers Bartlomiej Zolnierkiewicz
2018-05-01  9:55       ` Daniel Lezcano
     [not found]         ` <CGME20180502093316eucas1p1e7e7b2f27eae677dde9882a4aedd2ed7@eucas1p1.samsung.com>
2018-05-02  9:33           ` Bartlomiej Zolnierkiewicz
     [not found]   ` <CGME20180426115229epcas1p42ebcc547531485a4f30284dd3be7e43a@epcas1p4.samsung.com>
2018-04-26 11:51     ` [PATCH 12/18] thermal: exynos: do not use trips structure directly in ->tmu_initialize Bartlomiej Zolnierkiewicz
2018-05-01  9:59       ` Daniel Lezcano
     [not found]   ` <CGME20180426115231epcas2p3727de5409903e05811c2b5ed10ee0a51@epcas2p3.samsung.com>
2018-04-26 11:51     ` [PATCH 13/18] thermal: exynos: set trips in ascending order in exynos7_tmu_initialize() Bartlomiej Zolnierkiewicz
2018-05-01 10:02       ` Daniel Lezcano
     [not found]         ` <CGME20180502093709eucas1p177dd30efffed16e763fcad10686af159@eucas1p1.samsung.com>
2018-05-02  9:37           ` Bartlomiej Zolnierkiewicz
     [not found]   ` <CGME20180426115234epcas1p47cf54556fd061e8f90a4df4a2c62f7ce@epcas1p4.samsung.com>
2018-04-26 11:51     ` [PATCH 14/18] thermal: exynos: move trips setting to exynos_tmu_initialize() Bartlomiej Zolnierkiewicz
2018-05-01 10:31       ` Daniel Lezcano
     [not found]         ` <CGME20180502093921eucas1p1c1da14cc87d3e2c7f5550b961004521d@eucas1p1.samsung.com>
2018-05-02  9:39           ` Bartlomiej Zolnierkiewicz
     [not found]   ` <CGME20180426115236epcas2p3764927b3c23113fb4c3771b753a51199@epcas2p3.samsung.com>
2018-04-26 11:51     ` [PATCH 15/18] thermal: exynos: check return values of ->get_trip_[temp,hyst] methods Bartlomiej Zolnierkiewicz
2018-05-01 10:43       ` Daniel Lezcano
     [not found]         ` <CGME20180502094143eucas1p282ea9e6519120d8eff473a7b3e1830ac@eucas1p2.samsung.com>
2018-05-02  9:41           ` Bartlomiej Zolnierkiewicz
     [not found]   ` <CGME20180426115239epcas2p2dc72353efa8375b7f70a41c570fba789@epcas2p2.samsung.com>
2018-04-26 11:51     ` [PATCH 16/18] thermal: exynos: cleanup code for enabling threshold interrupts Bartlomiej Zolnierkiewicz
2018-05-01 11:02       ` Daniel Lezcano
     [not found]         ` <CGME20180502100345eucas1p27280d10571f3e9d7c5b5a62a364dd439@eucas1p2.samsung.com>
2018-05-02 10:03           ` Bartlomiej Zolnierkiewicz
     [not found]             ` <CGME20180502110417eucas1p172aa0b68b5719dbebd2ed02baaf6a10a@eucas1p1.samsung.com>
2018-05-02 11:04               ` Bartlomiej Zolnierkiewicz
     [not found]   ` <CGME20180426115241epcas1p4472048bd1647d9151718f573e6f1025a@epcas1p4.samsung.com>
2018-04-26 11:51     ` [PATCH 17/18] thermal: exynos: remove unused defines for Exynos5433 Bartlomiej Zolnierkiewicz
2018-05-01 11:11       ` Daniel Lezcano
     [not found]         ` <CGME20180502100530eucas1p180d0b51059ca8002ffe9440810391e9a@eucas1p1.samsung.com>
2018-05-02 10:05           ` Bartlomiej Zolnierkiewicz
     [not found]   ` <CGME20180426115244epcas2p36d0d44d1a0b2c3c4edff33187046caac@epcas2p3.samsung.com>
2018-04-26 11:51     ` [PATCH 18/18] thermal: exynos: remove trip reporting to user-space Bartlomiej Zolnierkiewicz
2018-05-01 11:12       ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1524743493-28113-2-git-send-email-b.zolnierkie@samsung.com \
    --to=b.zolnierkie@samsung.com \
    --cc=edubezval@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.