All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: linux-block@vger.kernel.org, linux-xfs@vger.kernel.org
Cc: dchinner@redhat.com, hch@lst.de, Jens Axboe <axboe@kernel.dk>
Subject: [PATCH 2/4] blk-wbt: account any writing command as a write
Date: Mon,  7 May 2018 10:13:33 -0600	[thread overview]
Message-ID: <1525709615-14395-3-git-send-email-axboe@kernel.dk> (raw)
In-Reply-To: <1525709615-14395-1-git-send-email-axboe@kernel.dk>

We currently special case WRITE and FLUSH, but we should really
just include any command with the write bit set. This ensures
that we account DISCARD.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---
 block/blk-wbt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/blk-wbt.c b/block/blk-wbt.c
index f92fc84b5e2c..3e34b41bcefc 100644
--- a/block/blk-wbt.c
+++ b/block/blk-wbt.c
@@ -701,7 +701,7 @@ static int wbt_data_dir(const struct request *rq)
 
 	if (op == REQ_OP_READ)
 		return READ;
-	else if (op == REQ_OP_WRITE || op == REQ_OP_FLUSH)
+	else if (op_is_write(op))
 		return WRITE;
 
 	/* don't account */
-- 
2.7.4

  parent reply	other threads:[~2018-05-07 16:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-07 16:13 [PATCHSET v2 0/4] Add throttling for discards Jens Axboe
2018-05-07 16:13 ` [PATCH 1/4] block: break discard submissions into the user defined size Jens Axboe
2018-05-07 23:56   ` Darrick J. Wong
2018-05-08 20:43   ` Omar Sandoval
2018-05-08 20:57     ` Jens Axboe
2018-05-07 16:13 ` Jens Axboe [this message]
2018-05-07 23:58   ` [PATCH 2/4] blk-wbt: account any writing command as a write Darrick J. Wong
2018-05-08 20:44   ` Omar Sandoval
2018-05-07 16:13 ` [PATCH 3/4] blk-wbt: pass in enum wbt_flags to get_rq_wait() Jens Axboe
2018-05-08  0:07   ` Darrick J. Wong
2018-05-08 20:46   ` Omar Sandoval
2018-05-07 16:13 ` [PATCH 4/4] blk-wbt: throttle discards like background writes Jens Axboe
2018-05-08  0:13   ` Darrick J. Wong
2018-05-08 20:48   ` Omar Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1525709615-14395-3-git-send-email-axboe@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=dchinner@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.