All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: linux-kbuild@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
	Nicholas Piggin <npiggin@gmail.com>,
	"Luis R . Rodriguez" <mcgrof@suse.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Ulf Magnusson <ulfalizer@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Masahiro Yamada <yamada.masahiro@socionext.com>
Subject: [PATCH v5 14/31] kconfig: support append assignment operator
Date: Mon, 28 May 2018 18:21:51 +0900	[thread overview]
Message-ID: <1527499328-13213-15-git-send-email-yamada.masahiro@socionext.com> (raw)
In-Reply-To: <1527499328-13213-1-git-send-email-yamada.masahiro@socionext.com>

Support += operator.  This appends a space and the text on the
righthand side to a variable.

The timing of the evaluation of the righthand side depends on the
flavor of the variable.  If the lefthand side was originally defined
as a simple variable, the righthand side is expanded immediately.
Otherwise, the expansion is deferred.  Appending something to an
undefined variable results in a recursive variable.

To implement this, we need to remember the flavor of variables.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

Changes in v5: None
Changes in v4: None
Changes in v3:
  - newly added

Changes in v2: None

 scripts/kconfig/lkc_proto.h  |  1 +
 scripts/kconfig/preprocess.c | 28 +++++++++++++++++++++++++---
 scripts/kconfig/zconf.l      |  1 +
 3 files changed, 27 insertions(+), 3 deletions(-)

diff --git a/scripts/kconfig/lkc_proto.h b/scripts/kconfig/lkc_proto.h
index 6303193..a8b7a33 100644
--- a/scripts/kconfig/lkc_proto.h
+++ b/scripts/kconfig/lkc_proto.h
@@ -52,6 +52,7 @@ const char * prop_get_type_name(enum prop_type type);
 enum variable_flavor {
 	VAR_SIMPLE,
 	VAR_RECURSIVE,
+	VAR_APPEND,
 };
 void env_write_dep(FILE *f, const char *auto_conf_name);
 void variable_add(const char *name, const char *value,
diff --git a/scripts/kconfig/preprocess.c b/scripts/kconfig/preprocess.c
index d103683..56aa1f0 100644
--- a/scripts/kconfig/preprocess.c
+++ b/scripts/kconfig/preprocess.c
@@ -222,11 +222,23 @@ void variable_add(const char *name, const char *value,
 		  enum variable_flavor flavor)
 {
 	struct variable *v;
+	char *new_value;
+	bool append = false;
 
 	v = variable_lookup(name);
 	if (v) {
-		free(v->value);
+		/* For defined variables, += inherits the existing flavor */
+		if (flavor == VAR_APPEND) {
+			flavor = v->flavor;
+			append = true;
+		} else {
+			free(v->value);
+		}
 	} else {
+		/* For undefined variables, += assumes the recursive flavor */
+		if (flavor == VAR_APPEND)
+			flavor = VAR_RECURSIVE;
+
 		v = xmalloc(sizeof(*v));
 		v->name = xstrdup(name);
 		list_add_tail(&v->node, &variable_list);
@@ -235,9 +247,19 @@ void variable_add(const char *name, const char *value,
 	v->flavor = flavor;
 
 	if (flavor == VAR_SIMPLE)
-		v->value = expand_string(value);
+		new_value = expand_string(value);
 	else
-		v->value = xstrdup(value);
+		new_value = xstrdup(value);
+
+	if (append) {
+		v->value = xrealloc(v->value,
+				    strlen(v->value) + strlen(new_value) + 2);
+		strcat(v->value, " ");
+		strcat(v->value, new_value);
+		free(new_value);
+	} else {
+		v->value = new_value;
+	}
 }
 
 static void variable_del(struct variable *v)
diff --git a/scripts/kconfig/zconf.l b/scripts/kconfig/zconf.l
index 376af6c..a6cbe2d 100644
--- a/scripts/kconfig/zconf.l
+++ b/scripts/kconfig/zconf.l
@@ -116,6 +116,7 @@ n	[A-Za-z0-9_-]
 	}
 	"="	{ BEGIN(ASSIGN_VAL); yylval.flavor = VAR_RECURSIVE; return T_ASSIGN; }
 	":="	{ BEGIN(ASSIGN_VAL); yylval.flavor = VAR_SIMPLE; return T_ASSIGN; }
+	"+="	{ BEGIN(ASSIGN_VAL); yylval.flavor = VAR_APPEND; return T_ASSIGN; }
 	[[:blank:]]+
 	.	warn_ignored_character(*yytext);
 	\n	{
-- 
2.7.4

  parent reply	other threads:[~2018-05-28  9:30 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-28  9:21 [PATCH v5 00/31] kconfig: move compiler capability tests to Kconfig Masahiro Yamada
2018-05-28  9:21 ` [PATCH v5 01/31] kbuild: remove kbuild cache Masahiro Yamada
2018-05-28  9:21 ` [PATCH v5 02/31] kbuild: remove CONFIG_CROSS_COMPILE support Masahiro Yamada
2018-05-28  9:21 ` [PATCH v5 03/31] kconfig: reference environment variables directly and remove 'option env=' Masahiro Yamada
2018-06-08 17:53   ` [v5, " Andrei Vagin
2018-05-28  9:21 ` [PATCH v5 04/31] kconfig: remove string expansion in file_lookup() Masahiro Yamada
2018-05-28  9:21 ` [PATCH v5 05/31] kconfig: remove string expansion for mainmenu after yyparse() Masahiro Yamada
2018-05-28  9:21 ` [PATCH v5 06/31] kconfig: remove sym_expand_string_value() Masahiro Yamada
2018-05-28  9:21 ` [PATCH v5 07/31] kconfig: make default prompt of mainmenu less specific Masahiro Yamada
2018-05-28  9:21 ` [PATCH v5 08/31] kconfig: add built-in function support Masahiro Yamada
2018-05-28  9:21 ` [PATCH v5 09/31] kconfig: add 'shell' built-in function Masahiro Yamada
2018-05-28  9:21 ` [PATCH v5 10/31] kconfig: replace $(UNAME_RELEASE) with function call Masahiro Yamada
2018-05-28  9:21 ` [PATCH v5 11/31] kconfig: begin PARAM state only when seeing a command keyword Masahiro Yamada
2018-05-28  9:21 ` [PATCH v5 12/31] kconfig: support user-defined function and recursively expanded variable Masahiro Yamada
2018-05-28  9:21 ` [PATCH v5 13/31] kconfig: support simply " Masahiro Yamada
2018-05-28  9:21 ` Masahiro Yamada [this message]
2018-05-28  9:21 ` [PATCH v5 15/31] kconfig: expand lefthand side of assignment statement Masahiro Yamada
2018-05-28  9:21 ` [PATCH v5 16/31] kconfig: add 'info', 'warning-if', and 'error-if' built-in functions Masahiro Yamada
2018-05-28  9:21 ` [PATCH v5 17/31] kconfig: add 'filename' and 'lineno' built-in variables Masahiro Yamada
2018-05-28  9:21 ` [PATCH v5 18/31] kconfig: error out if a recursive variable references itself Masahiro Yamada
2018-05-28  9:21 ` [PATCH v5 19/31] Documentation: kconfig: document a new Kconfig macro language Masahiro Yamada
2018-05-28  9:21 ` [PATCH v5 20/31] kconfig: test: add Kconfig macro language tests Masahiro Yamada
2018-05-28  9:21 ` [PATCH v5 21/31] kconfig: show compiler version text in the top comment Masahiro Yamada
2018-06-07  8:42   ` Geert Uytterhoeven
2018-06-07  8:58     ` Masahiro Yamada
2018-06-08  7:04       ` Masahiro Yamada
2018-06-08  8:22         ` Geert Uytterhoeven
2018-05-28  9:21 ` [PATCH v5 22/31] kconfig: add basic helper macros to scripts/Kconfig.include Masahiro Yamada
2018-05-28  9:22 ` [PATCH v5 23/31] stack-protector: test compiler capability in Kconfig and drop AUTO mode Masahiro Yamada
2018-05-28  9:22 ` [PATCH v5 24/31] kconfig: add CC_IS_GCC and GCC_VERSION Masahiro Yamada
2018-06-04 21:49   ` Stefan Agner
2018-06-05  0:07     ` Masahiro Yamada
2018-06-05  5:50       ` Stefan Agner
2018-06-05  6:27         ` Masahiro Yamada
2018-06-05  8:37           ` Stefan Agner
2018-05-28  9:22 ` [PATCH v5 25/31] kconfig: add CC_IS_CLANG and CLANG_VERSION Masahiro Yamada
2018-05-28  9:22 ` [PATCH v5 26/31] gcov: remove CONFIG_GCOV_FORMAT_AUTODETECT Masahiro Yamada
2018-05-28  9:22 ` [PATCH v5 27/31] kcov: test compiler capability in Kconfig and correct dependency Masahiro Yamada
2018-06-10 14:19   ` Masahiro Yamada
2018-05-28  9:22 ` [PATCH v5 28/31] gcc-plugins: move GCC version check for PowerPC to Kconfig Masahiro Yamada
2018-05-28  9:22 ` [PATCH v5 29/31] gcc-plugins: test plugin support in Kconfig and clean up Makefile Masahiro Yamada
2018-05-28  9:22 ` [PATCH v5 30/31] gcc-plugins: allow to enable GCC_PLUGINS for COMPILE_TEST Masahiro Yamada
2018-05-28  9:22 ` [PATCH v5 31/31] Documentation: kconfig: add recommended way to describe compiler support Masahiro Yamada
2018-05-28 12:23 ` [PATCH v5 00/31] kconfig: move compiler capability tests to Kconfig Masahiro Yamada
2018-05-30  0:38   ` Masahiro Yamada
2018-06-01  8:31     ` Arnd Bergmann
2018-06-01 10:29       ` Masahiro Yamada
2018-06-01 11:09         ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1527499328-13213-15-git-send-email-yamada.masahiro@socionext.com \
    --to=yamada.masahiro@socionext.com \
    --cc=keescook@chromium.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@suse.com \
    --cc=npiggin@gmail.com \
    --cc=rdunlap@infradead.org \
    --cc=sam@ravnborg.org \
    --cc=torvalds@linux-foundation.org \
    --cc=ulfalizer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.