From: Dan Williams <dan.j.williams@intel.com> To: linux-nvdimm@lists.01.org Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, jack@suse.cz, hch@lst.de Subject: [PATCH v2 04/11] device-dax: Set page->index Date: Sat, 02 Jun 2018 22:23:05 -0700 [thread overview] Message-ID: <152800338510.17112.13056836346500332623.stgit@dwillia2-desk3.amr.corp.intel.com> (raw) In-Reply-To: <152800336321.17112.3300876636370683279.stgit@dwillia2-desk3.amr.corp.intel.com> In support of enabling memory_failure() handling for device-dax mappings, set ->index to the pgoff of the page. The rmap implementation requires ->index to bound the search through the vma interval tree. The ->index value is never cleared. There is no possibility for the page to become associated with another pgoff while the device is enabled. When the device is disabled the 'struct page' array for the device is destroyed and ->index is reinitialized to zero. Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- drivers/dax/device.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/dax/device.c b/drivers/dax/device.c index f7e926f4ec12..499299e36ee2 100644 --- a/drivers/dax/device.c +++ b/drivers/dax/device.c @@ -418,6 +418,7 @@ static vm_fault_t dev_dax_huge_fault(struct vm_fault *vmf, if (rc == VM_FAULT_NOPAGE) { unsigned long i; + pgoff_t pgoff; /* * In the device-dax case the only possibility for a @@ -425,6 +426,8 @@ static vm_fault_t dev_dax_huge_fault(struct vm_fault *vmf, * mapped. No need to consider the zero page, or racing * conflicting mappings. */ + pgoff = linear_page_index(vma, vmf->address + & ~(fault_size - 1)); for (i = 0; i < fault_size / PAGE_SIZE; i++) { struct page *page; @@ -432,6 +435,7 @@ static vm_fault_t dev_dax_huge_fault(struct vm_fault *vmf, if (page->mapping) continue; page->mapping = filp->f_mapping; + page->index = pgoff + i; } } dax_read_unlock(id); _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com> To: linux-nvdimm@lists.01.org Cc: hch@lst.de, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, jack@suse.cz Subject: [PATCH v2 04/11] device-dax: Set page->index Date: Sat, 02 Jun 2018 22:23:05 -0700 [thread overview] Message-ID: <152800338510.17112.13056836346500332623.stgit@dwillia2-desk3.amr.corp.intel.com> (raw) In-Reply-To: <152800336321.17112.3300876636370683279.stgit@dwillia2-desk3.amr.corp.intel.com> In support of enabling memory_failure() handling for device-dax mappings, set ->index to the pgoff of the page. The rmap implementation requires ->index to bound the search through the vma interval tree. The ->index value is never cleared. There is no possibility for the page to become associated with another pgoff while the device is enabled. When the device is disabled the 'struct page' array for the device is destroyed and ->index is reinitialized to zero. Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- drivers/dax/device.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/dax/device.c b/drivers/dax/device.c index f7e926f4ec12..499299e36ee2 100644 --- a/drivers/dax/device.c +++ b/drivers/dax/device.c @@ -418,6 +418,7 @@ static vm_fault_t dev_dax_huge_fault(struct vm_fault *vmf, if (rc == VM_FAULT_NOPAGE) { unsigned long i; + pgoff_t pgoff; /* * In the device-dax case the only possibility for a @@ -425,6 +426,8 @@ static vm_fault_t dev_dax_huge_fault(struct vm_fault *vmf, * mapped. No need to consider the zero page, or racing * conflicting mappings. */ + pgoff = linear_page_index(vma, vmf->address + & ~(fault_size - 1)); for (i = 0; i < fault_size / PAGE_SIZE; i++) { struct page *page; @@ -432,6 +435,7 @@ static vm_fault_t dev_dax_huge_fault(struct vm_fault *vmf, if (page->mapping) continue; page->mapping = filp->f_mapping; + page->index = pgoff + i; } } dax_read_unlock(id);
next prev parent reply other threads:[~2018-06-03 5:33 UTC|newest] Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-06-03 5:22 [PATCH v2 00/11] mm: Teach memory_failure() about ZONE_DEVICE pages Dan Williams 2018-06-03 5:22 ` Dan Williams 2018-06-03 5:22 ` Dan Williams 2018-06-03 5:22 ` [PATCH v2 01/11] device-dax: Convert to vmf_insert_mixed and vm_fault_t Dan Williams 2018-06-03 5:22 ` Dan Williams 2018-06-03 5:22 ` [PATCH v2 02/11] device-dax: Cleanup vm_fault de-reference chains Dan Williams 2018-06-03 5:22 ` Dan Williams 2018-06-03 5:22 ` [PATCH v2 03/11] device-dax: Enable page_mapping() Dan Williams 2018-06-03 5:22 ` Dan Williams 2018-06-03 5:23 ` Dan Williams [this message] 2018-06-03 5:23 ` [PATCH v2 04/11] device-dax: Set page->index Dan Williams 2018-06-03 5:23 ` [PATCH v2 05/11] filesystem-dax: " Dan Williams 2018-06-03 5:23 ` Dan Williams 2018-06-03 5:23 ` Dan Williams 2018-06-03 5:23 ` [PATCH v2 06/11] mm, madvise_inject_error: Let memory_failure() optionally take a page reference Dan Williams 2018-06-03 5:23 ` Dan Williams 2018-06-03 5:23 ` [PATCH v2 07/11] x86, memory_failure: Introduce {set, clear}_mce_nospec() Dan Williams 2018-06-03 5:23 ` Dan Williams 2018-06-03 5:23 ` [v2,07/11] " Dan Williams 2018-06-04 17:08 ` [PATCH v2 07/11] " Luck, Tony 2018-06-04 17:08 ` [v2,07/11] " Luck, Tony 2018-06-04 17:39 ` [PATCH v2 07/11] " Dan Williams 2018-06-04 17:39 ` Dan Williams 2018-06-04 17:39 ` [v2,07/11] " Dan Williams 2018-06-04 18:08 ` [PATCH v2 07/11] " Luck, Tony 2018-06-04 18:08 ` Luck, Tony 2018-06-04 18:08 ` [v2,07/11] " Luck, Tony 2018-06-04 18:35 ` [PATCH v2 07/11] " Dan Williams 2018-06-04 18:35 ` Dan Williams 2018-06-04 18:35 ` [v2,07/11] " Dan Williams 2018-06-03 5:23 ` [PATCH v2 08/11] mm, memory_failure: Pass page size to kill_proc() Dan Williams 2018-06-03 5:23 ` Dan Williams 2018-06-03 5:23 ` [PATCH v2 09/11] mm, memory_failure: Fix page->mapping assumptions relative to the page lock Dan Williams 2018-06-03 5:23 ` Dan Williams 2018-06-03 5:23 ` [PATCH v2 10/11] mm, memory_failure: Teach memory_failure() about dev_pagemap pages Dan Williams 2018-06-03 5:23 ` Dan Williams 2018-06-03 5:23 ` Dan Williams 2018-06-03 5:23 ` [PATCH v2 11/11] libnvdimm, pmem: Restore page attributes when clearing errors Dan Williams 2018-06-03 5:23 ` Dan Williams 2018-06-04 12:40 ` [PATCH v2 00/11] mm: Teach memory_failure() about ZONE_DEVICE pages Michal Hocko 2018-06-04 12:40 ` Michal Hocko 2018-06-04 14:31 ` Dan Williams 2018-06-04 14:31 ` Dan Williams 2018-06-05 14:11 ` Michal Hocko 2018-06-05 14:11 ` Michal Hocko 2018-06-05 14:33 ` Dan Williams 2018-06-05 14:33 ` Dan Williams 2018-06-06 7:39 ` Michal Hocko 2018-06-06 7:39 ` Michal Hocko 2018-06-06 13:44 ` Dan Williams 2018-06-06 13:44 ` Dan Williams 2018-06-07 14:37 ` Michal Hocko 2018-06-07 14:37 ` Michal Hocko 2018-06-07 16:52 ` Dan Williams 2018-06-07 16:52 ` Dan Williams 2018-06-11 7:50 ` Michal Hocko 2018-06-11 7:50 ` Michal Hocko 2018-06-11 14:44 ` Dan Williams 2018-06-11 14:44 ` Dan Williams 2018-06-11 14:56 ` Michal Hocko 2018-06-11 14:56 ` Michal Hocko 2018-06-11 15:19 ` Dan Williams 2018-06-11 15:19 ` Dan Williams 2018-06-11 17:35 ` Andi Kleen 2018-06-11 17:35 ` Andi Kleen 2018-06-12 1:50 ` Naoya Horiguchi 2018-06-12 1:58 ` Dan Williams 2018-06-12 1:58 ` Dan Williams 2018-06-12 4:04 ` Jane Chu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=152800338510.17112.13056836346500332623.stgit@dwillia2-desk3.amr.corp.intel.com \ --to=dan.j.williams@intel.com \ --cc=hch@lst.de \ --cc=jack@suse.cz \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-nvdimm@lists.01.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.