All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Yongjun <weiyongjun1@huawei.com>
To: Trond Myklebust <trond.myklebust@hammerspace.com>,
	Anna Schumaker <anna.schumaker@netapp.com>,
	Fred Isaman <fred.isaman@gmail.com>
Cc: Wei Yongjun <weiyongjun1@huawei.com>,
	linux-nfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH -next] pnfs: Use GFP_ATOMIC under spin lock
Date: Wed, 06 Jun 2018 01:55:55 +0000	[thread overview]
Message-ID: <1528250538-50721-1-git-send-email-weiyongjun1@huawei.com> (raw)

A spin lock is taken here so we should use GFP_ATOMIC.

Fixes: 2409a976a299 ("pnfs: Add LAYOUTGET to OPEN of a new file")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 fs/nfs/pnfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
index d93942f..1ff1998 100644
--- a/fs/nfs/pnfs.c
+++ b/fs/nfs/pnfs.c
@@ -2009,7 +2009,7 @@ struct pnfs_layout_segment *
 	struct pnfs_layout_hdr *lo;
 
 	spin_lock(&ino->i_lock);
-	lo = pnfs_find_alloc_layout(ino, ctx, GFP_KERNEL);
+	lo = pnfs_find_alloc_layout(ino, ctx, GFP_ATOMIC);
 	if (!lo)
 		goto out_unlock;
 	if (!test_bit(NFS_LAYOUT_INVALID_STID, &lo->plh_flags))


WARNING: multiple messages have this Message-ID (diff)
From: Wei Yongjun <weiyongjun1@huawei.com>
To: Trond Myklebust <trond.myklebust@hammerspace.com>,
	Anna Schumaker <anna.schumaker@netapp.com>,
	Fred Isaman <fred.isaman@gmail.com>
Cc: Wei Yongjun <weiyongjun1@huawei.com>, <linux-nfs@vger.kernel.org>,
	<kernel-janitors@vger.kernel.org>
Subject: [PATCH -next] pnfs: Use GFP_ATOMIC under spin lock
Date: Wed, 6 Jun 2018 02:02:18 +0000	[thread overview]
Message-ID: <1528250538-50721-1-git-send-email-weiyongjun1@huawei.com> (raw)

A spin lock is taken here so we should use GFP_ATOMIC.

Fixes: 2409a976a299 ("pnfs: Add LAYOUTGET to OPEN of a new file")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 fs/nfs/pnfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
index d93942f..1ff1998 100644
--- a/fs/nfs/pnfs.c
+++ b/fs/nfs/pnfs.c
@@ -2009,7 +2009,7 @@ struct pnfs_layout_segment *
 	struct pnfs_layout_hdr *lo;
 
 	spin_lock(&ino->i_lock);
-	lo = pnfs_find_alloc_layout(ino, ctx, GFP_KERNEL);
+	lo = pnfs_find_alloc_layout(ino, ctx, GFP_ATOMIC);
 	if (!lo)
 		goto out_unlock;
 	if (!test_bit(NFS_LAYOUT_INVALID_STID, &lo->plh_flags))


             reply	other threads:[~2018-06-06  1:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-06  1:55 Wei Yongjun [this message]
2018-06-06  2:02 ` [PATCH -next] pnfs: Use GFP_ATOMIC under spin lock Wei Yongjun
2018-06-06  2:21 ` Trond Myklebust
2018-06-06  2:21   ` Trond Myklebust
2018-06-06  3:01   ` weiyongjun (A)
2018-06-06  3:01     ` weiyongjun (A)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1528250538-50721-1-git-send-email-weiyongjun1@huawei.com \
    --to=weiyongjun1@huawei.com \
    --cc=anna.schumaker@netapp.com \
    --cc=fred.isaman@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.