From: Dan Williams <dan.j.williams@intel.com> To: akpm@linux-foundation.org Cc: "Jérôme Glisse" <jglisse@redhat.com>, "Logan Gunthorpe" <logang@deltatee.com>, "Christoph Hellwig" <hch@lst.de>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 7/8] mm, hmm: Mark hmm_devmem_{add, add_resource} EXPORT_SYMBOL_GPL Date: Mon, 18 Jun 2018 23:05:15 -0700 [thread overview] Message-ID: <152938831573.17797.15264540938029137916.stgit@dwillia2-desk3.amr.corp.intel.com> (raw) In-Reply-To: <152938827880.17797.439879736804291936.stgit@dwillia2-desk3.amr.corp.intel.com> The routines hmm_devmem_add(), and hmm_devmem_add_resource() are now wrappers around the functionality provided by devm_memremap_pages() to inject a dev_pagemap instance and hook page-idle events. The devm_memremap_pages() interface is base infrastructure for HMM which has more and deeper ties into the kernel memory management implementation than base ZONE_DEVICE. Originally, the HMM page structure creation routines copied the devm_memremap_pages() code and reused ZONE_DEVICE. A cleanup to unify the implementations was discussed during the initial review: http://lkml.iu.edu/hypermail/linux/kernel/1701.2/00812.html Given that devm_memremap_pages() is marked EXPORT_SYMBOL_GPL by its authors and the hmm_devmem_{add,add_resource} routines are simple wrappers around that base, mark these routines as EXPORT_SYMBOL_GPL as well. Cc: "Jérôme Glisse" <jglisse@redhat.com> Cc: Logan Gunthorpe <logang@deltatee.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- mm/hmm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/hmm.c b/mm/hmm.c index b019d67a610e..481a7a5f6f46 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -1054,7 +1054,7 @@ struct hmm_devmem *hmm_devmem_add(const struct hmm_devmem_ops *ops, return result; return devmem; } -EXPORT_SYMBOL(hmm_devmem_add); +EXPORT_SYMBOL_GPL(hmm_devmem_add); struct hmm_devmem *hmm_devmem_add_resource(const struct hmm_devmem_ops *ops, struct device *device, @@ -1108,7 +1108,7 @@ struct hmm_devmem *hmm_devmem_add_resource(const struct hmm_devmem_ops *ops, return result; return devmem; } -EXPORT_SYMBOL(hmm_devmem_add_resource); +EXPORT_SYMBOL_GPL(hmm_devmem_add_resource); /* * A device driver that wants to handle multiple devices memory through a
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com> To: akpm@linux-foundation.org Cc: "Jérôme Glisse" <jglisse@redhat.com>, "Logan Gunthorpe" <logang@deltatee.com>, "Christoph Hellwig" <hch@lst.de>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 7/8] mm, hmm: Mark hmm_devmem_{add, add_resource} EXPORT_SYMBOL_GPL Date: Mon, 18 Jun 2018 23:05:15 -0700 [thread overview] Message-ID: <152938831573.17797.15264540938029137916.stgit@dwillia2-desk3.amr.corp.intel.com> (raw) In-Reply-To: <152938827880.17797.439879736804291936.stgit@dwillia2-desk3.amr.corp.intel.com> The routines hmm_devmem_add(), and hmm_devmem_add_resource() are now wrappers around the functionality provided by devm_memremap_pages() to inject a dev_pagemap instance and hook page-idle events. The devm_memremap_pages() interface is base infrastructure for HMM which has more and deeper ties into the kernel memory management implementation than base ZONE_DEVICE. Originally, the HMM page structure creation routines copied the devm_memremap_pages() code and reused ZONE_DEVICE. A cleanup to unify the implementations was discussed during the initial review: http://lkml.iu.edu/hypermail/linux/kernel/1701.2/00812.html Given that devm_memremap_pages() is marked EXPORT_SYMBOL_GPL by its authors and the hmm_devmem_{add,add_resource} routines are simple wrappers around that base, mark these routines as EXPORT_SYMBOL_GPL as well. Cc: "JA(C)rA'me Glisse" <jglisse@redhat.com> Cc: Logan Gunthorpe <logang@deltatee.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- mm/hmm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/hmm.c b/mm/hmm.c index b019d67a610e..481a7a5f6f46 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -1054,7 +1054,7 @@ struct hmm_devmem *hmm_devmem_add(const struct hmm_devmem_ops *ops, return result; return devmem; } -EXPORT_SYMBOL(hmm_devmem_add); +EXPORT_SYMBOL_GPL(hmm_devmem_add); struct hmm_devmem *hmm_devmem_add_resource(const struct hmm_devmem_ops *ops, struct device *device, @@ -1108,7 +1108,7 @@ struct hmm_devmem *hmm_devmem_add_resource(const struct hmm_devmem_ops *ops, return result; return devmem; } -EXPORT_SYMBOL(hmm_devmem_add_resource); +EXPORT_SYMBOL_GPL(hmm_devmem_add_resource); /* * A device driver that wants to handle multiple devices memory through a
next prev parent reply other threads:[~2018-06-19 6:15 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-06-19 6:04 [PATCH v3 0/8] mm: Rework hmm to use devm_memremap_pages and other fixes Dan Williams 2018-06-19 6:04 ` [PATCH v3 1/8] mm, devm_memremap_pages: Mark devm_memremap_pages() EXPORT_SYMBOL_GPL Dan Williams 2018-06-19 6:04 ` Dan Williams 2018-06-19 6:04 ` [PATCH v3 2/8] mm, devm_memremap_pages: Kill mapping "System RAM" support Dan Williams 2018-06-19 6:04 ` Dan Williams 2018-06-19 6:04 ` [PATCH v3 3/8] mm, devm_memremap_pages: Fix shutdown handling Dan Williams 2018-06-19 6:04 ` Dan Williams 2018-06-19 16:00 ` Logan Gunthorpe 2018-06-19 16:00 ` Logan Gunthorpe 2018-06-19 6:04 ` [PATCH v3 4/8] mm, devm_memremap_pages: Add MEMORY_DEVICE_PRIVATE support Dan Williams 2018-06-19 6:04 ` Dan Williams 2018-06-19 6:05 ` [PATCH v3 5/8] mm, hmm: Use devm semantics for hmm_devmem_{add, remove} Dan Williams 2018-06-19 6:05 ` Dan Williams 2018-06-19 6:05 ` [PATCH v3 6/8] mm, hmm: Replace hmm_devmem_pages_create() with devm_memremap_pages() Dan Williams 2018-06-19 6:05 ` Dan Williams 2018-06-19 6:05 ` Dan Williams [this message] 2018-06-19 6:05 ` [PATCH v3 7/8] mm, hmm: Mark hmm_devmem_{add, add_resource} EXPORT_SYMBOL_GPL Dan Williams 2018-07-06 23:53 ` Dan Williams 2018-07-10 0:34 ` Andrew Morton 2018-07-10 17:11 ` Jerome Glisse 2018-07-10 17:11 ` Jerome Glisse 2018-06-19 6:05 ` [PATCH v3 8/8] mm: Fix exports that inadvertently make put_page() EXPORT_SYMBOL_GPL Dan Williams 2018-06-19 6:59 ` John Hubbard 2018-06-19 6:59 ` John Hubbard 2018-07-05 14:51 ` Joe Gorse
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=152938831573.17797.15264540938029137916.stgit@dwillia2-desk3.amr.corp.intel.com \ --to=dan.j.williams@intel.com \ --cc=akpm@linux-foundation.org \ --cc=hch@lst.de \ --cc=jglisse@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=logang@deltatee.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.