All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shannon Nelson <shannon.nelson@oracle.com>
To: davem@davemloft.net, netdev@vger.kernel.org,
	jakub.kicinski@netronome.com
Cc: anders.roxell@linaro.org, linux-kselftest@vger.kernel.org
Subject: [PATCH v3 net-next 1/4] selftests: rtnetlink: clear the return code at start of ipsec test
Date: Tue, 26 Jun 2018 10:07:52 -0700	[thread overview]
Message-ID: <1530032875-30482-2-git-send-email-shannon.nelson@oracle.com> (raw)
In-Reply-To: <1530032875-30482-1-git-send-email-shannon.nelson@oracle.com>

Following the custom from the other functions, clear the global
ret code before starting the test so as to not have previously
failed tests cause us to thing this test has failed.

Reported-by: Anders Roxell <anders.roxell@linaro.org>
Signed-off-by: Shannon Nelson <shannon.nelson@oracle.com>
---
 tools/testing/selftests/net/rtnetlink.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/net/rtnetlink.sh b/tools/testing/selftests/net/rtnetlink.sh
index b33a371..261a981 100755
--- a/tools/testing/selftests/net/rtnetlink.sh
+++ b/tools/testing/selftests/net/rtnetlink.sh
@@ -522,6 +522,8 @@ kci_test_macsec()
 #-------------------------------------------------------------------
 kci_test_ipsec()
 {
+	ret=0
+
 	# find an ip address on this machine and make up a destination
 	srcip=`ip -o addr | awk '/inet / { print $4; }' | grep -v "^127" | head -1 | cut -f1 -d/`
 	net=`echo $srcip | cut -f1-3 -d.`
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: shannon.nelson at oracle.com (Shannon Nelson)
Subject: [PATCH v3 net-next 1/4] selftests: rtnetlink: clear the return code at start of ipsec test
Date: Tue, 26 Jun 2018 10:07:52 -0700	[thread overview]
Message-ID: <1530032875-30482-2-git-send-email-shannon.nelson@oracle.com> (raw)
In-Reply-To: <1530032875-30482-1-git-send-email-shannon.nelson@oracle.com>

Following the custom from the other functions, clear the global
ret code before starting the test so as to not have previously
failed tests cause us to thing this test has failed.

Reported-by: Anders Roxell <anders.roxell at linaro.org>
Signed-off-by: Shannon Nelson <shannon.nelson at oracle.com>
---
 tools/testing/selftests/net/rtnetlink.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/net/rtnetlink.sh b/tools/testing/selftests/net/rtnetlink.sh
index b33a371..261a981 100755
--- a/tools/testing/selftests/net/rtnetlink.sh
+++ b/tools/testing/selftests/net/rtnetlink.sh
@@ -522,6 +522,8 @@ kci_test_macsec()
 #-------------------------------------------------------------------
 kci_test_ipsec()
 {
+	ret=0
+
 	# find an ip address on this machine and make up a destination
 	srcip=`ip -o addr | awk '/inet / { print $4; }' | grep -v "^127" | head -1 | cut -f1 -d/`
 	net=`echo $srcip | cut -f1-3 -d.`
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: shannon.nelson@oracle.com (Shannon Nelson)
Subject: [PATCH v3 net-next 1/4] selftests: rtnetlink: clear the return code at start of ipsec test
Date: Tue, 26 Jun 2018 10:07:52 -0700	[thread overview]
Message-ID: <1530032875-30482-2-git-send-email-shannon.nelson@oracle.com> (raw)
Message-ID: <20180626170752.7rhGW1Pm4sFXoTiMqfne2nyTgNqiw493KAPwTXYuU9s@z> (raw)
In-Reply-To: <1530032875-30482-1-git-send-email-shannon.nelson@oracle.com>

Following the custom from the other functions, clear the global
ret code before starting the test so as to not have previously
failed tests cause us to thing this test has failed.

Reported-by: Anders Roxell <anders.roxell at linaro.org>
Signed-off-by: Shannon Nelson <shannon.nelson at oracle.com>
---
 tools/testing/selftests/net/rtnetlink.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/net/rtnetlink.sh b/tools/testing/selftests/net/rtnetlink.sh
index b33a371..261a981 100755
--- a/tools/testing/selftests/net/rtnetlink.sh
+++ b/tools/testing/selftests/net/rtnetlink.sh
@@ -522,6 +522,8 @@ kci_test_macsec()
 #-------------------------------------------------------------------
 kci_test_ipsec()
 {
+	ret=0
+
 	# find an ip address on this machine and make up a destination
 	srcip=`ip -o addr | awk '/inet / { print $4; }' | grep -v "^127" | head -1 | cut -f1 -d/`
 	net=`echo $srcip | cut -f1-3 -d.`
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2018-06-26 17:09 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-26 17:07 [PATCH v3 net-next 0/4] Updates for ipsec selftests Shannon Nelson
2018-06-26 17:07 ` Shannon Nelson
2018-06-26 17:07 ` shannon.nelson
2018-06-26 17:07 ` Shannon Nelson [this message]
2018-06-26 17:07   ` [PATCH v3 net-next 1/4] selftests: rtnetlink: clear the return code at start of ipsec test Shannon Nelson
2018-06-26 17:07   ` shannon.nelson
2018-06-26 17:07 ` [PATCH v3 net-next 2/4] selftests: rtnetlink: use dummydev as a test device Shannon Nelson
2018-06-26 17:07   ` Shannon Nelson
2018-06-26 17:07   ` shannon.nelson
2018-06-26 17:07 ` [PATCH v3 net-next 3/4] netdevsim: add ipsec offload testing Shannon Nelson
2018-06-26 17:07   ` Shannon Nelson
2018-06-26 17:07   ` shannon.nelson
2018-06-26 21:23   ` Jakub Kicinski
2018-06-26 21:23     ` Jakub Kicinski
2018-06-26 21:23     ` jakub.kicinski
2018-06-26 17:07 ` [PATCH v3 net-next 4/4] selftests: rtnetlink: add ipsec offload API test Shannon Nelson
2018-06-26 17:07   ` Shannon Nelson
2018-06-26 17:07   ` shannon.nelson
2018-06-28  7:10 ` [PATCH v3 net-next 0/4] Updates for ipsec selftests David Miller
2018-06-28  7:10   ` David Miller
2018-06-28  7:10   ` davem

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1530032875-30482-2-git-send-email-shannon.nelson@oracle.com \
    --to=shannon.nelson@oracle.com \
    --cc=anders.roxell@linaro.org \
    --cc=davem@davemloft.net \
    --cc=jakub.kicinski@netronome.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.