From: Wei Wang <wei.w.wang@intel.com> To: virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-mm@kvack.org, mst@redhat.com, mhocko@kernel.org, akpm@linux-foundation.org Cc: torvalds@linux-foundation.org, pbonzini@redhat.com, wei.w.wang@intel.com, liliang.opensource@gmail.com, yang.zhang.wz@gmail.com, quan.xu0@gmail.com, nilal@redhat.com, riel@redhat.com, peterx@redhat.com Subject: [PATCH v35 5/5] virtio-balloon: VIRTIO_BALLOON_F_PAGE_POISON Date: Tue, 10 Jul 2018 17:31:07 +0800 [thread overview] Message-ID: <1531215067-35472-6-git-send-email-wei.w.wang@intel.com> (raw) In-Reply-To: <1531215067-35472-1-git-send-email-wei.w.wang@intel.com> The VIRTIO_BALLOON_F_PAGE_POISON feature bit is used to indicate if the guest is using page poisoning. Guest writes to the poison_val config field to tell host about the page poisoning value that is in use. Suggested-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Wei Wang <wei.w.wang@intel.com> Cc: Michael S. Tsirkin <mst@redhat.com> Cc: Michal Hocko <mhocko@suse.com> Cc: Andrew Morton <akpm@linux-foundation.org> --- drivers/virtio/virtio_balloon.c | 10 ++++++++++ include/uapi/linux/virtio_balloon.h | 3 +++ 2 files changed, 13 insertions(+) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 8754154..dd61660 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -869,6 +869,7 @@ static struct file_system_type balloon_fs = { static int virtballoon_probe(struct virtio_device *vdev) { struct virtio_balloon *vb; + __u32 poison_val; int err; if (!vdev->config->get) { @@ -916,6 +917,11 @@ static int virtballoon_probe(struct virtio_device *vdev) INIT_WORK(&vb->report_free_page_work, report_free_page_func); vb->cmd_id_received = VIRTIO_BALLOON_FREE_PAGE_REPORT_STOP_ID; vb->cmd_id_active = VIRTIO_BALLOON_FREE_PAGE_REPORT_STOP_ID; + if (virtio_has_feature(vdev, VIRTIO_BALLOON_F_PAGE_POISON)) { + memset(&poison_val, PAGE_POISON, sizeof(poison_val)); + virtio_cwrite(vb->vdev, struct virtio_balloon_config, + poison_val, &poison_val); + } } vb->nb.notifier_call = virtballoon_oom_notify; @@ -1034,6 +1040,9 @@ static int virtballoon_restore(struct virtio_device *vdev) static int virtballoon_validate(struct virtio_device *vdev) { + if (!page_poisoning_enabled()) + __virtio_clear_bit(vdev, VIRTIO_BALLOON_F_PAGE_POISON); + __virtio_clear_bit(vdev, VIRTIO_F_IOMMU_PLATFORM); return 0; } @@ -1043,6 +1052,7 @@ static unsigned int features[] = { VIRTIO_BALLOON_F_STATS_VQ, VIRTIO_BALLOON_F_DEFLATE_ON_OOM, VIRTIO_BALLOON_F_FREE_PAGE_HINT, + VIRTIO_BALLOON_F_PAGE_POISON, }; static struct virtio_driver virtio_balloon_driver = { diff --git a/include/uapi/linux/virtio_balloon.h b/include/uapi/linux/virtio_balloon.h index b77919b..97415ba 100644 --- a/include/uapi/linux/virtio_balloon.h +++ b/include/uapi/linux/virtio_balloon.h @@ -35,6 +35,7 @@ #define VIRTIO_BALLOON_F_STATS_VQ 1 /* Memory Stats virtqueue */ #define VIRTIO_BALLOON_F_DEFLATE_ON_OOM 2 /* Deflate balloon on OOM */ #define VIRTIO_BALLOON_F_FREE_PAGE_HINT 3 /* VQ to report free pages */ +#define VIRTIO_BALLOON_F_PAGE_POISON 4 /* Guest is using page poisoning */ /* Size of a PFN in the balloon interface. */ #define VIRTIO_BALLOON_PFN_SHIFT 12 @@ -47,6 +48,8 @@ struct virtio_balloon_config { __u32 actual; /* Free page report command id, readonly by guest */ __u32 free_page_report_cmd_id; + /* Stores PAGE_POISON if page poisoning is in use */ + __u32 poison_val; }; struct virtio_balloon_free_page_hints_cmd { -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Wei Wang <wei.w.wang@intel.com> To: virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-mm@kvack.org, mst@redhat.com, mhocko@kernel.org, akpm@linux-foundation.org Cc: torvalds@linux-foundation.org, pbonzini@redhat.com, wei.w.wang@intel.com, liliang.opensource@gmail.com, yang.zhang.wz@gmail.com, quan.xu0@gmail.com, nilal@redhat.com, riel@redhat.com, peterx@redhat.com Subject: [virtio-dev] [PATCH v35 5/5] virtio-balloon: VIRTIO_BALLOON_F_PAGE_POISON Date: Tue, 10 Jul 2018 17:31:07 +0800 [thread overview] Message-ID: <1531215067-35472-6-git-send-email-wei.w.wang@intel.com> (raw) In-Reply-To: <1531215067-35472-1-git-send-email-wei.w.wang@intel.com> The VIRTIO_BALLOON_F_PAGE_POISON feature bit is used to indicate if the guest is using page poisoning. Guest writes to the poison_val config field to tell host about the page poisoning value that is in use. Suggested-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Wei Wang <wei.w.wang@intel.com> Cc: Michael S. Tsirkin <mst@redhat.com> Cc: Michal Hocko <mhocko@suse.com> Cc: Andrew Morton <akpm@linux-foundation.org> --- drivers/virtio/virtio_balloon.c | 10 ++++++++++ include/uapi/linux/virtio_balloon.h | 3 +++ 2 files changed, 13 insertions(+) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 8754154..dd61660 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -869,6 +869,7 @@ static struct file_system_type balloon_fs = { static int virtballoon_probe(struct virtio_device *vdev) { struct virtio_balloon *vb; + __u32 poison_val; int err; if (!vdev->config->get) { @@ -916,6 +917,11 @@ static int virtballoon_probe(struct virtio_device *vdev) INIT_WORK(&vb->report_free_page_work, report_free_page_func); vb->cmd_id_received = VIRTIO_BALLOON_FREE_PAGE_REPORT_STOP_ID; vb->cmd_id_active = VIRTIO_BALLOON_FREE_PAGE_REPORT_STOP_ID; + if (virtio_has_feature(vdev, VIRTIO_BALLOON_F_PAGE_POISON)) { + memset(&poison_val, PAGE_POISON, sizeof(poison_val)); + virtio_cwrite(vb->vdev, struct virtio_balloon_config, + poison_val, &poison_val); + } } vb->nb.notifier_call = virtballoon_oom_notify; @@ -1034,6 +1040,9 @@ static int virtballoon_restore(struct virtio_device *vdev) static int virtballoon_validate(struct virtio_device *vdev) { + if (!page_poisoning_enabled()) + __virtio_clear_bit(vdev, VIRTIO_BALLOON_F_PAGE_POISON); + __virtio_clear_bit(vdev, VIRTIO_F_IOMMU_PLATFORM); return 0; } @@ -1043,6 +1052,7 @@ static unsigned int features[] = { VIRTIO_BALLOON_F_STATS_VQ, VIRTIO_BALLOON_F_DEFLATE_ON_OOM, VIRTIO_BALLOON_F_FREE_PAGE_HINT, + VIRTIO_BALLOON_F_PAGE_POISON, }; static struct virtio_driver virtio_balloon_driver = { diff --git a/include/uapi/linux/virtio_balloon.h b/include/uapi/linux/virtio_balloon.h index b77919b..97415ba 100644 --- a/include/uapi/linux/virtio_balloon.h +++ b/include/uapi/linux/virtio_balloon.h @@ -35,6 +35,7 @@ #define VIRTIO_BALLOON_F_STATS_VQ 1 /* Memory Stats virtqueue */ #define VIRTIO_BALLOON_F_DEFLATE_ON_OOM 2 /* Deflate balloon on OOM */ #define VIRTIO_BALLOON_F_FREE_PAGE_HINT 3 /* VQ to report free pages */ +#define VIRTIO_BALLOON_F_PAGE_POISON 4 /* Guest is using page poisoning */ /* Size of a PFN in the balloon interface. */ #define VIRTIO_BALLOON_PFN_SHIFT 12 @@ -47,6 +48,8 @@ struct virtio_balloon_config { __u32 actual; /* Free page report command id, readonly by guest */ __u32 free_page_report_cmd_id; + /* Stores PAGE_POISON if page poisoning is in use */ + __u32 poison_val; }; struct virtio_balloon_free_page_hints_cmd { -- 2.7.4 --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2018-07-10 9:57 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-07-10 9:31 [PATCH v35 0/5] Virtio-balloon: support free page reporting Wei Wang 2018-07-10 9:31 ` [virtio-dev] " Wei Wang 2018-07-10 9:31 ` Wei Wang 2018-07-10 9:31 ` [PATCH v35 1/5] mm: support to get hints of free page blocks Wei Wang 2018-07-10 9:31 ` [virtio-dev] " Wei Wang 2018-07-10 10:16 ` Wang, Wei W 2018-07-10 10:16 ` [virtio-dev] " Wang, Wei W 2018-07-10 10:16 ` Wang, Wei W 2018-07-10 10:16 ` Wang, Wei W 2018-07-10 17:33 ` Linus Torvalds 2018-07-10 17:33 ` Linus Torvalds 2018-07-11 1:28 ` Wei Wang 2018-07-11 1:28 ` Wei Wang 2018-07-11 1:28 ` [virtio-dev] " Wei Wang 2018-07-11 1:44 ` Linus Torvalds 2018-07-11 9:21 ` Michal Hocko 2018-07-11 9:21 ` Michal Hocko 2018-07-11 10:52 ` Wei Wang 2018-07-11 10:52 ` [virtio-dev] " Wei Wang 2018-07-11 10:52 ` Wei Wang 2018-07-11 11:09 ` Michal Hocko 2018-07-11 11:09 ` Michal Hocko 2018-07-11 13:55 ` Wang, Wei W 2018-07-11 13:55 ` Wang, Wei W 2018-07-11 13:55 ` [virtio-dev] " Wang, Wei W 2018-07-11 14:38 ` Michal Hocko 2018-07-11 14:38 ` Michal Hocko 2018-07-11 19:36 ` Michael S. Tsirkin 2018-07-11 19:36 ` Michael S. Tsirkin 2018-07-11 19:36 ` [virtio-dev] " Michael S. Tsirkin 2018-07-11 16:23 ` Linus Torvalds 2018-07-11 16:23 ` Linus Torvalds 2018-07-12 2:21 ` Wei Wang 2018-07-12 2:21 ` [virtio-dev] " Wei Wang 2018-07-12 2:30 ` Linus Torvalds 2018-07-12 2:30 ` Linus Torvalds 2018-07-12 2:52 ` Wei Wang 2018-07-12 2:52 ` [virtio-dev] " Wei Wang 2018-07-12 2:52 ` Wei Wang 2018-07-12 8:13 ` Michal Hocko 2018-07-12 11:34 ` Wei Wang 2018-07-12 11:34 ` Wei Wang 2018-07-12 11:34 ` [virtio-dev] " Wei Wang 2018-07-12 11:49 ` Michal Hocko 2018-07-13 0:33 ` Wei Wang 2018-07-13 0:33 ` [virtio-dev] " Wei Wang 2018-07-13 0:33 ` Wei Wang 2018-07-12 11:49 ` Michal Hocko 2018-07-12 8:13 ` Michal Hocko 2018-07-12 2:21 ` Wei Wang 2018-07-12 13:12 ` Michal Hocko 2018-07-12 13:12 ` Michal Hocko 2018-07-11 1:44 ` Linus Torvalds 2018-07-11 4:00 ` Michael S. Tsirkin 2018-07-11 4:00 ` [virtio-dev] " Michael S. Tsirkin 2018-07-11 4:04 ` Michael S. Tsirkin 2018-07-11 4:04 ` Michael S. Tsirkin 2018-07-11 4:04 ` [virtio-dev] " Michael S. Tsirkin 2018-07-11 4:00 ` Michael S. Tsirkin 2018-07-10 9:31 ` Wei Wang 2018-07-10 9:31 ` [PATCH v35 2/5] virtio-balloon: remove BUG() in init_vqs Wei Wang 2018-07-10 9:31 ` [virtio-dev] " Wei Wang 2018-07-10 9:31 ` Wei Wang 2018-07-10 9:31 ` [PATCH v35 3/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT Wei Wang 2018-07-10 9:31 ` [virtio-dev] " Wei Wang 2018-07-10 9:31 ` Wei Wang 2018-07-10 9:31 ` [PATCH v35 4/5] mm/page_poison: expose page_poisoning_enabled to kernel modules Wei Wang 2018-07-10 9:31 ` [virtio-dev] " Wei Wang 2018-07-10 9:31 ` Wei Wang 2018-07-10 9:31 ` Wei Wang [this message] 2018-07-10 9:31 ` [virtio-dev] [PATCH v35 5/5] virtio-balloon: VIRTIO_BALLOON_F_PAGE_POISON Wei Wang 2018-07-10 9:31 ` Wei Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1531215067-35472-6-git-send-email-wei.w.wang@intel.com \ --to=wei.w.wang@intel.com \ --cc=akpm@linux-foundation.org \ --cc=kvm@vger.kernel.org \ --cc=liliang.opensource@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mhocko@kernel.org \ --cc=mst@redhat.com \ --cc=nilal@redhat.com \ --cc=pbonzini@redhat.com \ --cc=peterx@redhat.com \ --cc=quan.xu0@gmail.com \ --cc=riel@redhat.com \ --cc=torvalds@linux-foundation.org \ --cc=virtio-dev@lists.oasis-open.org \ --cc=virtualization@lists.linux-foundation.org \ --cc=yang.zhang.wz@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.