From: Dan Williams <dan.j.williams@intel.com>
To: vishal.l.verma@intel.com
Cc: Nick Clifton <nickc@redhat.com>, linux-nvdimm@lists.01.org
Subject: [ndctl PATCH v2] ndctl: Remove dependency on linker garbage collection
Date: Wed, 11 Jul 2018 13:47:27 -0700 [thread overview]
Message-ID: <153134203155.10007.126148551207679453.stgit@dwillia2-desk3.amr.corp.intel.com> (raw)
A sub-set of the unit tests are optionally included in the build when
"--enable-test" is specified to the configure script. However, the "ndctl
test" command support code should not be included in the build when
"--enable-test" is not specified. The linker was being helpful and
throwing away the error, because cmd_test() is never called, but we
should not have wasted time compiling and throwing away that file in the
first place.
Reported-by: Nick Clifton <nickc@redhat.com>
Link: https://bugzilla.redhat.com/show_bug.cgi?id=1598961
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
Changes in v2, rebased on latest master.
ndctl/Makefile.am | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ndctl/Makefile.am b/ndctl/Makefile.am
index d22a37951537..0f568719f7a6 100644
--- a/ndctl/Makefile.am
+++ b/ndctl/Makefile.am
@@ -11,7 +11,6 @@ ndctl_SOURCES = ndctl.c \
dimm.c \
../util/log.c \
list.c \
- test.c \
../util/json.c \
util/json-smart.c \
util/json-firmware.c \
@@ -39,5 +38,6 @@ ndctl_SOURCES += ../test/libndctl.c \
../test/dpa-alloc.c \
../test/parent-uuid.c \
../test/multi-pmem.c \
- ../test/core.c
+ ../test/core.c \
+ test.c
endif
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
reply other threads:[~2018-07-11 20:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153134203155.10007.126148551207679453.stgit@dwillia2-desk3.amr.corp.intel.com \
--to=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
--cc=nickc@redhat.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.