From: Suzuki K Poulose <suzuki.poulose@arm.com> To: linux-arm-kernel@lists.infradead.org Cc: cdall@kernel.org, kvm@vger.kernel.org, marc.zyngier@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, dave.martin@arm.com, pbonzini@redhat.com, kvmarm@lists.cs.columbia.edu Subject: [PATCH v4 04/20] kvm: arm/arm64: Remove spurious WARN_ON Date: Wed, 18 Jul 2018 10:18:47 +0100 [thread overview] Message-ID: <1531905547-25478-5-git-send-email-suzuki.poulose@arm.com> (raw) In-Reply-To: <1531905547-25478-1-git-send-email-suzuki.poulose@arm.com> On a 4-level page table pgd entry can be empty, unlike a 3-level page table. Remove the spurious WARN_ON() in stage_get_pud(). Acked-by: Christoffer Dall <cdall@kernel.org> Acked-by: Marc Zyngier <marc.zyngier@arm.com> Reviewed-by: Eric Auger <eric.auger@redhat.com> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> --- virt/kvm/arm/mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/virt/kvm/arm/mmu.c b/virt/kvm/arm/mmu.c index 061e6b3..308171c 100644 --- a/virt/kvm/arm/mmu.c +++ b/virt/kvm/arm/mmu.c @@ -976,7 +976,7 @@ static pud_t *stage2_get_pud(struct kvm *kvm, struct kvm_mmu_memory_cache *cache pud_t *pud; pgd = kvm->arch.pgd + stage2_pgd_index(addr); - if (WARN_ON(stage2_pgd_none(*pgd))) { + if (stage2_pgd_none(*pgd)) { if (!cache) return NULL; pud = mmu_memory_cache_alloc(cache); -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: suzuki.poulose@arm.com (Suzuki K Poulose) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 04/20] kvm: arm/arm64: Remove spurious WARN_ON Date: Wed, 18 Jul 2018 10:18:47 +0100 [thread overview] Message-ID: <1531905547-25478-5-git-send-email-suzuki.poulose@arm.com> (raw) In-Reply-To: <1531905547-25478-1-git-send-email-suzuki.poulose@arm.com> On a 4-level page table pgd entry can be empty, unlike a 3-level page table. Remove the spurious WARN_ON() in stage_get_pud(). Acked-by: Christoffer Dall <cdall@kernel.org> Acked-by: Marc Zyngier <marc.zyngier@arm.com> Reviewed-by: Eric Auger <eric.auger@redhat.com> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> --- virt/kvm/arm/mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/virt/kvm/arm/mmu.c b/virt/kvm/arm/mmu.c index 061e6b3..308171c 100644 --- a/virt/kvm/arm/mmu.c +++ b/virt/kvm/arm/mmu.c @@ -976,7 +976,7 @@ static pud_t *stage2_get_pud(struct kvm *kvm, struct kvm_mmu_memory_cache *cache pud_t *pud; pgd = kvm->arch.pgd + stage2_pgd_index(addr); - if (WARN_ON(stage2_pgd_none(*pgd))) { + if (stage2_pgd_none(*pgd)) { if (!cache) return NULL; pud = mmu_memory_cache_alloc(cache); -- 2.7.4
next prev parent reply other threads:[~2018-07-18 9:18 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-07-18 9:18 [PATCH v4 00/20] kvm: arm64: Dynamic IPA and 52bit IPA Suzuki K Poulose 2018-07-18 9:18 ` Suzuki K Poulose 2018-07-18 9:18 ` [PATCH v4 01/20] virtio: mmio-v1: Validate queue PFN Suzuki K Poulose 2018-07-18 9:18 ` Suzuki K Poulose 2018-07-22 15:55 ` Michael S. Tsirkin 2018-07-22 15:55 ` Michael S. Tsirkin 2018-07-18 9:18 ` [PATCH v4 02/20] virtio: pci-legacy: Validate queue pfn Suzuki K Poulose 2018-07-18 9:18 ` Suzuki K Poulose 2018-07-22 15:53 ` Michael S. Tsirkin 2018-07-22 15:53 ` Michael S. Tsirkin 2018-07-23 9:44 ` Suzuki K Poulose 2018-07-23 9:44 ` Suzuki K Poulose 2018-07-23 12:54 ` Marc Zyngier 2018-07-23 12:54 ` Marc Zyngier 2018-07-23 14:20 ` Michael S. Tsirkin 2018-07-23 14:20 ` Michael S. Tsirkin 2018-07-18 9:18 ` [PATCH v4 03/20] kvm: arm/arm64: Fix stage2_flush_memslot for 4 level page table Suzuki K Poulose 2018-07-18 9:18 ` Suzuki K Poulose 2018-07-18 9:18 ` Suzuki K Poulose [this message] 2018-07-18 9:18 ` [PATCH v4 04/20] kvm: arm/arm64: Remove spurious WARN_ON Suzuki K Poulose 2018-07-18 9:18 ` [PATCH v4 05/20] kvm: arm64: Add helper for loading the stage2 setting for a VM Suzuki K Poulose 2018-07-18 9:18 ` Suzuki K Poulose 2018-08-30 9:39 ` Christoffer Dall 2018-08-30 9:39 ` Christoffer Dall 2018-09-03 10:03 ` Suzuki K Poulose 2018-09-03 10:03 ` Suzuki K Poulose 2018-07-18 9:18 ` [PATCH v4 06/20] arm64: Add a helper for PARange to physical shift conversion Suzuki K Poulose 2018-07-18 9:18 ` Suzuki K Poulose 2018-08-30 9:42 ` Christoffer Dall 2018-08-30 9:42 ` Christoffer Dall 2018-09-03 10:06 ` Suzuki K Poulose 2018-09-03 10:06 ` Suzuki K Poulose 2018-09-03 11:13 ` Christoffer Dall 2018-09-03 11:13 ` Christoffer Dall 2018-07-18 9:18 ` [PATCH v4 07/20] kvm: arm64: Clean up VTCR_EL2 initialisation Suzuki K Poulose 2018-07-18 9:18 ` Suzuki K Poulose 2018-07-18 9:18 ` [PATCH v4 08/20] kvm: arm64: Configure VTCR_EL2 per VM Suzuki K Poulose 2018-07-18 9:18 ` Suzuki K Poulose 2018-08-30 10:02 ` Christoffer Dall 2018-08-30 10:02 ` Christoffer Dall 2018-07-18 9:18 ` [PATCH v4 09/20] kvm: arm/arm64: Prepare for VM specific stage2 translations Suzuki K Poulose 2018-07-18 9:18 ` Suzuki K Poulose 2018-07-18 9:18 ` [PATCH v4 10/20] kvm: arm64: Prepare for dynamic stage2 page table layout Suzuki K Poulose 2018-07-18 9:18 ` Suzuki K Poulose 2018-07-18 9:18 ` [PATCH v4 11/20] kvm: arm64: Make stage2 page table layout dynamic Suzuki K Poulose 2018-07-18 9:18 ` Suzuki K Poulose 2018-07-18 9:18 ` [PATCH v4 12/20] kvm: arm64: Dynamic configuration of VTTBR mask Suzuki K Poulose 2018-07-18 9:18 ` Suzuki K Poulose 2018-07-18 9:18 ` [PATCH v4 13/20] kvm: arm64: Configure VTCR_EL2.SL0 per VM Suzuki K Poulose 2018-07-18 9:18 ` Suzuki K Poulose 2018-07-18 9:18 ` [PATCH v4 14/20] kvm: arm64: Switch to per VM IPA limit Suzuki K Poulose 2018-07-18 9:18 ` Suzuki K Poulose 2018-07-18 9:18 ` [PATCH v4 15/20] vgic: Add support for 52bit guest physical address Suzuki K Poulose 2018-07-18 9:18 ` Suzuki K Poulose 2018-07-18 9:18 ` [PATCH v4 16/20] kvm: arm64: Add 52bit support for PAR to HPFAR conversoin Suzuki K Poulose 2018-07-18 9:18 ` Suzuki K Poulose 2018-07-18 9:19 ` [PATCH v4 17/20] kvm: arm64: Set a limit on the IPA size Suzuki K Poulose 2018-07-18 9:19 ` Suzuki K Poulose 2018-07-18 9:19 ` [PATCH v4 18/20] kvm: arm64: Limit the minimum number of page table levels Suzuki K Poulose 2018-07-18 9:19 ` Suzuki K Poulose 2018-07-18 9:19 ` [PATCH v4 19/20] kvm: arm/arm64: Expose supported physical address limit for VM Suzuki K Poulose 2018-07-18 9:19 ` Suzuki K Poulose 2018-07-18 9:19 ` [PATCH v4 20/20] kvm: arm64: Allow tuning the physical address size " Suzuki K Poulose 2018-07-18 9:19 ` Suzuki K Poulose 2018-08-30 12:40 ` Christoffer Dall 2018-08-30 12:40 ` Christoffer Dall 2018-09-03 10:14 ` Suzuki K Poulose 2018-09-03 10:14 ` Suzuki K Poulose 2018-07-18 9:19 ` [kvmtool PATCH v4 21/24] kvmtool: Allow backends to run checks on the KVM device fd Suzuki K Poulose 2018-07-18 9:19 ` Suzuki K Poulose 2018-07-18 9:19 ` [kvmtool PATCH v4 22/24] kvmtool: arm64: Add support for guest physical address size Suzuki K Poulose 2018-07-18 9:19 ` Suzuki K Poulose 2018-07-18 9:19 ` [kvmtool PATCH v4 23/24] kvmtool: arm64: Switch memory layout Suzuki K Poulose 2018-07-18 9:19 ` Suzuki K Poulose 2018-07-18 9:19 ` [kvmtool PATCH v4 24/24] kvmtool: arm: Add support for creating VM with PA size Suzuki K Poulose 2018-07-18 9:19 ` Suzuki K Poulose
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1531905547-25478-5-git-send-email-suzuki.poulose@arm.com \ --to=suzuki.poulose@arm.com \ --cc=catalin.marinas@arm.com \ --cc=cdall@kernel.org \ --cc=dave.martin@arm.com \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=marc.zyngier@arm.com \ --cc=pbonzini@redhat.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.