All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philippe De Muyter <phdm@macqel.be>
To: linux-media@vger.kernel.org, hans.verkuil@cisco.com
Cc: Philippe De Muyter <phdm@macqel.be>
Subject: [PATCH 2/2] media: v4l2-common: simplify v4l2_i2c_subdev_init name generation
Date: Wed,  1 Aug 2018 23:20:57 +0200	[thread overview]
Message-ID: <1533158457-15831-2-git-send-email-phdm@macqel.be> (raw)
In-Reply-To: <1533158457-15831-1-git-send-email-phdm@macqel.be>

When v4l2_i2c_subdev_init is called, dev_name(&client->dev) has already
been set.  Use it to generate subdev's name instead of recreating it
with "%d-%04x".  This improves the similarity in subdev's name creation
between v4l2_i2c_subdev_init and v4l2_spi_subdev_init.

Signed-off-by: Philippe De Muyter <phdm@macqel.be>
---
 drivers/media/v4l2-core/v4l2-common.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2-core/v4l2-common.c
index 5471c6d..b062111 100644
--- a/drivers/media/v4l2-core/v4l2-common.c
+++ b/drivers/media/v4l2-core/v4l2-common.c
@@ -121,9 +121,8 @@ void v4l2_i2c_subdev_init(struct v4l2_subdev *sd, struct i2c_client *client,
 	v4l2_set_subdevdata(sd, client);
 	i2c_set_clientdata(client, sd);
 	/* initialize name */
-	snprintf(sd->name, sizeof(sd->name), "%s %d-%04x",
-		client->dev.driver->name, i2c_adapter_id(client->adapter),
-		client->addr);
+	snprintf(sd->name, sizeof(sd->name), "%s %s",
+		client->dev.driver->name, dev_name(&client->dev));
 }
 EXPORT_SYMBOL_GPL(v4l2_i2c_subdev_init);
 
-- 
1.8.4

  reply	other threads:[~2018-08-01 23:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-01 21:20 [PATCH 1/2] media: v4l2-common: v4l2_spi_subdev_init : generate unique name Philippe De Muyter
2018-08-01 21:20 ` Philippe De Muyter [this message]
2018-08-03 12:43   ` [PATCH 2/2] media: v4l2-common: simplify v4l2_i2c_subdev_init name generation Sakari Ailus
2018-08-03 13:46     ` Philippe De Muyter
2018-08-03 14:11       ` Sakari Ailus
2018-08-08  8:43     ` Philippe De Muyter
2018-09-05  7:53 ` [PATCH 1/2] media: v4l2-common: v4l2_spi_subdev_init : generate unique name Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1533158457-15831-2-git-send-email-phdm@macqel.be \
    --to=phdm@macqel.be \
    --cc=hans.verkuil@cisco.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.