All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Simmons <jsimmons@infradead.org>
To: lustre-devel@lists.lustre.org
Subject: [lustre-devel] [PATCH 10/38] lustre: llite: use C99 for struct lprocfs_llite_obd_vars
Date: Thu, 16 Aug 2018 23:10:13 -0400	[thread overview]
Message-ID: <1534475441-15543-11-git-send-email-jsimmons@infradead.org> (raw)
In-Reply-To: <1534475441-15543-1-git-send-email-jsimmons@infradead.org>

Remove mntpt_path and filegroups since they don't even exit.
Migrate the rest to C99 structure initialization.

Signed-off-by: James Simmons <uja.ornl@yahoo.com>
WC-bug-id: https://jira.whamcloud.com/browse/LU-3319
Reviewed-on: http://review.whamcloud.com/7290
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
---
 drivers/staging/lustre/lustre/llite/lproc_llite.c | 23 +++++++++++++----------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/lustre/lustre/llite/lproc_llite.c b/drivers/staging/lustre/lustre/llite/lproc_llite.c
index 5530156..0dc4d00 100644
--- a/drivers/staging/lustre/lustre/llite/lproc_llite.c
+++ b/drivers/staging/lustre/lustre/llite/lproc_llite.c
@@ -1086,17 +1086,20 @@ static ssize_t ll_nosquash_nids_seq_write(struct file *file,
 LPROC_SEQ_FOPS(ll_nosquash_nids);
 
 static struct lprocfs_vars lprocfs_llite_obd_vars[] = {
-	/* { "mntpt_path",   ll_rd_path,	     0, 0 }, */
-	{ "site",	  &ll_site_stats_fops,    NULL, 0 },
-	/* { "filegroups",   lprocfs_rd_filegroups,  0, 0 }, */
-	{ "max_cached_mb",    &ll_max_cached_mb_fops, NULL },
-	{ "statahead_stats",  &ll_statahead_stats_fops, NULL, 0 },
-	{ "unstable_stats",   &ll_unstable_stats_fops, NULL },
-	{ "sbi_flags",	      &ll_sbi_flags_fops, NULL, 0 },
-	{ .name =       "root_squash",
+	{ .name	=	"site",
+	  .fops	=	&ll_site_stats_fops			},
+	{ .name	=	"max_cached_mb",
+	  .fops	=	&ll_max_cached_mb_fops			},
+	{ .name	=	"statahead_stats",
+	  .fops	=	&ll_statahead_stats_fops		},
+	{ .name	=	"unstable_stats",
+	  .fops	=	&ll_unstable_stats_fops			},
+	{ .name	=	"sbi_flags",
+	  .fops	=	&ll_sbi_flags_fops			},
+	{ .name =	"root_squash",
 	  .fops =       &ll_root_squash_fops			},
-	{ .name =		"nosquash_nids",
-	  .fops =		&ll_nosquash_nids_fops		},
+	{ .name =	"nosquash_nids",
+	  .fops =	&ll_nosquash_nids_fops			},
 	{ NULL }
 };
 
-- 
1.8.3.1

  parent reply	other threads:[~2018-08-17  3:10 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-17  3:10 [lustre-devel] [PATCH 00/38] lustre: fixes for sysfs handling James Simmons
2018-08-17  3:10 ` [lustre-devel] [PATCH 01/38] lustre: llite: rename ldebugfs_[un]register_mountpoint James Simmons
2018-08-17  4:24   ` NeilBrown
2018-08-17 22:03     ` James Simmons
2018-08-17  3:10 ` [lustre-devel] [PATCH 02/38] lustre: llite: change ll_statfs_internal to use struct ll_sb_info James Simmons
2018-08-17  3:10 ` [lustre-devel] [PATCH 03/38] lustre: llite: move llite_root and llite_kset to lproc_llite.c James Simmons
2018-08-17  3:10 ` [lustre-devel] [PATCH 04/38] lustre: llite: remove ll_sb James Simmons
2018-08-17  4:27   ` NeilBrown
2018-08-18  0:35     ` James Simmons
2018-08-18  5:12       ` Andreas Dilger
2018-08-17  3:10 ` [lustre-devel] [PATCH 05/38] lustre: llite: change top kobject for llite into a kset James Simmons
2018-08-17  3:10 ` [lustre-devel] [PATCH 06/38] lustre: llite: rename llite_sb_release James Simmons
2018-08-17  5:56   ` NeilBrown
2018-08-17  3:10 ` [lustre-devel] [PATCH 07/38] lustre: llite: register mountpoint before process llog James Simmons
2018-08-17  6:21   ` NeilBrown
2018-08-17  3:10 ` [lustre-devel] [PATCH 08/38] lustre: llite: move lmd_profile handling James Simmons
2018-08-17  3:10 ` [lustre-devel] [PATCH 09/38] lustre: llite: add proper error handling for ll_debugfs_register_super() James Simmons
2018-08-17  3:10 ` James Simmons [this message]
2018-08-17  3:10 ` [lustre-devel] [PATCH 11/38] lustre: llite: create ll_stats_pid_write() James Simmons
2018-08-17  3:10 ` [lustre-devel] [PATCH 12/38] lustre: llite: improve sysfs file text in lproc_llite.c James Simmons
2018-08-17  3:10 ` [lustre-devel] [PATCH 13/38] lustre: llite: don't handle success case for blocksize sysfs code James Simmons
2018-08-17  3:10 ` [lustre-devel] [PATCH 14/38] lustre: llite: don't handle success case for kbyte* " James Simmons
2018-08-17  6:32   ` NeilBrown
2018-08-17  3:10 ` [lustre-devel] [PATCH 15/38] lustre: llite: don't handle success case for file* " James Simmons
2018-08-17  3:10 ` [lustre-devel] [PATCH 16/38] lustre: llite: user kstrtobool for some sysfs handling James Simmons
2018-08-17  3:10 ` [lustre-devel] [PATCH 17/38] lustre: llite: add newline to llite.*.offset_stats James Simmons
2018-08-17  3:10 ` [lustre-devel] [PATCH 18/38] lustre: obd: embedded struct lprocfs_vars in obd device James Simmons
2018-08-17  3:10 ` [lustre-devel] [PATCH 19/38] lustre: obdclass: swap obd device attrs and default_attrs James Simmons
2018-08-17  3:10 ` [lustre-devel] [PATCH 20/38] lustre: obdclass: embedded attributes in struct obd_device James Simmons
2018-08-17  3:10 ` [lustre-devel] [PATCH 21/38] lustre: obdclass: add light weight obd_def_uuid_attrs James Simmons
2018-08-17  3:10 ` [lustre-devel] [PATCH 22/38] lustre: obd: migrate to ksets James Simmons
2018-08-17  3:10 ` [lustre-devel] [PATCH 23/38] lustre: obd: create class_setup_tunables() function James Simmons
2018-08-17  3:10 ` [lustre-devel] [PATCH 24/38] lustre: obd: create conn_uuid sysfs file James Simmons
2018-08-17  3:10 ` [lustre-devel] [PATCH 25/38] lustre: obd: enhance print_lustre_cfg() James Simmons
2018-08-17  3:10 ` [lustre-devel] [PATCH 26/38] lustre: obd: merge both top lustre sysfs attributes James Simmons
2018-08-17  3:10 ` [lustre-devel] [PATCH 27/38] lustre: obd: resolve config log sysfs issues James Simmons
2018-08-17  6:52   ` NeilBrown
2018-08-17  3:10 ` [lustre-devel] [PATCH 28/38] lustre: obd: move ioctl handling to class_obd.c James Simmons
2018-08-17  3:10 ` [lustre-devel] [PATCH 29/38] lustre: llite: replace ll_process_config with class_modify_config James Simmons
2018-08-17  3:10 ` [lustre-devel] [PATCH 30/38] lustre: mgc: update sysfs handling James Simmons
2018-08-17  3:10 ` [lustre-devel] [PATCH 31/38] lustre: osc: fixup kstrto* for " James Simmons
2018-08-17  3:10 ` [lustre-devel] [PATCH 32/38] lustre: osc: restore cl_loi_list_lock James Simmons
2018-08-17  7:30   ` NeilBrown
2018-08-18  0:59     ` James Simmons
2018-08-18  5:08       ` Andreas Dilger
2018-08-18  5:10         ` Andreas Dilger
2018-08-17  3:10 ` [lustre-devel] [PATCH 33/38] lustre: osc: make unstable_stats a debugfs file James Simmons
2018-08-17  3:10 ` [lustre-devel] [PATCH 34/38] lustre: osc: enhance end to end bulk cksum error report James Simmons
2018-08-17  3:10 ` [lustre-devel] [PATCH 35/38] lustre: osc: update sysfs handling James Simmons
2018-08-17  3:10 ` [lustre-devel] [PATCH 36/38] lustre: lmv: " James Simmons
2018-08-17  3:10 ` [lustre-devel] [PATCH 37/38] lustre: lov: " James Simmons
2018-08-17  3:10 ` [lustre-devel] [PATCH 38/38] lustre: mdc: " James Simmons
2018-08-20  4:28 ` [lustre-devel] [PATCH 00/38] lustre: fixes for " NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1534475441-15543-11-git-send-email-jsimmons@infradead.org \
    --to=jsimmons@infradead.org \
    --cc=lustre-devel@lists.lustre.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.