All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaejoong Kim <climbbb.kim@gmail.com>
To: linux-um@lists.infradead.org, netdev@vger.kernel.org,
	linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org,
	devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org,
	sparclinux@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>
Subject: [PATCH 19/25] staging: fwserial: Change return type to void
Date: Tue,  4 Sep 2018 11:44:45 +0900	[thread overview]
Message-ID: <1536029091-4426-20-git-send-email-climbbb.kim@gmail.com> (raw)
In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com>

Since tty_standard_install() always returns 0, the return type has changed
to void. Now apply this and remove the obsolete error check.

Signed-off-by: Jaejoong Kim <climbbb.kim@gmail.com>
---
 drivers/staging/fwserial/fwserial.c | 22 ++++++++--------------
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c
index fa0dd42..5134019 100644
--- a/drivers/staging/fwserial/fwserial.c
+++ b/drivers/staging/fwserial/fwserial.c
@@ -1064,27 +1064,21 @@ static void fwtty_cleanup(struct tty_struct *tty)
 static int fwtty_install(struct tty_driver *driver, struct tty_struct *tty)
 {
 	struct fwtty_port *port = fwtty_port_get(tty->index);
-	int err;
 
-	err = tty_standard_install(driver, tty);
-	if (!err)
-		tty->driver_data = port;
-	else
-		fwtty_port_put(port);
-	return err;
+	tty_standard_install(driver, tty);
+	tty->driver_data = port;
+
+	return 0;
 }
 
 static int fwloop_install(struct tty_driver *driver, struct tty_struct *tty)
 {
 	struct fwtty_port *port = fwtty_port_get(table_idx(tty->index));
-	int err;
 
-	err = tty_standard_install(driver, tty);
-	if (!err)
-		tty->driver_data = port;
-	else
-		fwtty_port_put(port);
-	return err;
+	tty_standard_install(driver, tty);
+	tty->driver_data = port;
+
+	return 0;
 }
 
 static int fwtty_write(struct tty_struct *tty, const unsigned char *buf, int c)
-- 
2.7.4


WARNING: multiple messages have this Message-ID (diff)
From: Jaejoong Kim <climbbb.kim@gmail.com>
To: linux-um@lists.infradead.org, netdev@vger.kernel.org,
	linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org,
	devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org,
	sparclinux@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>
Subject: [19/25] staging: fwserial: Change return type to void
Date: Tue,  4 Sep 2018 11:44:45 +0900	[thread overview]
Message-ID: <1536029091-4426-20-git-send-email-climbbb.kim@gmail.com> (raw)

Since tty_standard_install() always returns 0, the return type has changed
to void. Now apply this and remove the obsolete error check.

Signed-off-by: Jaejoong Kim <climbbb.kim@gmail.com>
---
 drivers/staging/fwserial/fwserial.c | 22 ++++++++--------------
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c
index fa0dd42..5134019 100644
--- a/drivers/staging/fwserial/fwserial.c
+++ b/drivers/staging/fwserial/fwserial.c
@@ -1064,27 +1064,21 @@ static void fwtty_cleanup(struct tty_struct *tty)
 static int fwtty_install(struct tty_driver *driver, struct tty_struct *tty)
 {
 	struct fwtty_port *port = fwtty_port_get(tty->index);
-	int err;
 
-	err = tty_standard_install(driver, tty);
-	if (!err)
-		tty->driver_data = port;
-	else
-		fwtty_port_put(port);
-	return err;
+	tty_standard_install(driver, tty);
+	tty->driver_data = port;
+
+	return 0;
 }
 
 static int fwloop_install(struct tty_driver *driver, struct tty_struct *tty)
 {
 	struct fwtty_port *port = fwtty_port_get(table_idx(tty->index));
-	int err;
 
-	err = tty_standard_install(driver, tty);
-	if (!err)
-		tty->driver_data = port;
-	else
-		fwtty_port_put(port);
-	return err;
+	tty_standard_install(driver, tty);
+	tty->driver_data = port;
+
+	return 0;
 }
 
 static int fwtty_write(struct tty_struct *tty, const unsigned char *buf, int c)

WARNING: multiple messages have this Message-ID (diff)
From: Jaejoong Kim <climbbb.kim@gmail.com>
To: linux-um@lists.infradead.org, netdev@vger.kernel.org,
	linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org,
	devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org,
	sparclinux@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>
Subject: [PATCH 19/25] staging: fwserial: Change return type to void
Date: Tue, 04 Sep 2018 02:44:45 +0000	[thread overview]
Message-ID: <1536029091-4426-20-git-send-email-climbbb.kim@gmail.com> (raw)
In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com>

Since tty_standard_install() always returns 0, the return type has changed
to void. Now apply this and remove the obsolete error check.

Signed-off-by: Jaejoong Kim <climbbb.kim@gmail.com>
---
 drivers/staging/fwserial/fwserial.c | 22 ++++++++--------------
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c
index fa0dd42..5134019 100644
--- a/drivers/staging/fwserial/fwserial.c
+++ b/drivers/staging/fwserial/fwserial.c
@@ -1064,27 +1064,21 @@ static void fwtty_cleanup(struct tty_struct *tty)
 static int fwtty_install(struct tty_driver *driver, struct tty_struct *tty)
 {
 	struct fwtty_port *port = fwtty_port_get(tty->index);
-	int err;
 
-	err = tty_standard_install(driver, tty);
-	if (!err)
-		tty->driver_data = port;
-	else
-		fwtty_port_put(port);
-	return err;
+	tty_standard_install(driver, tty);
+	tty->driver_data = port;
+
+	return 0;
 }
 
 static int fwloop_install(struct tty_driver *driver, struct tty_struct *tty)
 {
 	struct fwtty_port *port = fwtty_port_get(table_idx(tty->index));
-	int err;
 
-	err = tty_standard_install(driver, tty);
-	if (!err)
-		tty->driver_data = port;
-	else
-		fwtty_port_put(port);
-	return err;
+	tty_standard_install(driver, tty);
+	tty->driver_data = port;
+
+	return 0;
 }
 
 static int fwtty_write(struct tty_struct *tty, const unsigned char *buf, int c)
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: Jaejoong Kim <climbbb.kim@gmail.com>
To: linux-um@lists.infradead.org, netdev@vger.kernel.org,
	linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org,
	devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org,
	sparclinux@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>
Subject: [PATCH 19/25] staging: fwserial: Change return type to void
Date: Tue,  4 Sep 2018 11:44:45 +0900	[thread overview]
Message-ID: <1536029091-4426-20-git-send-email-climbbb.kim@gmail.com> (raw)
In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com>

Since tty_standard_install() always returns 0, the return type has changed
to void. Now apply this and remove the obsolete error check.

Signed-off-by: Jaejoong Kim <climbbb.kim@gmail.com>
---
 drivers/staging/fwserial/fwserial.c | 22 ++++++++--------------
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c
index fa0dd42..5134019 100644
--- a/drivers/staging/fwserial/fwserial.c
+++ b/drivers/staging/fwserial/fwserial.c
@@ -1064,27 +1064,21 @@ static void fwtty_cleanup(struct tty_struct *tty)
 static int fwtty_install(struct tty_driver *driver, struct tty_struct *tty)
 {
 	struct fwtty_port *port = fwtty_port_get(tty->index);
-	int err;
 
-	err = tty_standard_install(driver, tty);
-	if (!err)
-		tty->driver_data = port;
-	else
-		fwtty_port_put(port);
-	return err;
+	tty_standard_install(driver, tty);
+	tty->driver_data = port;
+
+	return 0;
 }
 
 static int fwloop_install(struct tty_driver *driver, struct tty_struct *tty)
 {
 	struct fwtty_port *port = fwtty_port_get(table_idx(tty->index));
-	int err;
 
-	err = tty_standard_install(driver, tty);
-	if (!err)
-		tty->driver_data = port;
-	else
-		fwtty_port_put(port);
-	return err;
+	tty_standard_install(driver, tty);
+	tty->driver_data = port;
+
+	return 0;
 }
 
 static int fwtty_write(struct tty_struct *tty, const unsigned char *buf, int c)
-- 
2.7.4


_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um


  parent reply	other threads:[~2018-09-04  2:46 UTC|newest]

Thread overview: 114+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-04  2:44 [PATCH 00/25] Change tty_port(standard)_install's return type Jaejoong Kim
2018-09-04  2:44 ` Jaejoong Kim
2018-09-04  2:44 ` [PATCH 01/25] tty: Change return type to void Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` [01/25] " Jaejoong Kim
2018-09-04 10:45   ` [PATCH 01/25] " Sergei Shtylyov
2018-09-04 10:45     ` Sergei Shtylyov
2018-09-04 10:45     ` [01/25] " Sergei Shtylyov
     [not found]     ` <CAL6iAaKzDPe7CMGR8VOBZRsJqZuNB1=zek_YVvwcKnjimbox2g@mail.gmail.com>
2018-09-05  5:57       ` [PATCH 01/25] " Jiri Slaby
2018-09-05  5:57         ` Jiri Slaby
2018-09-05  5:57         ` Jiri Slaby
2018-09-05  5:57         ` [01/25] " Jiri Slaby
2018-09-04  2:44 ` [PATCH 02/25] isdn: i4l: isdn_tty: " Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` [02/25] " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 03/25] s390: char: con3215: " Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` [03/25] " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 04/25] s390: char: tty3270: " Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` [04/25] " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 05/25] tty: hvc: hvc_console: " Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` [05/25] " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 06/25] tty: hvc: hvcs: " Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` [06/25] " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 07/25] tty: mips_ejtag_fdc: " Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` [07/25] " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 08/25] tty: n_gsm: " Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` [08/25] " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 09/25] tty: serial: kgdb_nmi: " Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` [09/25] " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 10/25] tty: synclink: " Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` [10/25] " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 11/25] tty: synclinkmp: " Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` [11/25] " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 12/25] tty: vt: " Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` [12/25] " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 13/25] usb: xhci: dbc: " Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` [13/25] " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 14/25] Bluetooth: " Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` [14/25] " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 15/25] um: " Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` [15/25] " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 16/25] isdn: capi: " Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` [16/25] " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 17/25] misc: pti: " Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` [17/25] " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 18/25] mmc: core: sdio_uart: " Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` [18/25] " Jaejoong Kim
2018-09-04  2:44 ` Jaejoong Kim [this message]
2018-09-04  2:44   ` [PATCH 19/25] staging: fwserial: " Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` [19/25] " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 20/25] staging: gdm724x: gdm_tty: " Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` [20/25] " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 21/25] staging: greybus: uart: " Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` [21/25] " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 22/25] tty: nozomi: " Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` [22/25] " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 23/25] tty: vcc: " Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` [23/25] " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 24/25] usb: cdc-acm: " Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` [24/25] " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 25/25] usb: usb-serial: " Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` Jaejoong Kim
2018-09-04  2:44   ` [25/25] " Jaejoong Kim
2018-09-04  4:42 ` [PATCH 00/25] Change tty_port(standard)_install's return type Sam Ravnborg
2018-09-04  4:42   ` Sam Ravnborg
2018-09-12 14:41 ` Alan Cox
2018-09-12 14:41   ` Alan Cox
2018-09-12 14:41   ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1536029091-4426-20-git-send-email-climbbb.kim@gmail.com \
    --to=climbbb.kim@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=jslaby@suse.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=netdev@vger.kernel.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.