From: Dan Williams <dan.j.williams@intel.com>
To: linux-nvdimm@lists.01.org
Subject: [ndctl PATCH 0/3] ndctl: Remove udev rule for latch and dirty-shutdown-count
Date: Mon, 17 Sep 2018 22:49:11 -0700 [thread overview]
Message-ID: <153724975102.55312.9664009456306267501.stgit@dwillia2-desk3.amr.corp.intel.com> (raw)
The latch needs to be coordinated with writes to the namespace and that
makes it not suitable as a dimm-add-event udev rule.
Additionally, the dirty-shutdown-count is something that can live in
sysfs alongside the other health state flags in /sys/.../nmemX/nfit.
Otherwise, calling any of the libndctl apis from a udev script means the
entire udev queue can get blocked behind a ndctl_bus_wait_probe() call.
That's too much overhead for a non-default policy.
In other words, while the latch event remains in userspace as close as
possible to the application that wants to manage dimm-flush-failed
policy as anything other than fatal, dirty-shutdown-count caching should
move to sysfs where it is cheap to implement and compliments the
flush-failed health state flag.
---
Dan Williams (3):
ndctl: Introduce dirty-dimm command
ndctl: Revert "ndctl, intel: Fallback to smart cached shutdown_count"
ndctl: Revert "ndctl: Create ndctl udev rules for dirty shutdown"
.gitignore | 1
Documentation/ndctl/Makefile.am | 1
Documentation/ndctl/ndctl-dirty-dimm.txt | 29 ++++++
Makefile.am | 3 -
builtin.h | 1
configure.ac | 10 --
contrib/80-ndctl.rules | 3 -
ndctl.spec.in | 3 -
ndctl/Makefile.am | 5 -
ndctl/dimm.c | 28 ++++++
ndctl/lib/intel.c | 41 --------
ndctl/lib/libndctl.c | 6 -
ndctl/lib/private.h | 3 -
ndctl/ndctl-udev.c | 150 ------------------------------
ndctl/ndctl.c | 1
15 files changed, 61 insertions(+), 224 deletions(-)
create mode 100644 Documentation/ndctl/ndctl-dirty-dimm.txt
delete mode 100644 contrib/80-ndctl.rules
delete mode 100644 ndctl/ndctl-udev.c
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next reply other threads:[~2018-09-18 6:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 5:49 Dan Williams [this message]
2018-09-18 5:49 ` [ndctl PATCH 1/3] ndctl: Introduce dirty-dimm command Dan Williams
2018-09-18 19:15 ` Verma, Vishal L
2018-09-18 19:49 ` Dan Williams
2018-09-18 5:49 ` [ndctl PATCH 2/3] ndctl: Revert "ndctl, intel: Fallback to smart cached shutdown_count" Dan Williams
2018-09-18 5:49 ` [ndctl PATCH 3/3] ndctl: Revert "ndctl: Create ndctl udev rules for dirty shutdown" Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153724975102.55312.9664009456306267501.stgit@dwillia2-desk3.amr.corp.intel.com \
--to=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.