All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: dave.jiang@intel.com
Cc: linux-nvdimm@lists.01.org
Subject: [PATCH] libnvdimm, security: Comment fixes
Date: Wed, 26 Sep 2018 19:22:28 -0700	[thread overview]
Message-ID: <153801494828.825550.15533638717371880458.stgit@dwillia2-desk3.amr.corp.intel.com> (raw)

Correct some spelling and stray comments.

Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
 drivers/nvdimm/dimm_devs.c |    8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/nvdimm/dimm_devs.c b/drivers/nvdimm/dimm_devs.c
index 06d0395c1f43..8740c6c61912 100644
--- a/drivers/nvdimm/dimm_devs.c
+++ b/drivers/nvdimm/dimm_devs.c
@@ -237,8 +237,8 @@ static int nvdimm_security_erase(struct device *dev, unsigned int keyid)
 	rc = nvdimm->security_ops->erase(nvdimm,
 			(struct nvdimm_key_data *) payload->data);
 	up_read(&key->sem);
-	/* remove key since secure erase kills the passphrase */
 
+	/* remove key since secure erase kills the passphrase */
 	if (!is_userkey) {
 		key_unlink(nvdimm_keyring, key);
 		key_invalidate(key);
@@ -423,14 +423,12 @@ static int nvdimm_security_change_key(struct device *dev,
 		goto out;
 	}
 
-	/* we need to check description as well */
-
 	if (!update)
 		key = nvdimm_replace_key(key);
 
 	/*
-	 * We don't need to release key->sem here because nvdimm_repalce_key
-	 * will.
+	 * We don't need to release key->sem here because
+	 * nvdimm_replace_key will.
 	 */
 	if (!key)
 		goto out;

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

             reply	other threads:[~2018-09-27  2:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-27  2:22 Dan Williams [this message]
2018-09-27 15:47 ` [PATCH] libnvdimm, security: Comment fixes Dave Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=153801494828.825550.15533638717371880458.stgit@dwillia2-desk3.amr.corp.intel.com \
    --to=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=linux-nvdimm@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.